Re: [lxc-devel] [PATCH] Set umask before populating /dev and restore it after.

2013-01-08 Thread Michael H. Warfield
That does, in fact, catch my case of setting autodev on with a non-systemd container (F14 in my case). That case is shot. Good catch. Regards, Mike On Tue, 2013-01-08 at 09:08 +0800, Alexander Vladimirov wrote: > According to docs, mknod clears each permission bit whose > corresponding bit in t

Re: [lxc-devel] [PATCH] Set umask before populating /dev and restore it after.

2013-01-08 Thread Stéphane Graber
On 01/07/2013 10:26 PM, Serge Hallyn wrote: > Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): >> According to docs, mknod clears each permission bit whose >> corresponding bit in the process umask is set, so we should fix it >> before creating device nodes. >> --- > > d'oh. T

Re: [lxc-devel] [PATCH] Set umask before populating /dev and restore it after.

2013-01-07 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > According to docs, mknod clears each permission bit whose > corresponding bit in the process umask is set, so we should fix it > before creating device nodes. > --- d'oh. Thank you. Acked-by: Serge E. Hallyn > src/lxc/conf

[lxc-devel] [PATCH] Set umask before populating /dev and restore it after.

2013-01-07 Thread Alexander Vladimirov
According to docs, mknod clears each permission bit whose corresponding bit in the process umask is set, so we should fix it before creating device nodes. --- src/lxc/conf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 85d72c9..c0a270f 100644 --- a/s