Re: [lxc-devel] [PATCH] Set high byte of mac addresses for host veth devices to 0xfe

2012-01-03 Thread Serge Hallyn
Hi - thanks for the update. Assuming the only thing you changed was catching the errno (there's no changelog but I assume so and don't want to take another close look), Acked-by: Serge Hallyn Let's apply and finally close this mysterious and aggravating (for some) chapter! :) thanks, -serge

Re: [lxc-devel] [PATCH] Set high byte of mac addresses for host veth devices to 0xfe

2011-12-21 Thread Christian Seiler
Hi again, > Sorry I didn't reply earlier. > >> Thanks, sorry for the trouble. Looks good, with one exception - if >> ioctl failed, then you may end up returning the wrong errno (from the >> close syscall). With that fixed, please do apply. > > Oh, yes, nice catch. I've attached a fixed patch

Re: [lxc-devel] [PATCH] Set high byte of mac addresses for host veth devices to 0xfe

2011-12-21 Thread Christian Seiler
Hi, Sorry I didn't reply earlier. > Thanks, sorry for the trouble. Looks good, with one exception - if > ioctl failed, then you may end up returning the wrong errno (from the > close syscall). With that fixed, please do apply. Oh, yes, nice catch. I've attached a fixed patch. Thanks! Chris

Re: [lxc-devel] [PATCH] Set high byte of mac addresses for host veth devices to 0xfe

2011-12-06 Thread Serge Hallyn
On 12/04/2011 05:18 PM, Daniel Lezcano wrote: > On 12/05/2011 12:11 AM, Serge Hallyn wrote: >> On 12/04/2011 04:28 AM, Daniel Lezcano wrote: >>> On 11/16/2011 05:49 PM, Christian Seiler wrote: Hi, I've run into the same problem as was discussed in BUG #3411497 [1] and on th

Re: [lxc-devel] [PATCH] Set high byte of mac addresses for host veth devices to 0xfe

2011-12-04 Thread Daniel Lezcano
On 12/05/2011 12:11 AM, Serge Hallyn wrote: > On 12/04/2011 04:28 AM, Daniel Lezcano wrote: >> On 11/16/2011 05:49 PM, Christian Seiler wrote: >>> Hi, >>> >>> I've run into the same problem as was discussed in BUG #3411497 [1] >>> and on >>> the users mailing list [2]. To solve this, I've decided t

Re: [lxc-devel] [PATCH] Set high byte of mac addresses for host veth devices to 0xfe

2011-12-04 Thread Serge Hallyn
On 12/04/2011 04:28 AM, Daniel Lezcano wrote: > On 11/16/2011 05:49 PM, Christian Seiler wrote: >> Hi, >> >> I've run into the same problem as was discussed in BUG #3411497 [1] and on >> the users mailing list [2]. To solve this, I've decided to implement the >> patch that was proposed on the maili

Re: [lxc-devel] [PATCH] Set high byte of mac addresses for host veth devices to 0xfe

2011-12-04 Thread Daniel Lezcano
On 11/16/2011 05:49 PM, Christian Seiler wrote: > Hi, > > I've run into the same problem as was discussed in BUG #3411497 [1] and on > the users mailing list [2]. To solve this, I've decided to implement the > patch that was proposed on the mailing list [3]. > > The attached patch is against curren

[lxc-devel] [PATCH] Set high byte of mac addresses for host veth devices to 0xfe

2011-11-16 Thread Christian Seiler
Hi, I've run into the same problem as was discussed in BUG #3411497 [1] and on the users mailing list [2]. To solve this, I've decided to implement the patch that was proposed on the mailing list [3]. The attached patch is against current trunk. Since trunk currently doesn't compile for me, I tes