Re: [lxc-devel] [PATCH] Fix some issues with inherited fd's

2011-08-23 Thread Greg Kurz
On Tue, 2011-08-23 at 13:37 +0400, Vladimir Smirnov wrote: > Hello! > > In attachment there are 2 patches to fix some issues with inherited > fd's. Instead of just exiting with error, maybe it's better to set > O_CLOEXEC flag. > Hello Vladimir ! I agree that inherited descriptors probably deser

[lxc-devel] [PATCH] Fix some issues with inherited fd's

2011-08-23 Thread Vladimir Smirnov
Hello! In attachment there are 2 patches to fix some issues with inherited fd's. Instead of just exiting with error, maybe it's better to set O_CLOEXEC flag. 1-st patch changes lxc-init and lxc-attach to use clone instead of fork. Reason for it: clone permits to set custom flags, so you can call