Re: [lxc-devel] [PATCH] Add lxc.disable_kmsg option

2013-03-13 Thread Serge Hallyn
Ok, I'll apply your first version from Mar 11 and push a patch on top of that to default it to 1. Thanks. -serge Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > I do agree as well, and prefer to stick with first variant, but I was > not sure what would be appropriate place

Re: [lxc-devel] [PATCH] Add lxc.disable_kmsg option

2013-03-13 Thread Alexander Vladimirov
I do agree as well, and prefer to stick with first variant, but I was not sure what would be appropriate place to initialize default value for that variable 2013/3/13 Serge Hallyn : > Alexander it's up to you - I do agree with Michael, but I don't want > any more of anyone's time spent on this, so

Re: [lxc-devel] [PATCH] Add lxc.disable_kmsg option

2013-03-13 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > well, this is kind of workaround for workaround, so I guess this > option won't stay there forever anyway Right, hopefully we'll get namespaced /dev/kmsg soon :) -serge

Re: [lxc-devel] [PATCH] Add lxc.disable_kmsg option

2013-03-13 Thread Serge Hallyn
Alexander it's up to you - I do agree with Michael, but I don't want any more of anyone's time spent on this, so if you want to stick with what you sent, just reply with 'ack' and I'll ack and push this patch. thanks, -serge Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > w

Re: [lxc-devel] [PATCH] Add lxc.disable_kmsg option

2013-03-13 Thread Michael Tokarev
13.03.2013 10:05, Alexander Vladimirov wrote: > Disables /dev/kmsg symlinking if set to 1. Maybe it is better to avoid negative setting? Like, lxc.link_kmsg = 1 (and make it the default) ? Thanks, /mjt -- Everyone ha

Re: [lxc-devel] [PATCH] Add lxc.disable_kmsg option

2013-03-13 Thread Alexander Vladimirov
well, this is kind of workaround for workaround, so I guess this option won't stay there forever anyway 2013/3/13 Michael Tokarev : > 13.03.2013 10:05, Alexander Vladimirov wrote: >> Disables /dev/kmsg symlinking if set to 1. > > Maybe it is better to avoid negative setting? > Like, > > lxc.link_

[lxc-devel] [PATCH] Add lxc.disable_kmsg option

2013-03-12 Thread Alexander Vladimirov
Disables /dev/kmsg symlinking if set to 1. Signed-off-by: Alexander Vladimirov --- doc/lxc.conf.sgml.in | 19 +++ src/lxc/conf.c | 6 -- src/lxc/conf.h | 1 + src/lxc/confile.c| 12 4 files changed, 36 insertions(+), 2 deletions(-) diff --git a