[lxc-devel] [PATCH] [RFC] lxc-init: fix odd signal mask manipulation

2011-10-11 Thread Matt Helsley
lxc init modifies a different signal mask in the loop than the one it's installing with sigaction in the loop. It appears that either these lines should move outside the loop, or the intent was to clear the bits of the sa_mask instead of the mask. Signed-off-by: Matt Helsley Should the

Re: [lxc-devel] Detecting if you are running in a container

2011-10-11 Thread Matt Helsley
begin tuning from a working configuration. They can learn about and tune those parts that prove significant for their workload. This is better because in the end it's not just about how efficient the user can make their containers but how much effort they will spend achieving and maintaining

Re: [lxc-devel] [PATCH 1/2]: Ensure freezer state has changed

2010-07-14 Thread Matt Helsley
s either FROZEN or THAWED, > read the freezer state and if it has not changed, repeat the write. Technically this is only necessary for the THAWED -> FROZEN transition. In other words, if we're FROZEN and write THAWED then we don't need to read the state. However, it doesn't hu

Re: [lxc-devel] [PATCH 1/5] start child in its own process group, and put it into the foreground

2010-06-11 Thread Matt Helsley
that from the parent and not from the > > child ? > > I can't think of one. It shouldn't matter, as long as the child can > open /dev/tty. I think shells implementing job control do it in the parent (shell) rather than the child (job) purely out of convention. It

Re: [lxc-devel] [PATCH 1/5] start child in its own process group, and put it into the foreground

2010-06-09 Thread Matt Helsley
On Wed, Jun 09, 2010 at 09:56:58PM +0200, Ferenc Wagner wrote: > Matt Helsley writes: > > > On Wed, Jun 09, 2010 at 07:56:03PM +0200, Ferenc Wagner wrote: > > > >> Signed-off-by: Ferenc Wagner > >> --- > >> src/lxc/start.c | 17 +++

Re: [lxc-devel] [PATCH 1/5] start child in its own process group, and put it into the foreground

2010-06-09 Thread Matt Helsley
EACCES An attempt was made to change the process group ID of one of the children of the calling process and the child had already per‐ formed an execve(2) (setpgid(), setpgrp()). You may be able to fix this by also doing setpgid() in the child

Re: [lxc-devel] [RFC][PATCH][lxc]: unfreeze while stopping

2010-06-09 Thread Matt Helsley
en pending signals aren't delivered until after the task is thawed. Acked-by: Matt Helsley > > Signed-off-by: Sukadev Bhattiprolu > --- > src/lxc/stop.c | 10 -- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/lxc/stop.c b/src/lxc/st

Re: [lxc-devel] Containerized syslog

2010-05-13 Thread Matt Helsley
syslog is split off, whether the host expects to be "Cc'd", etc. there could be some security implications. More importantly, the syslog control syscalls need to be modified to at least prevent cont