[lxc-devel] [PATCH 1/1] lxc-user-nic: dont risk passing EOF

2013-11-22 Thread Serge Hallyn
Signed-off-by: Serge Hallyn --- src/lxc/lxc_user_nic.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/lxc/lxc_user_nic.c b/src/lxc/lxc_user_nic.c index af1e944..a4ae907 100644 --- a/src/lxc/lxc_user_nic.c +++ b/src/lxc/lxc_user_nic.c @@ -137,1

[lxc-devel] [PATCH 1/1] lxc-user-nic: use common code from network.c

2013-11-22 Thread Serge Hallyn
This pulls a lot of common code out of lxc_user_nic.c. It also moves one function from conf.c that was duplicated in lxc_user_nic.c (It removes a DEBUG statement because (a) it doesn't seem actually useful and (b) DEBUG doesn't work in network.c). Also replace the old test of only parsing code wi

[lxc-devel] [lxc/lxc] ea0da5: don't fail lxc-init if we couldn't mount proc

2013-11-22 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: ea0da529721d9d2b13d3807746130d66730b0eab https://github.com/lxc/lxc/commit/ea0da529721d9d2b13d3807746130d66730b0eab Author: Serge Hallyn Date: 2013-11-22 (Fri, 22 Nov 2013) Changed paths: M src/lxc/lxc_in

Re: [lxc-devel] [PATCH 1/1] don't fail lxc-init if we couldn't mount proc

2013-11-22 Thread Stéphane Graber
On Fri, Nov 22, 2013 at 03:45:40PM -0600, Serge Hallyn wrote: > In general proc gets mounted ahead of time, so init shouldn't > have to do it. Without this patch, you cannot > > lxc-execute -n x1 -s lxc.cap.drop=sys_admin /bin/bash > > (See https://bugs.launchpad.net/ubuntu/+source/lxc/+bu

[lxc-devel] [PATCH 1/1] don't fail lxc-init if we couldn't mount proc

2013-11-22 Thread Serge Hallyn
In general proc gets mounted ahead of time, so init shouldn't have to do it. Without this patch, you cannot lxc-execute -n x1 -s lxc.cap.drop=sys_admin /bin/bash (See https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1253669 for a bug about this) Signed-off-by: Serge Hallyn --- src/l

[lxc-devel] [lxc/lxc] 4355ab: lxcapi_destroy: run in a namespace if we are unpri...

2013-11-22 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 4355ab5fabd56cab1f41d5286b4dc99ef2e7ebe9 https://github.com/lxc/lxc/commit/4355ab5fabd56cab1f41d5286b4dc99ef2e7ebe9 Author: Serge Hallyn Date: 2013-11-22 (Fri, 22 Nov 2013) Changed paths: M src/lxc/bdev.c

Re: [lxc-devel] [PATCH v2] lxcapi_destroy: run in a namespace if we are unprivileged

2013-11-22 Thread Stéphane Graber
On Fri, Nov 22, 2013 at 02:39:37PM -0600, Serge Hallyn wrote: > This is necessary to have the rights to remove files owned by our subuids. > > Also update lxc_rmdir_onedev to return 0 on success, -1 on failure. > Callers were not consistent in using it correctly, and this is more > in keeping with

[lxc-devel] [PATCH v2] lxcapi_destroy: run in a namespace if we are unprivileged

2013-11-22 Thread Serge Hallyn
This is necessary to have the rights to remove files owned by our subuids. Also update lxc_rmdir_onedev to return 0 on success, -1 on failure. Callers were not consistent in using it correctly, and this is more in keeping with the rest of our code. Signed-off-by: Serge Hallyn --- src/lxc/bdev.c

Re: [lxc-devel] [PATCH 1/1] lxcapi_destroy: run in a namespace if we are unprivileged

2013-11-22 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@ubuntu.com): > This is necessary to have the rights to remove files owned by our subuids. > > Also fix up a wrong return value from lxc_rmdir_onedev(). It's > expected to return -1 on error, not 1. Eh, hold on, let me fix up all the callers. I made a mess. --

[lxc-devel] [PATCH 1/1] lxcapi_destroy: run in a namespace if we are unprivileged

2013-11-22 Thread Serge Hallyn
This is necessary to have the rights to remove files owned by our subuids. Also fix up a wrong return value from lxc_rmdir_onedev(). It's expected to return -1 on error, not 1. Signed-off-by: Serge Hallyn --- src/lxc/conf.c | 155 - src/l

[lxc-devel] [lxc/lxc] dfd6d8: Add lxc.service to extra_DIST

2013-11-22 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: dfd6d8f0190ac5676ca0ef00669b9a11f59bd356 https://github.com/lxc/lxc/commit/dfd6d8f0190ac5676ca0ef00669b9a11f59bd356 Author: Stéphane Graber Date: 2013-11-22 (Fri, 22 Nov 2013) Changed paths: M src/lxc/Mak

[lxc-devel] [lxc/lxc] d3d351: add lxc-usernsexec to .gitignore

2013-11-22 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: d3d35117e319ad20f6d685840db9d7d86bd7f5dd https://github.com/lxc/lxc/commit/d3d35117e319ad20f6d685840db9d7d86bd7f5dd Author: S.Çağlar Onur Date: 2013-11-22 (Fri, 22 Nov 2013) Changed paths: M .gitignore

Re: [lxc-devel] [PATCH] add lxc-usernsexec to .gitignore

2013-11-22 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > Signed-off-by: S.Çağlar Onur Oh yeah, noticed it for a moment last night then forgot. Thanks. Acked-by: Serge E. Hallyn > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 82b144a..b3eff27 100

[lxc-devel] [PATCH] add lxc-usernsexec to .gitignore

2013-11-22 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 82b144a..b3eff27 100644 --- a/.gitignore +++ b/.gitignore @@ -68,6 +68,7 @@ src/lxc/lxc-start-ephemeral src/lxc/lxc-stop src/lxc/lxc-unfreeze src/lxc/lxc-unshare +src/l

[lxc-devel] [lxc/lxc] 59328d: remove HAVE_NEWUIDMAP and NEWUIDMAP

2013-11-22 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 59328d58d3914b4acaf5d7b0b404e61e19c1c652 https://github.com/lxc/lxc/commit/59328d58d3914b4acaf5d7b0b404e61e19c1c652 Author: Serge Hallyn Date: 2013-11-22 (Fri, 22 Nov 2013) Changed paths: M configure.ac