[lxc-devel] [PATCH] p is a pointer and cannot be negative so check if it is NULL

Signed-off-by: S.Çağlar Onur --- src/lxc/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/utils.c b/src/lxc/utils.c index 3fab9ae..e2d2639 100644 --- a/src/lxc/utils.c +++ b/src/lxc/utils.c @@ -483,7 +483,7 @@ int sha1sum_file(char *fnam, unsigned char *digest)

[lxc-devel] [PATCH] free previously allocated memory if realloc fails in src/lxc/lsm/apparmor.c

Signed-off-by: S.Çağlar Onur --- src/lxc/lsm/apparmor.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/lxc/lsm/apparmor.c b/src/lxc/lsm/apparmor.c index aaf8056..f7f2ff9 100644 --- a/src/lxc/lsm/apparmor.c +++ b/src/lxc/lsm/apparmor.c @@ -68,7 +68,7 @@ static char

[lxc-devel] [PATCH] fix memory leaks reported by cppcheck in src/lxc/lxc_monitor.c. Since this is a cli tool it doesn't really matter but might silence some warnings for debugging

Signed-off-by: S.Çağlar Onur --- src/lxc/lxc_monitor.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_monitor.c b/src/lxc/lxc_monitor.c index 0c27723..4f56308 100644 --- a/src/lxc/lxc_monitor.c +++ b/src/lxc/lxc_monitor.c @@ -89,8 +89,10 @@ int main(int

Re: [lxc-devel] [PATCH] add missing paranthesis

Please don't apply this as it contains an unrelated chunk in it. Correct one will hit the list in a minute. On Thu, Nov 14, 2013 at 11:21 PM, S.Çağlar Onur wrote: > Signed-off-by: S.Çağlar Onur > --- > src/lxc/lsm/apparmor.c | 1 + > src/lxc/lxccontainer.c | 4 ++-- > 2 files changed, 3 inserti

[lxc-devel] [PATCH] add missing paranthesis (v2)

Signed-off-by: S.Çağlar Onur --- src/lxc/lxccontainer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index 3cabf0d..11e70cb 100644 --- a/src/lxc/lxccontainer.c +++ b/src/lxc/lxccontainer.c @@ -2958,9 +2958,9 @@ static bool

[lxc-devel] [PATCH] add missing paranthesis

Signed-off-by: S.Çağlar Onur --- src/lxc/lsm/apparmor.c | 1 + src/lxc/lxccontainer.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/lxc/lsm/apparmor.c b/src/lxc/lsm/apparmor.c index aaf8056..a8d36c1 100644 --- a/src/lxc/lsm/apparmor.c +++ b/src/lxc/lsm/apparmor.c @@

[lxc-devel] [PATCH] fix memory leaks reported by cppcheck in src/lxc/bdev.c

Signed-off-by: S.Çağlar Onur --- src/lxc/bdev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c index c7e5e5e..6acd29a 100644 --- a/src/lxc/bdev.c +++ b/src/lxc/bdev.c @@ -962,8 +962,10 @@ static int lvm_snapshot(const char *orig, const cha

[lxc-devel] [lxc/lxc] 4df7f0: lxc-start: if we pass in a config file, then don't...

Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 4df7f012b9994ea54b1ad68176d8d45a57fa02f3 https://github.com/lxc/lxc/commit/4df7f012b9994ea54b1ad68176d8d45a57fa02f3 Author: Serge Hallyn Date: 2013-11-14 (Thu, 14 Nov 2013) Changed paths: M src/lxc/lxc_st

Re: [lxc-devel] [PATCH 1/1] lxc-start: if we pass in a config file, then don't use any loaded config

On Thu, Nov 14, 2013 at 12:48:41PM -0600, Serge Hallyn wrote: > To do this, add a c->clear_config() helper to the api. > > (this fixes the bug https://bugs.launchpad.net/bugs/1251352) > > Signed-off-by: Serge Hallyn Acked-by: Stéphane Graber > --- > src/lxc/lxc_start.c| 1 + > src/lxc/l

[lxc-devel] [PATCH 1/1] lxc-start: if we pass in a config file, then don't use any loaded config

To do this, add a c->clear_config() helper to the api. (this fixes the bug https://bugs.launchpad.net/bugs/1251352) Signed-off-by: Serge Hallyn --- src/lxc/lxc_start.c| 1 + src/lxc/lxccontainer.c | 16 +++- src/lxc/lxccontainer.h | 2 ++ 3 files changed, 14 insertions(+), 5 d

[lxc-devel] [lxc/lxc] 41f683: gather all locking related code into src/lxc/lxclo...

Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 41f683579c0625e22a838ffa6d4297c09b5837e2 https://github.com/lxc/lxc/commit/41f683579c0625e22a838ffa6d4297c09b5837e2 Author: S.Çağlar Onur Date: 2013-11-14 (Thu, 14 Nov 2013) Changed paths: M src/lxc/lxclo

Re: [lxc-devel] [PATCH] gather all locking related code into src/lxc/lxclock.c

Quoting S.Çağlar Onur (cag...@10ur.org): > Signed-off-by: S.Çağlar Onur Thanks. Acked-by: Serge E. Hallyn > --- > src/lxc/lxclock.c | 74 > +-- > src/lxc/lxclock.h | 3 +++ > src/lxc/utils.c | 57 +

Re: [lxc-devel] [PATCH] setup_netdev: re-read ifindex in LXC_NET_PHYS case

> -Original Message- > From: Serge Hallyn [mailto:serge.hal...@ubuntu.com] > Sent: Thursday, November 14, 2013 5:24 PM > To: Purcareata Bogdan-B43198 > Cc: lxc-devel@lists.sourceforge.net > Subject: Re: [lxc-devel] [PATCH] setup_netdev: re-read ifindex in LXC_NET_PHYS > case > > Quoting Bo

[lxc-devel] [lxc/lxc] b466dc: setup_netdev: re-read ifindex in LXC_NET_PHYS case

Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: b466dc337caba11688820e9ef79c5dc20de904cc https://github.com/lxc/lxc/commit/b466dc337caba11688820e9ef79c5dc20de904cc Author: Bogdan Purcareata Date: 2013-11-14 (Thu, 14 Nov 2013) Changed paths: M src/lxc/c

Re: [lxc-devel] [PATCH] setup_netdev: re-read ifindex in LXC_NET_PHYS case

Quoting Bogdan Purcareata (bogdan.purcare...@freescale.com): > When moving an interface from the host netns to a container's, > the ifindex might not remain the same. This happens when the > index of the host interface is already assigned to another interface > in the new netns. > > For veth/vlan/

[lxc-devel] [PATCH] setup_netdev: re-read ifindex in LXC_NET_PHYS case

When moving an interface from the host netns to a container's, the ifindex might not remain the same. This happens when the index of the host interface is already assigned to another interface in the new netns. For veth/vlan/macvlan, virtual interfaces are first created on the host, and then moved