Quoting Serge Hallyn (serge.hal...@ubuntu.com):
> Quoting Dwight Engen (dwight.en...@oracle.com):
> > Signed-off-by: Dwight Engen
>
> Hi,
>
> One comment below:
fwiw there's no resulting error so
Acked-by: Serge E. Hallyn
but if you don't see any reason not to i'll pull the qsort out.
>
>
Quoting Dwight Engen (dwight.en...@oracle.com):
> Found by running the lxc-test-list test with valgrind. The names were
> put into a local array, and never freed in the success case where the
> caller didn't want the names returned and in the early out failure case.
>
> Note we don't need to check
Quoting Dwight Engen (dwight.en...@oracle.com):
> Signed-off-by: Dwight Engen
Acked-by: Serge E. Hallyn
> ---
> src/tests/list.c | 97
> +---
> 1 file changed, 36 insertions(+), 61 deletions(-)
>
> diff --git a/src/tests/list.c b/src/tests/
Quoting Dwight Engen (dwight.en...@oracle.com):
> Signed-off-by: Dwight Engen
Hi,
One comment below:
> ---
> src/lxc/lxccontainer.c | 97
> +++---
> src/lxc/lxccontainer.h | 10 ++
> 2 files changed, 103 insertions(+), 4 deletions(-)
>
> diff -
Branch: refs/heads/master
Home: https://github.com/lxc/lxc
Commit: 4012c89148c42dc7c15809bec348746681f96edd
https://github.com/lxc/lxc/commit/4012c89148c42dc7c15809bec348746681f96edd
Author: Stéphane Graber
Date: 2013-11-05 (Tue, 05 Nov 2013)
Changed paths:
M src/tests/c
Quoting Stéphane Graber (stgra...@ubuntu.com):
> On Tue, Nov 05, 2013 at 02:14:33PM -0600, Serge Hallyn wrote:
> > conf.c/conf.h: have replaced bool hostid_is_mapped() with int
> > mapped_hostid()
> >which returns the mapped uid for the caller's uid on the host, or -1 if
> >none
> >
> > c
Quoting Stéphane Graber (stgra...@ubuntu.com):
> On Tue, Nov 05, 2013 at 02:15:00PM -0600, Serge Hallyn wrote:
> > To do so we do a quick setns into the container's netns. This
> > (unexpectedly) turns out cleaner than trying to rename it from
> > lxc_setup(), because we don't know the original ni
On Tue, Nov 05, 2013 at 02:15:00PM -0600, Serge Hallyn wrote:
> To do so we do a quick setns into the container's netns. This
> (unexpectedly) turns out cleaner than trying to rename it from
> lxc_setup(), because we don't know the original nic name in
> the container until we created it which we
On Tue, Nov 05, 2013 at 02:14:33PM -0600, Serge Hallyn wrote:
> conf.c/conf.h: have replaced bool hostid_is_mapped() with int mapped_hostid()
>which returns the mapped uid for the caller's uid on the host, or -1 if
>none
>
> create_run_template: pass caller's uid into template.
>
> lxc-ub
On Tue, Nov 05, 2013 at 02:12:58PM -0600, Serge Hallyn wrote:
> With this patchset I am able to create and run ubuntu-cloud containers
> as non-root user. Note this requires an uptodate ubuntu trusty host to
> get a userns-enabled kernel. The steps:
>
> 1. install uidmap
> sudo apt-get ins
conf.c/conf.h: have replaced bool hostid_is_mapped() with int mapped_hostid()
which returns the mapped uid for the caller's uid on the host, or -1 if
none
create_run_template: pass caller's uid into template.
lxc-ubuntu-cloud:
1. accept --mapped-uid argument
2. don't write t
To do so we do a quick setns into the container's netns. This
(unexpectedly) turns out cleaner than trying to rename it from
lxc_setup(), because we don't know the original nic name in
the container until we created it which we do in the parent
after the init has been cloned.
Signed-off-by: Serge
With this patchset I am able to create and run ubuntu-cloud containers
as non-root user. Note this requires an uptodate ubuntu trusty host to
get a userns-enabled kernel. The steps:
1. install uidmap
sudo apt-get install uidmap
2. make sure to have a range of allocated subuids, i.e.
Branch: refs/heads/master
Home: https://github.com/lxc/lxc
Commit: 3da0feef099c7da83352525fe4930dc9f7a3df82
https://github.com/lxc/lxc/commit/3da0feef099c7da83352525fe4930dc9f7a3df82
Author: Stéphane Graber
Date: 2013-11-05 (Tue, 05 Nov 2013)
Changed paths:
M src/lxc/uti
Signed-off-by: Dwight Engen
---
src/lxc/lxccontainer.c | 97 +++---
src/lxc/lxccontainer.h | 10 ++
2 files changed, 103 insertions(+), 4 deletions(-)
diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c
index 89b45ed..d7d3273 100644
--- a/
Found by running the lxc-test-list test with valgrind. The names were
put into a local array, and never freed in the success case where the
caller didn't want the names returned and in the early out failure case.
Note we don't need to check the return from remove_from_array() because
we just succe
- allow lxc-info to show more than one container, using regex for the name
Signed-off-by: Dwight Engen
---
doc/lxc-info.sgml.in | 65 -
src/lxc/lxc_info.c | 257 +++
2 files changed, 300 insertions(+), 22 deletions(-)
diff --git a/d
Signed-off-by: Dwight Engen
---
src/tests/list.c | 97 +---
1 file changed, 36 insertions(+), 61 deletions(-)
diff --git a/src/tests/list.c b/src/tests/list.c
index a061542..af41e7f 100644
--- a/src/tests/list.c
+++ b/src/tests/list.c
@@ -21,90
Hi Stéphane,
I was able to add the ***containers output fairly in a fairly
straightforward manner. I also split out the patch into more discrete
logical changes, adding/refactoring the list.c test and fixing a leak in
list_active_containers() along the way. Serge, hopefully you don't mind
I rename
Branch: refs/heads/master
Home: https://github.com/lxc/lxc
Commit: 6502006a44d27a27fe1e2d9d8cac721c0ec8907a
https://github.com/lxc/lxc/commit/6502006a44d27a27fe1e2d9d8cac721c0ec8907a
Author: Dwight Engen
Date: 2013-11-05 (Tue, 05 Nov 2013)
Changed paths:
M src/lxc/lxccon
Please do not apply the previous version of this patch, it is wrong. I
didn't take into account that priv is a union, so priv.veth_attr.pair
is only a pointer when netdev type is VETH. The following patch works
when non-veth nics are also present.
--
Signed-off-by: Dwight Engen
---
src/lxc/conf
Quoting Stéphane Graber (stgra...@ubuntu.com):
> On Mon, Nov 04, 2013 at 02:44:44PM -0600, Serge Hallyn wrote:
> > So we don't always have to give full paths.
> >
> > realpath(x,NULL) mallocs memory, but these paths shouldn't get called
> > from the API so not freeing should be ok.
> >
>
> What'
On Mon, 4 Nov 2013 18:12:15 -0500
Stéphane Graber wrote:
> On Mon, Nov 04, 2013 at 05:35:19PM -0500, Dwight Engen wrote:
> > - added list_all_containers() which returns both defined and
> > active containers.
> >
> > - allow lxc-info to show more than one container, using regex for
> > the nam
23 matches
Mail list logo
