Re: [lxc-devel] lxc-start: Failed to find current cgroup

2013-08-19 Thread Harald Dunkel
Hi folks, On 08/19/13 00:57, Christian Seiler wrote: > Hi there, > > FYI: I had the same problem with current staging and the first patch I > sent in my latest series fixes this: > > http://thread.gmane.org/gmane.linux.kernel.containers.lxc.devel/3977 > > -- Christian > The current version fb760f7

Re: [lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

2013-08-19 Thread Michael H. Warfield
On Mon, 2013-08-19 at 16:57 -0500, Serge Hallyn wrote: > Quoting Christian Seiler (christ...@iwakd.de): > > Hi Serge, > > > > > Thanks, Christian - I've pushed a new patch to github on top of yours. > > > Regular start/stop/lxc-cgroup stuff is working for me both with all > > > cgroups composed a

Re: [lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

2013-08-19 Thread Christian Seiler
Hi Serge, >> I do have a very stupid question, however: LXC 0.9 used to set the >> cgroup to /lxc/$name. Now it's just /$name. Is that intentional? > > Hm, it was somewhat unconscious but I didn't really mean to do that. > Some cgroup subsystems do incur a performance penalty for every > extra di

Re: [lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

2013-08-19 Thread Stéphane Graber
On Mon, Aug 19, 2013 at 04:57:10PM -0500, Serge Hallyn wrote: > Quoting Christian Seiler (christ...@iwakd.de): > > Hi Serge, > > > > > Thanks, Christian - I've pushed a new patch to github on top of yours. > > > Regular start/stop/lxc-cgroup stuff is working for me both with all > > > cgroups comp

Re: [lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

2013-08-19 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi Serge, > > > Thanks, Christian - I've pushed a new patch to github on top of yours. > > Regular start/stop/lxc-cgroup stuff is working for me both with all > > cgroups composed and separately mounted. > > I can confirm that it works on my setup.

Re: [lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

2013-08-19 Thread Christian Seiler
Hi Serge, > Thanks, Christian - I've pushed a new patch to github on top of yours. > Regular start/stop/lxc-cgroup stuff is working for me both with all > cgroups composed and separately mounted. I can confirm that it works on my setup. I do have a very stupid question, however: LXC 0.9 used to

Re: [lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

2013-08-19 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi Serge, > > > This needs to just be > > > > oldlen = newlen; > > Oh, yes, that's right, it's the buffer length and not the string length. > Sorry, I did that late at night and some things got mixed up in my head. > > >> @@ -1128,7 +1152,7 @

Re: [lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

2013-08-19 Thread Christian Seiler
Hi Serge, > This needs to just be > > oldlen = newlen; Oh, yes, that's right, it's the buffer length and not the string length. Sorry, I did that late at night and some things got mixed up in my head. >> @@ -1128,7 +1152,7 @@ void lxc_cgroup_destroy_desc(struct cgroup_desc >> *cgroups) >

Re: [lxc-devel] [PATCH] ubuntu-cloud-prep: improve overlayfs workaround

2013-08-19 Thread Serge Hallyn
Quoting Scott Moser (smo...@ubuntu.com): > the previous 'patch_start' can be vastly simplified now that I better > understand what the bug was. Instead of wrapping 'start', we only > need to ensure that /etc/init exists inside the overlayfs, so that the > directory that upstart watches is guarante

Re: [lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

2013-08-19 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@ubuntu.com): > Quoting Christian Seiler (christ...@iwakd.de): > > This fixes some minor bugs in the cgroup logic that made start and > > attach fail (at least when all cgroup controllers were mounted > > together). > > > > Signed-off-by: Christian Seiler > > Tha

[lxc-devel] [PATCH] ubuntu-cloud-prep: improve overlayfs workaround

2013-08-19 Thread Scott Moser
the previous 'patch_start' can be vastly simplified now that I better understand what the bug was. Instead of wrapping 'start', we only need to ensure that /etc/init exists inside the overlayfs, so that the directory that upstart watches is guaranteed to be in the overlay, not the underlay. The p

Re: [lxc-devel] [PATCH 2/5] attach: Fix minor memory leak in environment variable handling

2013-08-19 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Signed-off-by: Christian Seiler Acked-by: Serge E. Hallyn > --- > src/lxc/attach.c |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/lxc/attach.c b/src/lxc/attach.c > index 950fe9a..2e94b70 100644 > --- a/src/lxc/attach.c >

Re: [lxc-devel] [PATCH 3/5] python/attach: Fix minor memory leaks

2013-08-19 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Signed-off-by: Christian Seiler Acked-by: Serge E. Hallyn > --- > src/python-lxc/lxc.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/src/python-lxc/lxc.c b/src/python-lxc/lxc.c > index ddf3fa0..f4d

Re: [lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

2013-08-19 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > This fixes some minor bugs in the cgroup logic that made start and > attach fail (at least when all cgroup controllers were mounted > together). > > Signed-off-by: Christian Seiler Thanks, a few comments. > --- > src/lxc/cgroup.c | 31 +++

Re: [lxc-devel] [PATCH 00/17] Android/Bionic compatibility changes

2013-08-19 Thread Stéphane Graber
On Fri, Aug 16, 2013 at 05:13:46PM +0200, Stéphane Graber wrote: > LXC recently regressed with regard to Android/Bionic buildability, the > following commits try to address that. > > With those changes, LXC now builds with an up to date NDK using > android-9. This patchset has now been pushed ups

Re: [lxc-devel] [PATCH] install attach_options.h into /usr/include/lxc

2013-08-19 Thread Stéphane Graber
On Mon, Aug 19, 2013 at 07:27:47AM -0500, Serge Hallyn wrote: > Quoting S.Çağlar Onur (cag...@10ur.org): > > Signed-off-by: S.Çağlar Onur > > Acked-by: Serge E. Hallyn > > > --- > > src/lxc/Makefile.am | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/lxc/Makefile.am b/src/lx

Re: [lxc-devel] [PATCH] install attach_options.h into /usr/include/lxc

2013-08-19 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > Signed-off-by: S.Çağlar Onur Acked-by: Serge E. Hallyn > --- > src/lxc/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/lxc/Makefile.am b/src/lxc/Makefile.am > index 9d6b5b4..d338ddd 100644 > --- a/src/lxc/Makefile.am > +++ b/

Re: [lxc-devel] [PATCH 11/17] Use srand/rand instead of initstate/random

2013-08-19 Thread Stéphane Graber
On Fri, Aug 16, 2013 at 05:25:34PM +0100, Daniel P. Berrange wrote: > On Fri, Aug 16, 2013 at 06:01:25PM +0200, Stéphane Graber wrote: > > On Fri, Aug 16, 2013 at 10:36:58AM -0500, Serge Hallyn wrote: > > > Quoting Stéphane Graber (stgra...@ubuntu.com): > > > > initstate/random doesn't work on bion