Re: [lxc-devel] [PATCH] ubuntu: Fix openssh postinst call in >= saucy

2013-07-08 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > The new openssh uses a different mechanism to start/stop the daemon > which in turn requires a few tweaks in our template to deal with both > the new and old ways of doing that. > > Signed-off-by: Stéphane Graber Thanks, Stéphane, that worked! (B

Re: [lxc-devel] [PATCH] fix sshd template

2013-07-08 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Mon, 8 Jul 2013 09:55:57 -0500 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > Commit a0a2066d introduced an lxc subdir into the lxc-init path, but > > > this was never reflected in the sshd template. Add it th

Re: [lxc-devel] [PATCH] fix sshd template

2013-07-08 Thread Dwight Engen
On Mon, 8 Jul 2013 09:55:57 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > Commit a0a2066d introduced an lxc subdir into the lxc-init path, but > > this was never reflected in the sshd template. Add it there. > > Hm, looking at that commit, it seems like choose_i

Re: [lxc-devel] [PATCH] Make get_ips timeout poll configurable

2013-07-08 Thread John McFarlane
Thank you :) On Mon, Jul 8, 2013 at 10:56 AM, Stéphane Graber wrote: > On Mon, Jul 08, 2013 at 10:26:09AM -0700, John McFarlane wrote: > > Locally I find 5 seconds to be inadequate to reliably obtain the ip > > address of a container. This commit only adds an option, a subsequent > > commit cou

Re: [lxc-devel] [PATCH] Make get_ips timeout poll configurable

2013-07-08 Thread Stéphane Graber
On Mon, Jul 08, 2013 at 10:26:09AM -0700, John McFarlane wrote: > Locally I find 5 seconds to be inadequate to reliably obtain the ip > address of a container. This commit only adds an option, a subsequent > commit could increase the default (5) if that seems reasonable. > > Signed-off-by: John M

[lxc-devel] [PATCH] Make get_ips timeout poll configurable

2013-07-08 Thread John McFarlane
Locally I find 5 seconds to be inadequate to reliably obtain the ip address of a container. This commit only adds an option, a subsequent commit could increase the default (5) if that seems reasonable. Signed-off-by: John McFarlane --- src/lxc/lxc-start-ephemeral.in | 5 - 1 file changed, 4

Re: [lxc-devel] [PATCH RFC] Accomodate stricter devices cgroup rules

2013-07-08 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@ubuntu.com): > 3.10 kernel comes with proper hierarchical enforcement of devices > cgroup. To keep that code somewhat sane, certain things are not > allowed. Switching from default-allow to default-deny and vice versa > are not allowed when there are children cg

[lxc-devel] [PATCH] ubuntu: Fix openssh postinst call in >= saucy

2013-07-08 Thread Stéphane Graber
The new openssh uses a different mechanism to start/stop the daemon which in turn requires a few tweaks in our template to deal with both the new and old ways of doing that. Signed-off-by: Stéphane Graber --- templates/lxc-ubuntu.in | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-)

Re: [lxc-devel] [PATCH] python: Update scripts to respect PEP-8 spec

2013-07-08 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > src/python-lxc/examples/pyconsole-vte.py | 2 ++ > src/python-lxc/examples/pyconsole.py | 3 ++- > src/python-lxc/lxc/__init__.py | 7 --- > 3 files changed, 8 in

Re: [lxc-devel] [PATCH] python: Re-introduce timeout in get_ips

2013-07-08 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > It turns out that most API users want some kind of timeout option for > get_ips, so instead of re-implementing it in every single client > software, let's just have it as a python overlay upstream. > > Signed-off-by: Stéphane Graber Acked-by: Serg

Re: [lxc-devel] [PATCH] lxc-start-ephemeral: Fix console() and add storage option

2013-07-08 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > The introduction of the new console() python API broke > lxc-start-ephemeral's console(tty=1) call, I now changed that to > console() which does the right thing with both API versions. > > This also adds a new storage-type option, letting the user c

[lxc-devel] [PATCH] lxc-start-ephemeral: Fix console() and add storage option

2013-07-08 Thread Stéphane Graber
The introduction of the new console() python API broke lxc-start-ephemeral's console(tty=1) call, I now changed that to console() which does the right thing with both API versions. This also adds a new storage-type option, letting the user choose to use a standard directory instead of tmpfs for th

Re: [lxc-devel] [PATCH] fix sshd template

2013-07-08 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > Commit a0a2066d introduced an lxc subdir into the lxc-init path, but > this was never reflected in the sshd template. Add it there. Hm, looking at that commit, it seems like choose_init() should also search for LXCINITDIR "/lxc-init". Is there any

[lxc-devel] [PATCH] python: Update scripts to respect PEP-8 spec

2013-07-08 Thread Stéphane Graber
Signed-off-by: Stéphane Graber --- src/python-lxc/examples/pyconsole-vte.py | 2 ++ src/python-lxc/examples/pyconsole.py | 3 ++- src/python-lxc/lxc/__init__.py | 7 --- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/python-lxc/examples/pyconsole-vte.py b/sr

[lxc-devel] [PATCH] python: Re-introduce timeout in get_ips

2013-07-08 Thread Stéphane Graber
It turns out that most API users want some kind of timeout option for get_ips, so instead of re-implementing it in every single client software, let's just have it as a python overlay upstream. Signed-off-by: Stéphane Graber --- src/lxc/lxc-start-ephemeral.in | 8 +--- src/python-lxc/lxc/__