Quoting Stéphane Graber (stgra...@ubuntu.com):
> On 05/29/2013 11:21 PM, Serge Hallyn wrote:
> > And update the comment explaining the locking.
> >
> > Also take memlock in want_daemonize.
> >
> > Signed-off-by: Serge Hallyn
>
> Is that patch still relevant?
>
> It doesn't appear to have been
On 05/31/2013 11:35 AM, Serge Hallyn wrote:
> And use it in place of the various ways we were deducing
> /etc/lxc/default.conf.
>
> Signed-off-by: Serge Hallyn
Acked-by: Stéphane Graber
> ---
> configure.ac | 1 +
> src/lxc/Makefile.am| 3 ++-
> src/lxc/lxc_create.c
On 05/29/2013 11:21 PM, Serge Hallyn wrote:
> And update the comment explaining the locking.
>
> Also take memlock in want_daemonize.
>
> Signed-off-by: Serge Hallyn
Is that patch still relevant?
It doesn't appear to have been reviewed/applied to staging and touches
bits that have been changed
On 05/31/2013 11:34 AM, Serge Hallyn wrote:
> configure/makefile: rename default_conf to distro_conf, since it is a
> per-distro
> default. Then we'll be able to use the symbol LXC_DEFAULT_CONF in the code to
> refer to the installed file.
>
> Signed-off-by: Serge Hallyn
Hopefully that'll make
On 05/31/2013 09:13 AM, Serge Hallyn wrote:
> Update the LOCKING comment.
>
> Take mem_lock in want_daemonize.
>
> convert lxcapi_destroy to not use privlock/slock by hand.
>
> Fix a coverity-found potential dereference of NULL c->lxc_conf.
>
> api_cgroup_get_item() and api_cgroup_set_item(): u
And use it in place of the various ways we were deducing /etc/lxc/default.conf.
Signed-off-by: Serge Hallyn
---
configure.ac | 1 +
src/lxc/Makefile.am| 3 ++-
src/lxc/lxc_create.c | 4 +---
src/lxc/lxccontainer.c | 3 ---
src/tests/Makefile.am | 3 ++-
src/t
configure/makefile: rename default_conf to distro_conf, since it is a per-distro
default. Then we'll be able to use the symbol LXC_DEFAULT_CONF in the code to
refer to the installed file.
Signed-off-by: Serge Hallyn
---
config/Makefile.am | 4 ++--
configure.ac | 8
2 files chang
On 05/31/2013 02:08 AM, Harald Dunkel wrote:
> Hi Stéphane,
>
> On 05/30/13 17:39, Stéphane Graber wrote:
>>
>> If we were to use groups for everything, we'd end up having to reserve
>> "disabled", "autostart", "last-state".
>>
>> And then make those 3 conflict so that a container couldn't be in m
Update the LOCKING comment.
Take mem_lock in want_daemonize.
convert lxcapi_destroy to not use privlock/slock by hand.
Fix a coverity-found potential dereference of NULL c->lxc_conf.
api_cgroup_get_item() and api_cgroup_set_item(): use disklock,
not memlock, since the values are set through the
