Re: [lxc-devel] [PATCH] fix getline(3) memory leaks

2013-05-21 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Tue, 21 May 2013 17:07:54 -0500 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > Signed-off-by: Dwight Engen > > > --- > > > src/lxc/attach.c | 2 +- > > > src/lxc/cgroup.c | 1 + > > > 2 files changed, 2 inse

Re: [lxc-devel] [PATCH] fix getline(3) memory leaks

2013-05-21 Thread Dwight Engen
On Tue, 21 May 2013 17:07:54 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > Signed-off-by: Dwight Engen > > --- > > src/lxc/attach.c | 2 +- > > src/lxc/cgroup.c | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/src/lxc/attach.c b/

Re: [lxc-devel] [PATCH] fix getline(3) memory leaks

2013-05-21 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > Signed-off-by: Dwight Engen > --- > src/lxc/attach.c | 2 +- > src/lxc/cgroup.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/lxc/attach.c b/src/lxc/attach.c > index a7e9074..d8b4915 100644 > --- a/src/lxc/attach.c

Re: [lxc-devel] [PATCH] oracle template: mount /dev/shm as tmpfs

2013-05-21 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > sem_open(3) checks that /dev/shm is SHMFS_SUPER_MAGIC. Normally /dev/shm > is mounted in the initramfs created by dracut, but that won't be run for > a container so make sure that rc.sysinit mounts /dev/shm. > > Signed-off-by: Dwight Engen Acked-

Re: [lxc-devel] [PATCH] lxc-fedora template. Cleanup for rootfs.

2013-05-21 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > This is just some minor changes in the way the Fedora template is > synthesizing the target rootfs_path. Currently, the template uses a > path with the container in it twice like this: > > /var/lib/lxc/rasputin/rasputin/rootfs > > This happens b

Re: [lxc-devel] [PATCH] fix build with --enable-tests

2013-05-21 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > Signed-off-by: Dwight Engen d'oh. thanks. Acked-by: Serge E. Hallyn > --- > src/lxc/lxccontainer.h | 1 + > src/tests/cgpath.c | 3 ++- > src/tests/clonetest.c | 10 +- > 3 files changed, 8 insertions(+), 6 deletions(-) > > di

[lxc-devel] [PATCH] fix getline(3) memory leaks

2013-05-21 Thread Dwight Engen
Signed-off-by: Dwight Engen --- src/lxc/attach.c | 2 +- src/lxc/cgroup.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lxc/attach.c b/src/lxc/attach.c index a7e9074..d8b4915 100644 --- a/src/lxc/attach.c +++ b/src/lxc/attach.c @@ -114,6 +114,7 @@ struct lxc_proc_contex

[lxc-devel] [RFC] [PATCH] lxc-fedora template - Add --fqdn option for utsname.

2013-05-21 Thread Michael H. Warfield
All, After comments from Serge, attached is a suggested patch to the Fedora template to incorporate the FQDN (Fully Qualified Domain Name) of the container as the utsname in the container configuration and in the host name of the system. It adds a "--fqdn" long option to explicitly specify the va

[lxc-devel] [PATCH] lxc-fedora template. Cleanup for rootfs.

2013-05-21 Thread Michael H. Warfield
This is just some minor changes in the way the Fedora template is synthesizing the target rootfs_path. Currently, the template uses a path with the container in it twice like this: /var/lib/lxc/rasputin/rasputin/rootfs This happens because the container name is already contained in the "path" an

[lxc-devel] [PATCH] fix build with --enable-tests

2013-05-21 Thread Dwight Engen
Signed-off-by: Dwight Engen --- src/lxc/lxccontainer.h | 1 + src/tests/cgpath.c | 3 ++- src/tests/clonetest.c | 10 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/lxc/lxccontainer.h b/src/lxc/lxccontainer.h index bf3168c..22ccb0b 100644 --- a/src/lxc/lxccon

Re: [lxc-devel] [PATCH] fix minor gcc 4.7.2 error

2013-05-21 Thread Stéphane Graber
On 05/21/2013 01:15 PM, Dwight Engen wrote: > lxccontainer.c:874:4: error: ‘for’ loop initial declarations are only > allowed in C99 mode > > Signed-off-by: Dwight Engen Oops, forgot to test-build with that last minute change... Acked-by: Stéphane Graber > --- > src/lxc/lxccontainer.c | 3 ++

[lxc-devel] [PATCH] fix minor gcc 4.7.2 error

2013-05-21 Thread Dwight Engen
lxccontainer.c:874:4: error: ‘for’ loop initial declarations are only allowed in C99 mode Signed-off-by: Dwight Engen --- src/lxc/lxccontainer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index 7ce25c6..2934afa 100644 ---

[lxc-devel] [PATCH] oracle template: mount /dev/shm as tmpfs

2013-05-21 Thread Dwight Engen
sem_open(3) checks that /dev/shm is SHMFS_SUPER_MAGIC. Normally /dev/shm is mounted in the initramfs created by dracut, but that won't be run for a container so make sure that rc.sysinit mounts /dev/shm. Signed-off-by: Dwight Engen --- templates/lxc-oracle.in | 11 +++ 1 file changed, 11

Re: [lxc-devel] [PATCH] extend command processor to handle generic data

2013-05-21 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Tue, 21 May 2013 08:18:01 -0500 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > Motivation for this change is to have the ability to get the > > > run-time configuration items from a container, which may differ

Re: [lxc-devel] [PATCH V2] lxcapi: Add new get_ips() call

2013-05-21 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > This adds a new get_ips call which takes a family (inet, inet6 or NULL), > a network interface (or NULL for all) and a scope (0 for global) and returns > a char** of all the IPs in the container. > > This also adds a matching python3 binding (functi

Re: [lxc-devel] [PATCH] extend command processor to handle generic data

2013-05-21 Thread Dwight Engen
On Tue, 21 May 2013 08:18:01 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > Motivation for this change is to have the ability to get the > > run-time configuration items from a container, which may differ > > from its current on disk configuration, or might not be

[lxc-devel] [PATCH V2] lxcapi: Add new get_ips() call

2013-05-21 Thread Stéphane Graber
This adds a new get_ips call which takes a family (inet, inet6 or NULL), a network interface (or NULL for all) and a scope (0 for global) and returns a char** of all the IPs in the container. This also adds a matching python3 binding (function result is a tuple) and deprecates the previous pure-py

Re: [lxc-devel] Question about a "real" LXC library

2013-05-21 Thread Serge Hallyn
Quoting Jon Taylor (dosad...@gmail.com): > Hi, > > I was initially working with libvirt, but all I was doing was calling out > to lxc so I decided to ditch libvirt and work directly with LXC since the > current libvirt is a bit buggy for me. To that end, I have been playing > with and studying LX

Re: [lxc-devel] [PATCH] extend command processor to handle generic data

2013-05-21 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > Motivation for this change is to have the ability to get the run-time > configuration items from a container, which may differ from its current > on disk configuration, or might not be available any other way (for > example lxc.network.0.veth.pair).