[lxc-devel] [PATCH] lxc-ps: handle cgroup collisions

A few months ago cgroup handling in lxc was updated so that if /sys/fs/cgroup/$cgroup/lxc/$container already exists (most often due to another container by the same name under a different lxcpath), then /sys/fs/cgroup/$cgroup/lxc/${container}-N would be used. lxc-ps was never updated to handle thi

Re: [lxc-devel] [PATCH v2] lxc-monitor multiple paths

Quoting Dwight Engen (dwight.en...@oracle.com): > Signed-off-by: Dwight Engen Acked-by: Serge E. Hallyn > --- > doc/lxc-monitor.sgml.in | 7 ++ > src/lxc/arguments.c | 34 +++-- > src/lxc/arguments.h | 5 - > src/lxc/lxc.h| 31 ++

[lxc-devel] [PATCH v2] lxc-monitor multiple paths

Signed-off-by: Dwight Engen --- doc/lxc-monitor.sgml.in | 7 ++ src/lxc/arguments.c | 34 +++-- src/lxc/arguments.h | 5 - src/lxc/lxc.h| 31 +- src/lxc/lxc_attach.c | 8 +++ src/lxc/lxc_cgroup.c | 6 ++

Re: [lxc-devel] [PATCH] lxc-monitor multiple paths

On Fri, 26 Apr 2013 09:31:08 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > >From c4af03c0e6b74e550161e4c8382fb9d0889e4fe3 Mon Sep 17 00:00:00 > > >2001 > > From: Dwight Engen > > Date: Thu, 25 Apr 2013 11:45:26 -0400 > > Subject: [PATCH] lxc-monitor multiple pat

Re: [lxc-devel] [PATCH 1/6] coverity: free malloc'ed memory in error case

Thanks, Dwight. Acked-by: Serge E. Hallyn to the whole set. Quoting Dwight Engen (dwight.en...@oracle.com): > Signed-off-by: Dwight Engen > --- > src/lxc/bdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c > index 35351a9..1a611f9 100644 > --- a/

[lxc-devel] [PATCH 5/6] coverity: check return from waitpid

Signed-off-by: Dwight Engen --- src/lxc/monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lxc/monitor.c b/src/lxc/monitor.c index 0521e9a..5648b86 100644 --- a/src/lxc/monitor.c +++ b/src/lxc/monitor.c @@ -207,7 +207,8 @@ int lxc_monitord_spawn(const char *lxcpat

[lxc-devel] [PATCH 6/6] coverity: fix potential dereference NULL returned from malloc

Signed-off-by: Dwight Engen --- src/lxc/network.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/lxc/network.c b/src/lxc/network.c index 93fc169..d1ccc0d 100644 --- a/src/lxc/network.c +++ b/src/lxc/network.c @@ -783,8 +783,11 @@ static int ifa_get_local_ip(int family

[lxc-devel] [PATCH 3/6] coverity: condition already checked for

Signed-off-by: Dwight Engen --- src/lxc/bdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c index 181e98e..fcde16b 100644 --- a/src/lxc/bdev.c +++ b/src/lxc/bdev.c @@ -1151,8 +1151,7 @@ static int overlayfs_clonepaths(struct bdev *orig, str

[lxc-devel] [PATCH 4/6] coverity: clonetest: check correct container is cloned

Signed-off-by: Dwight Engen --- src/tests/clonetest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/clonetest.c b/src/tests/clonetest.c index fcb5ea6..5644405 100644 --- a/src/tests/clonetest.c +++ b/src/tests/clonetest.c @@ -70,7 +70,7 @@ int main(int argc, char *

[lxc-devel] [PATCH 2/6] coverity: open can return 0 as an fd, change error check to < 0

Signed-off-by: Dwight Engen --- src/lxc/bdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c index 1a611f9..181e98e 100644 --- a/src/lxc/bdev.c +++ b/src/lxc/bdev.c @@ -90,7 +90,7 @@ static int blk_getsize(const char *path, unsigned long *size

[lxc-devel] [PATCH 1/6] coverity: free malloc'ed memory in error case

Signed-off-by: Dwight Engen --- src/lxc/bdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c index 35351a9..1a611f9 100644 --- a/src/lxc/bdev.c +++ b/src/lxc/bdev.c @@ -1203,6 +1203,8 @@ static int overlayfs_clonepaths(struct bdev *orig, struct bdev *new,

Re: [lxc-devel] lxc_monitord - monitor exiting

Quoting Dwight Engen (dwight.en...@oracle.com): > On Mon, 6 May 2013 19:08:08 -0500 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > On Mon, 6 May 2013 15:31:14 -0500 > > > Serge Hallyn wrote: > > > > > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > >

Re: [lxc-devel] lxc_monitord - monitor exiting

On Mon, 6 May 2013 19:08:08 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > On Mon, 6 May 2013 15:31:14 -0500 > > Serge Hallyn wrote: > > > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > > On Mon, 6 May 2013 13:06:43 -0400 > > > > Dwight Engen wrote: