Re: [lxc-devel] [PATCH] introduce lxc_config

2013-04-29 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > > +struct lxc_config_items items[] = > > +{ > > + { .name = "default_path", .fn = > > Should this be "lxcpath" instead of "default_path" so it matches the > field in the file? (or change default_lxc_path() to "default_path" but > that would break

Re: [lxc-devel] [PATCH] introduce lxc_config

2013-04-29 Thread Dwight Engen
On Mon, 29 Apr 2013 16:30:00 -0500 Serge Hallyn wrote: > Quoting Serge Hallyn (serge.hal...@ubuntu.com): > > Quoting Serge Hallyn (serge.hal...@ubuntu.com): > > > add vg and zfsroot options to lxc.functions and use in lxc-create > > > > > > also make sure to drop spaces between = and variable in

[lxc-devel] [PATCH] introduce lxc_config

2013-04-29 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@ubuntu.com): > Quoting Serge Hallyn (serge.hal...@ubuntu.com): > > add vg and zfsroot options to lxc.functions and use in lxc-create > > > > also make sure to drop spaces between = and variable in lxc.conf > > Hm, a hunk is missing from this patch. Ignore this

Re: [lxc-devel] [PATCH] fix building docs

2013-04-29 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > Commit 69fe23ff added checking for the older docbook2man back into > configure, but this breaks building the docs on at least Oracle Linux and > Fedora when docbook2X is not installed as docbook2man will be found but the > docs don't actually build

[lxc-devel] [PATCH] fix building docs

2013-04-29 Thread Dwight Engen
Commit 69fe23ff added checking for the older docbook2man back into configure, but this breaks building the docs on at least Oracle Linux and Fedora when docbook2X is not installed as docbook2man will be found but the docs don't actually build with that tool. This change makes it so the docs can be

Re: [lxc-devel] [PATCH] use vg and zfsroot defaults in lxc-create, and ignore spaces

2013-04-29 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@ubuntu.com): > add vg and zfsroot options to lxc.functions and use in lxc-create > > also make sure to drop spaces between = and variable in lxc.conf Hm, a hunk is missing from this patch. Ignore this one for now, I'm getting rid of the duplication of reading g

Re: [lxc-devel] [PATCH v2] Create log file in lxcpath for non-system containers

2013-04-29 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > So I did this, only to realize that lxc-init is passing "none" for the > file anyway, so it currently doesn't intend to log. This makes me > think that passing NULL for lxcpath is the right thing to do in > this patch. If you want me to make it so l

Re: [lxc-devel] [PATCH v2] Create log file in lxcpath for non-system containers

2013-04-29 Thread Dwight Engen
On Fri, 26 Apr 2013 10:18:12 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > On Fri, 26 Apr 2013 09:37:49 -0500 > > Serge Hallyn wrote: > > > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > > Using lxc configured with --enable-configpath-log, and > > >

Re: [lxc-devel] RFC: Refactoring lxc-attach

2013-04-29 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi there, > > any comments on my proposal? > > > The basic idea for the refactored attach API would be: > > > > - pid_t lxc_attach(const char* name, const char* lxcpath, > > options...) > > + create a socket pair for sync > > + f

[lxc-devel] [PATCH] use vg and zfsroot defaults in lxc-create, and ignore spaces

2013-04-29 Thread Serge Hallyn
add vg and zfsroot options to lxc.functions and use in lxc-create also make sure to drop spaces between = and variable in lxc.conf Signed-off-by: Serge Hallyn --- src/lxc/lxc-create.in|3 ++- src/lxc/lxc.functions.in | 20 2 files changed, 22 insertions(+), 1 dele

Re: [lxc-devel] lxc-start from git hangs in init

2013-04-29 Thread Serge Hallyn
Quoting Kevin Wilson (wkev...@gmail.com): > Hello, > This is the output (o1); I ran on > Ubuntu 12.10 (GNU/Linux 3.5.0-17-generic x86_64) > > lxc-start -n CN -l info -o o1 -f /etc/lxc/lxc.conf /sbin/init > > > And /etc/lxc/lxc.conf is in fact commented out: > more /etc/lxc/lxc.conf > #lxc.net