Re: [lxc-devel] [PATCH 2/2] Support stopping containers concurrently

2013-04-22 Thread S . Çağlar Onur
Hey Stéphane, On Wed, Apr 17, 2013 at 6:06 PM, Serge Hallyn wrote: > Quoting S.Çağlar Onur (cag...@10ur.org): > > From: "S.Çağlar Onur" > > > > Trying to stop multiple containers concurrently ends up with "cgroup is > not mounted" errors as multiple threads corrupts the shared variables. > > Fix

Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-04-22 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > I'm not a big user of lxc-clone (yet) but I think as we redesign that > part of the code, consistency across backend should be a primary goal > even if that causes some slight changes in behaviour from previous > implementations. Ok it finally dawne

Re: [lxc-devel] [RFC PATCH v2] allow multiple monitor clients

2013-04-22 Thread Dwight Engen
[...] > > > So here is what I'm proposing: when lxc-monitor starts, it > > > attempts to start lxc-monitord. lxc-monitord creates a fifo and a > > > socket on lxcpath. > > > > Thanks, Dwight. Looks awesome. Some comments below, but I'm only > > not adding an ack bc you say you want to make some

Re: [lxc-devel] [PATCH] goto correct cleanup label to ensure fd is closed

2013-04-22 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > Signed-off-by: Dwight Engen Acked-by: Serge E. Hallyn > --- > src/lxc/start.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/lxc/start.c b/src/lxc/start.c > index aefccd6..0a0cc40 100644 > --- a/src/lxc/start.

[lxc-devel] [PATCH] goto correct cleanup label to ensure fd is closed

2013-04-22 Thread Dwight Engen
Signed-off-by: Dwight Engen --- src/lxc/start.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/start.c b/src/lxc/start.c index aefccd6..0a0cc40 100644 --- a/src/lxc/start.c +++ b/src/lxc/start.c @@ -434,10 +434,10 @@ struct lxc_handler *lxc_init(const char *name,

Re: [lxc-devel] lxc-start from git hangs in init

2013-04-22 Thread Serge Hallyn
Quoting Kevin Wilson (wkev...@gmail.com): > Hello, > I just want to add, following a different thread I read here, that: > > lxc-execute -n CN -f /etc/lxc/lxc.conf -- ps -ef > seems ok, it gives: > UIDPID PPID C STIME TTY TIME CMD > root 1 0 0 05:39 pts/100:00:0

Re: [lxc-devel] make lxc_af_unix_open() safely return error on long pathnames

2013-04-22 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > Signed-off-by: Dwight Engen Thanks. Acked-by: Serge E. Hallyn > --- > src/lxc/af_unix.c | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/src/lxc/af_unix.c b/src/lxc/af_unix.c > index eff13d4..45fe128

Re: [lxc-devel] namespaces and lxc

2013-04-22 Thread Serge Hallyn
Quoting Andy Johnson (johnson...@gmail.com): > Hello, > I read your posts, thanks a lot for the good and detailed info and examples. > > >When a new user namespace is created, the task populating it starts >as > userid -1, nobody. > > I don't understand something: why nobody is userid -1 ? > On f

[lxc-devel] make lxc_af_unix_open() safely return error on long pathnames

2013-04-22 Thread Dwight Engen
Signed-off-by: Dwight Engen --- src/lxc/af_unix.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/lxc/af_unix.c b/src/lxc/af_unix.c index eff13d4..45fe128 100644 --- a/src/lxc/af_unix.c +++ b/src/lxc/af_unix.c @@ -36,6 +36,7 @@ lxc_log_define(lxc_af_unix

Re: [lxc-devel] namespaces and lxc

2013-04-22 Thread Andy Johnson
Hello, I read your posts, thanks a lot for the good and detailed info and examples. >When a new user namespace is created, the task populating it starts >as userid -1, nobody. I don't understand something: why nobody is userid -1 ? On fedora 18 we have: cat /etc/passwd | grep nobody nobody:x:99: