Re: [lxc-devel] [PATCH] rcfile shouldn't get set if the attempt to load a config file fails

2013-03-27 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > Hey Serge, > > To be honest I wasn't thinking about parse errors while sending the patch. > Maybe we can handle the non-existent file issue with something like that > Yeah, that looks good. Handles the main problem. Thanks! Acked-by: Serge E. Hallyn

Re: [lxc-devel] [PATCH] rcfile shouldn't get set if the attempt to load a config file fails

2013-03-27 Thread S . Çağlar Onur
Hey Serge, To be honest I wasn't thinking about parse errors while sending the patch. Maybe we can handle the non-existent file issue with something like that diff --git a/src/lxc/confile.c b/src/lxc/confile.c index 8fe1541..96f9122 100644 --- a/src/lxc/confile.c +++ b/src/lxc/confile.c @@ -1422,

Re: [lxc-devel] [PATCH] lxc.sgml.in: Fix typo in man page.

2013-03-27 Thread Serge Hallyn
Quoting Matthias Brugger (matthias@gmail.com): > This patch fixes a small typo in the man page. > > Signed-off-by: Matthias Brugger Acked-by: Serge E. Hallyn > --- > doc/lxc.sgml.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/lxc.sgml.in b/doc/lxc.sgml.in

[lxc-devel] [PATCH] lxc.sgml.in: Fix typo in man page.

2013-03-27 Thread Matthias Brugger
This patch fixes a small typo in the man page. Signed-off-by: Matthias Brugger --- doc/lxc.sgml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/lxc.sgml.in b/doc/lxc.sgml.in index 865a6a7..a333c49 100644 --- a/doc/lxc.sgml.in +++ b/doc/lxc.sgml.in @@ -96,7 +96,7 @@ Fou

[lxc-devel] Reminder, LXC 0.9 to be released next week

2013-03-27 Thread Stéphane Graber
Hello, I think staging is currently in pretty good shape. We got a good selection of last minute fixes to various bits but everything seems very stable and I think we'll be good to release 0.9 on schedule. So this is a last reminder that I'll be sending the last pull request for the 0.9 release

Re: [lxc-devel] [PATCH] lxc-clone: support 'permanent ephemeral' containers

2013-03-27 Thread Stéphane Graber
On 03/27/2013 10:01 AM, Serge Hallyn wrote: > All of this needs a rewrite/redesign, and that will be coming (details > below), but for now > > You can start 'non-ephemeral ephemeral' containers using > > lxc-start-ephemeral -o oldname -n newname --keep-data > > When you shut that down, the

Re: [lxc-devel] [PATCH] rcfile shouldn't get set if the attempt to load a config file fails

2013-03-27 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > From: "S.Çağlar Onur" > > Signed-off-by: S.Çağlar Onur The only downside I see is that now the callbacks can be called with conf->rcfile NULL when it otherwise might be set to strdup(file). This gets tricky because the file being read could have a #

[lxc-devel] [PATCH] rcfile shouldn't get set if the attempt to load a config file fails

2013-03-27 Thread S . Çağlar Onur
From: "S.Çağlar Onur" Signed-off-by: S.Çağlar Onur --- src/lxc/confile.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lxc/confile.c b/src/lxc/confile.c index 8fe1541..16b8594 100644 --- a/src/lxc/confile.c +++ b/src/lxc/confile.c @@ -1422,11 +1422,13 @@ int

Re: [lxc-devel] [PATCH] EXTRA_DIST: Fix missing files with "make dist"

2013-03-27 Thread Stéphane Graber
On 03/27/2013 11:28 AM, Dwight Engen wrote: > On Tue, 26 Mar 2013 13:09:20 -0400 > Stéphane Graber wrote: > >> On 03/26/2013 01:03 PM, Stéphane Graber wrote: >>> I recently noticed that the generated tarballs with "make dist" >>> were incomplete unless the configure script was run on a machine >>

Re: [lxc-devel] [PATCH] EXTRA_DIST: Fix missing files with "make dist"

2013-03-27 Thread Dwight Engen
On Tue, 26 Mar 2013 13:09:20 -0400 Stéphane Graber wrote: > On 03/26/2013 01:03 PM, Stéphane Graber wrote: > > I recently noticed that the generated tarballs with "make dist" > > were incomplete unless the configure script was run on a machine > > with all possible build dependencies. > > > > Th

[lxc-devel] [PATCH] lxc-clone: support 'permanent ephemeral' containers

2013-03-27 Thread Serge Hallyn
All of this needs a rewrite/redesign, and that will be coming (details below), but for now You can start 'non-ephemeral ephemeral' containers using lxc-start-ephemeral -o oldname -n newname --keep-data When you shut that down, the container stick around and can be restarted. Now lxc-clo

Re: [lxc-devel] [PATCH] lxc-start-ephemeral: Implement -n to match manpage

2013-03-27 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > The -n/--name option of lxc-start-ephemeral was never implemented > even though it was documented in the manpage. > > Signed-off-by: Stéphane Graber Awesome, thanks. Acked-by: Serge E. Hallyn > --- > src/lxc/lxc-start-ephemeral.in | 11 +++

[lxc-devel] [PATCH] lxc-start-ephemeral: Implement -n to match manpage

2013-03-27 Thread Stéphane Graber
The -n/--name option of lxc-start-ephemeral was never implemented even though it was documented in the manpage. Signed-off-by: Stéphane Graber --- src/lxc/lxc-start-ephemeral.in | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxc-start-ephemeral.in b/src/l

Re: [lxc-devel] [PATCH] Set all mounts to MS_SLAVE when starting a container without a rootfs

2013-03-27 Thread Serge Hallyn
Quoting David Ward (david.w...@ll.mit.edu): > If the filesystem mounts on the host have the MS_SHARED or MS_SLAVE > flag set, and a container without a rootfs is started, then any new > mounts created inside the container are currently propagated into > the host. In addition to mounts placed in the