Re: [lxc-devel] Dynamic devices

2013-03-18 Thread Eric W. Biederman
Serge Hallyn writes: >> But getting back to the question of policy, does it make sense that the >> way policy is implemented > > Policy is not implemented. > >> is that the all containers receive the events, >> and container configuration determines what uevents should/can be >> processed by t

Re: [lxc-devel] [PATCH 2/2] Properly handle timeout case in lxc-shutdown

2013-03-18 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Signed-off-by: Christian Seiler Acked-by: Serge E. Hallyn > --- > src/lxc/lxc-shutdown.in |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/lxc/lxc-shutdown.in b/src/lxc/lxc-shutdown.in > index fdcade2..d82cebf 100644 > --- a/sr

Re: [lxc-devel] [PATCH 1/2] Properly cleanup network devices if pinning root filesystem didn't work

2013-03-18 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Signed-off-by: Christian Seiler Acked-by: Serge E. Hallyn > --- > src/lxc/start.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lxc/start.c b/src/lxc/start.c > index 3fdfa04..7a982ce 100644 > --- a/src/lxc/star

Re: [lxc-devel] [PATCH 0/2] Some small fixes post 0.9rc1 for 0.9final

2013-03-18 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi there, > > I found two little bugs in lxc-start and lxc-shutdown and provided some > trivial patches that should go in after rc1. > > lxc-start: If pinning the rootfs doesn't work (for example, if the > rootfs doesn't exist and readlink() that i

Re: [lxc-devel] [PATCH 0/2] Some small fixes post 0.9rc1 for 0.9final

2013-03-18 Thread Christian Seiler
Hi again, I completely forgot to mention, you can find the patches at my github under: https://github.com/chris-se/lxc/tree/post-0.9rc1-bugfixes-1 -- Christian -- Everyone hates slow websites. So do we. Make your web ap

[lxc-devel] [PATCH 0/2] Some small fixes post 0.9rc1 for 0.9final

2013-03-18 Thread Christian Seiler
Hi there, I found two little bugs in lxc-start and lxc-shutdown and provided some trivial patches that should go in after rc1. lxc-start: If pinning the rootfs doesn't work (for example, if the rootfs doesn't exist and readlink() that is used to get the parent directory fails) it will not remove

[lxc-devel] [PATCH 1/2] Properly cleanup network devices if pinning root filesystem didn't work

2013-03-18 Thread Christian Seiler
Signed-off-by: Christian Seiler --- src/lxc/start.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/start.c b/src/lxc/start.c index 3fdfa04..7a982ce 100644 --- a/src/lxc/start.c +++ b/src/lxc/start.c @@ -785,7 +785,7 @@ int lxc_spawn(struct lxc_handler *handler)

[lxc-devel] [PATCH 2/2] Properly handle timeout case in lxc-shutdown

2013-03-18 Thread Christian Seiler
Signed-off-by: Christian Seiler --- src/lxc/lxc-shutdown.in |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lxc/lxc-shutdown.in b/src/lxc/lxc-shutdown.in index fdcade2..d82cebf 100644 --- a/src/lxc/lxc-shutdown.in +++ b/src/lxc/lxc-shutdown.in @@ -28,6 +28,7 @@ usage() { } alarm(

Re: [lxc-devel] [PATCH] Use $localstatedir/log/lxc for default log path

2013-03-18 Thread Ryota Ozaki
On Tue, Mar 19, 2013 at 2:38 AM, Stéphane Graber wrote: > On 13-03-18 01:08 PM, Ryota Ozaki wrote: >> Hi Serge, >> >> On Tue, Mar 19, 2013 at 1:25 AM, Serge Hallyn >> wrote: >>> Quoting Ryota Ozaki (ozaki.ry...@gmail.com): Hi Serge, Oh I didn't intend to change the log path for distro

Re: [lxc-devel] [PATCH] Use $localstatedir/log/lxc for default log path

2013-03-18 Thread Stéphane Graber
On 13-03-18 01:08 PM, Ryota Ozaki wrote: > Hi Serge, > > On Tue, Mar 19, 2013 at 1:25 AM, Serge Hallyn wrote: >> Quoting Ryota Ozaki (ozaki.ry...@gmail.com): >>> Hi Serge, >>> Oh I didn't intend to change the log path for distro packages. >>> Actually when we do "make rpm", the log path will be /

Re: [lxc-devel] [PATCH 2/2] Fix for ia64: Use __clone2 for ia64 in lxc/start.c

2013-03-18 Thread Serge Hallyn
Quoting Dennis Schridde (devuran...@gmx.net): > Am Montag, 18. März 2013, 11:28:02 schrieb Serge Hallyn: > > #ifdef __ia64__ > > stack += stack_size > > #endif > > > > so that the clone call below stays just the slightest bit easier on > > the eyes. > src/lxc/namespace.c does it the same way.

Re: [lxc-devel] [PATCH] Use $localstatedir/log/lxc for default log path

2013-03-18 Thread Ryota Ozaki
Hi Serge, On Tue, Mar 19, 2013 at 1:25 AM, Serge Hallyn wrote: > Quoting Ryota Ozaki (ozaki.ry...@gmail.com): >> Hi Serge, >> Oh I didn't intend to change the log path for distro packages. >> Actually when we do "make rpm", the log path will be /var/log/lxc >> since $localstatedir is set to /var.

[lxc-devel] [PATCH 1/2] Build fix for ia64: Declare __clone2 in lxc/namespace.h

2013-03-18 Thread Dennis Schridde
--- src/lxc/namespace.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/lxc/namespace.h b/src/lxc/namespace.h index e35de60..1c33b55 100644 --- a/src/lxc/namespace.h +++ b/src/lxc/namespace.h @@ -49,7 +49,11 @@ #ifndef CLONE_NEWNET # define CLONE_NEWNET0

[lxc-devel] [PATCH 2/2] Fix for ia64: Use __clone2 for ia64 in lxc/start.c

2013-03-18 Thread Dennis Schridde
--- src/lxc/start.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/lxc/start.c b/src/lxc/start.c index 3fdfa04..a95708a 100644 --- a/src/lxc/start.c +++ b/src/lxc/start.c @@ -564,7 +564,7 @@ static int must_drop_cap_sys_boot(void) FILE *f = fopen("/proc/sys/k

Re: [lxc-devel] [PATCH 2/2] Fix for ia64: Use __clone2 for ia64 in lxc/start.c

2013-03-18 Thread Dennis Schridde
Am Montag, 18. März 2013, 11:28:02 schrieb Serge Hallyn: > #ifdef __ia64__ > stack += stack_size > #endif > > so that the clone call below stays just the slightest bit easier on > the eyes. src/lxc/namespace.c does it the same way. Maybe you want to change that, too. --Dennis signature.asc

Re: [lxc-devel] [PATCH 2/2] Fix for ia64: Use __clone2 for ia64 in lxc/start.c

2013-03-18 Thread Serge Hallyn
Quoting Dennis Schridde (devuran...@gmx.net): > --- > src/lxc/start.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/src/lxc/start.c b/src/lxc/start.c > index 3fdfa04..106c8e8 100644 > --- a/src/lxc/start.c > +++ b/src/lxc/start.c > @@ -135,6 +135,11 @@ in

Re: [lxc-devel] [PATCH] Use $localstatedir/log/lxc for default log path

2013-03-18 Thread Serge Hallyn
Quoting Ryota Ozaki (ozaki.ry...@gmail.com): > Hi Serge, > Oh I didn't intend to change the log path for distro packages. > Actually when we do "make rpm", the log path will be /var/log/lxc > since $localstatedir is set to /var. Oh I see, good point. I guess it's fine :) Ack from me, but note th

Re: [lxc-devel] [PATCH 1/2] Build fix for ia64: Declare __clone2 in lxc/namespace.c

2013-03-18 Thread Dennis Schridde
Hello everyone! These patches shall fix ia64 support. I use LXC (with these two patches) on a Vanilla 3.8.3 kernel on one of my ia64 machines since a while - and starting from Linux 3.8, it became a quite usable replacement for OpenVZ, with lxc- attach beginning to work. __clone2 has to be decl

[lxc-devel] [PATCH 2/2] Fix for ia64: Use __clone2 for ia64 in lxc/start.c

2013-03-18 Thread Dennis Schridde
--- src/lxc/start.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/lxc/start.c b/src/lxc/start.c index 3fdfa04..106c8e8 100644 --- a/src/lxc/start.c +++ b/src/lxc/start.c @@ -135,6 +135,11 @@ int signalfd(int fd, const sigset_t *mask, int flags) #include "l

[lxc-devel] [PATCH 1/2] Build fix for ia64: Declare __clone2 in lxc/namespace.c

2013-03-18 Thread Dennis Schridde
--- src/lxc/namespace.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/lxc/namespace.c b/src/lxc/namespace.c index d10efdc..9f20608 100644 --- a/src/lxc/namespace.c +++ b/src/lxc/namespace.c @@ -33,6 +33,11 @@ #include "namespace.h" #include "log.h" +#ifdef __ia64__ +extern int _

Re: [lxc-devel] [PATCH] Use $localstatedir/log/lxc for default log path

2013-03-18 Thread Ryota Ozaki
Hi Serge, On Mon, Mar 18, 2013 at 10:59 PM, Serge Hallyn wrote: > Quoting Ryota Ozaki (ozaki.ry...@gmail.com): >> When we install lxc by manual (configure; make; make install), >> all files are installed under /usr/local/. Configuration files >> and setting files of containers are stored under /u

Re: [lxc-devel] [PATCH] Use $localstatedir/log/lxc for default log path

2013-03-18 Thread Serge Hallyn
Quoting Ryota Ozaki (ozaki.ry...@gmail.com): > When we install lxc by manual (configure; make; make install), > all files are installed under /usr/local/. Configuration files > and setting files of containers are stored under /usr/local/ too, > however, only log files are stored under /var/log/ not