Quoting Stéphane Graber (stgra...@ubuntu.com):
> We've been shipping those two hooks for a while in Ubuntu.
> Yesterday I reworked them to use the new environment variables and
> avoid hardcoding any path that we have available as a variable.
>
> I tested both to work on Ubuntu 13.04 but they shou
On 02/19/2013 03:39 PM, Serge Hallyn wrote:
> Ok, took a look, what happened was the clearenv calls used to be
> in lxc_start and lxccontainer and lxc_execute (do lxc_start() callers)
> themselves. I moved those into do_start(), but the calls in
> lxccontainer.c were never removed.
>
> They shoul
We've been shipping those two hooks for a while in Ubuntu.
Yesterday I reworked them to use the new environment variables and
avoid hardcoding any path that we have available as a variable.
I tested both to work on Ubuntu 13.04 but they should work just as well
on any distro shipping with the cgro
Ok, took a look, what happened was the clearenv calls used to be
in lxc_start and lxccontainer and lxc_execute (do lxc_start() callers)
themselves. I moved those into do_start(), but the calls in
lxccontainer.c were never removed.
They should simply be removed altogether. Trivial patch follows.
Quoting Stéphane Graber (stgra...@ubuntu.com):
> On 02/19/2013 03:06 PM, Serge Hallyn wrote:
> > Quoting Stéphane Graber (stgra...@ubuntu.com):
> >> On 02/14/2013 11:30 AM, Serge Hallyn wrote:
> >>> This is needed for lxc_wait and lxc_monitor to handle lxcpath. However,
> >>> the full path name is
Hi Van,
I'm not one of the devs, so I could be wrong about the right way to jump in,
but I suggest forking https://github.com/lxc/lxc and getting it to build
locally as a first step. One of the regular devs can better comment on the
correct format for sending PATCH emails to this list.
Brent
On 02/19/2013 03:06 PM, Serge Hallyn wrote:
> Quoting Stéphane Graber (stgra...@ubuntu.com):
>> On 02/14/2013 11:30 AM, Serge Hallyn wrote:
>>> This is needed for lxc_wait and lxc_monitor to handle lxcpath. However,
>>> the full path name is limited to 108 bytes. Should we use a md5sum of
>>> the
Quoting Stéphane Graber (stgra...@ubuntu.com):
> On 02/14/2013 11:30 AM, Serge Hallyn wrote:
> > This is needed for lxc_wait and lxc_monitor to handle lxcpath. However,
> > the full path name is limited to 108 bytes. Should we use a md5sum of
> > the lxcpath instead of the path itself?
>
>
> I
Quoting Jiri Slaby (jsl...@suse.cz):
> Fail if something goes wrong. We used to continue and show one failure
> after another.
> ---
Acked-by: Serge E. Hallyn
> templates/lxc-opensuse.in | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/templates/lxc-opens
Quoting Jiri Slaby (jsl...@suse.cz):
> Base no longer provides bash, sed and tar, but we need those. So add them.
> ---
> templates/lxc-opensuse.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Serge E. Hallyn
>
> diff --git a/templates/lxc-opensuse.in b/templates/lxc-opens
Quoting Jiri Slaby (jsl...@suse.cz):
> From: Frederic Crozat
>
> This adaptation of systemd. We also add network configuration support.
Is there any point in worrying about support for older versions?
(If not, that's fine)
> Jiri Slaby: cleanups, rebase
> ---
> templates/lxc-opensuse.in | 121
Quoting Jiri Slaby (jsl...@suse.cz):
> From: Frederic Crozat
>
> When cgroup can't be moved, it might be a hint container is already
> running.
This becomes obsolete with the patch I sent last week. (Mind you, it
reminds us that we need to make sure the monitor test for this
condition is workin
Quoting Jiri Slaby (jsl...@suse.cz):
> Otherwise the output looks like:
> Copying rootfs to /var/lib/lxc/tomcat/rootfs ...Please change
> root-password !
> ---
> templates/lxc-opensuse.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/templates/lxc-opensuse.in b/template
On 02/14/2013 11:30 AM, Serge Hallyn wrote:
> This is needed for lxc_wait and lxc_monitor to handle lxcpath. However,
> the full path name is limited to 108 bytes. Should we use a md5sum of
> the lxcpath instead of the path itself?
I thought of instead using the cgroup name (including group and
Quoting Jiri Slaby (jsl...@suse.cz):
> From: Frederic Crozat
>
> - mount /run on tmpfs outside container
> - replace /var/run bind mount on /run by a symlink
> ---
Formality, but could you please sign off your patches?
Acked-by: Serge E. Hallyn
> templates/lxc-opensuse.in | 5 +
> 1 file
Quoting Jiri Slaby (jsl...@suse.cz):
> From: Frederic Crozat
>
> - create /etc/hostname as symlink to /etc/HOSTNAME
> - fix inadequate space in lxc.mount config, preventing lxc-clone to work
>
> Jiri Slaby: some cleanups
Acked-by: Serge E. Hallyn
> ---
> templates/lxc-opensuse.in | 9 +++
Quoting Stéphane Graber (stgra...@ubuntu.com):
> This commit tweaks the layout of the config file for the Ubuntu templates.
>
> With this, we now get a clear network config group, then a path related group,
> then a bunch of random config options and the end of the config is apparmor,
> capabiliti
Quoting Stéphane Graber (stgra...@ubuntu.com):
> Use AC_SEARCH_LIBS to detect what library provides sem_*.
> This allows us to stop hardcoding the ld arguments in the various MakeFiles.
>
> Suggested-by: Natanael Copa
> Signed-off-by: Stéphane Graber
Acked-by: Serge E. Hallyn
> ---
> configu
On 02/14/2013 11:05 AM, Serge Hallyn wrote:
> For the lxc-* C binaries, introduce a -P|--lxcpath command line option
> to override the system default.
>
> With this, I can
>
> lxc-create -t ubuntu -n r1
> lxc-create -t ubuntu -n r1 -P /home/ubuntu/lxcbase
> lxc-start -n r1 -d
>
Use AC_SEARCH_LIBS to detect what library provides sem_*.
This allows us to stop hardcoding the ld arguments in the various MakeFiles.
Suggested-by: Natanael Copa
Signed-off-by: Stéphane Graber
---
configure.ac | 3 +++
src/lxc/Makefile.am | 8
src/tests/Makefile.am | 4
On 02/19/2013 10:39 AM, Daniel Lezcano wrote:
> On 02/19/2013 04:28 PM, Dwight Engen wrote:
>> On Tue, 19 Feb 2013 10:02:37 -0500
>> Stéphane Graber wrote:
>>
>>> On 02/19/2013 09:19 AM, Serge Hallyn wrote:
Quoting Natanael Copa (nc...@alpinelinux.org):
> On Mon, 18 Feb 2013 21:40:42 +010
On 02/19/2013 04:28 PM, Dwight Engen wrote:
> On Tue, 19 Feb 2013 10:02:37 -0500
> Stéphane Graber wrote:
>
>> On 02/19/2013 09:19 AM, Serge Hallyn wrote:
>>> Quoting Natanael Copa (nc...@alpinelinux.org):
On Mon, 18 Feb 2013 21:40:42 +0100
Daniel Lezcano wrote:
> On 02/18/2013
On Tue, 19 Feb 2013 10:02:37 -0500
Stéphane Graber wrote:
> On 02/19/2013 09:19 AM, Serge Hallyn wrote:
> > Quoting Natanael Copa (nc...@alpinelinux.org):
> >> On Mon, 18 Feb 2013 21:40:42 +0100
> >> Daniel Lezcano wrote:
> >>
> >>> On 02/18/2013 06:23 PM, Stéphane Graber wrote:
> dpkg spot
On 02/19/2013 10:09 AM, Stéphane Graber wrote:
> On 02/19/2013 04:17 AM, Natanael Copa wrote:
>> Replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADER.
>>
>> This is needed for automake-1.13.
>>
>> Signed-off-by: Natanael Copa
>> ---
>> configure.ac | 2 +-
>> 1 file changed, 1 insertion(+),
On 02/19/2013 04:17 AM, Natanael Copa wrote:
> Replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADER.
>
> This is needed for automake-1.13.
>
> Signed-off-by: Natanael Copa
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configur
On 02/19/2013 09:19 AM, Serge Hallyn wrote:
> Quoting Natanael Copa (nc...@alpinelinux.org):
>> On Mon, 18 Feb 2013 21:40:42 +0100
>> Daniel Lezcano wrote:
>>
>>> On 02/18/2013 06:23 PM, Stéphane Graber wrote:
dpkg spotted that we're not explicitly linking against pthread even though
we
Quoting Natanael Copa (nc...@alpinelinux.org):
> On Mon, 18 Feb 2013 21:40:42 +0100
> Daniel Lezcano wrote:
>
> > On 02/18/2013 06:23 PM, Stéphane Graber wrote:
> > > dpkg spotted that we're not explicitly linking against pthread even though
> > > we use some of its symbols (sem_*).
> >
> > uh ?
Replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADER.
This is needed for automake-1.13.
Signed-off-by: Natanael Copa
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 931e0d6..c5c71e4 100644
--- a/configure.ac
+++ b/confi
On Mon, 18 Feb 2013 12:23:24 -0500
Stéphane Graber wrote:
> dpkg spotted that we're not explicitly linking against pthread even though
> we use some of its symbols (sem_*).
>
> Signed-off-by: Stéphane Graber
> ---
> src/lxc/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On Mon, 18 Feb 2013 21:40:42 +0100
Daniel Lezcano wrote:
> On 02/18/2013 06:23 PM, Stéphane Graber wrote:
> > dpkg spotted that we're not explicitly linking against pthread even though
> > we use some of its symbols (sem_*).
>
> uh ? wait.
>
> We shouldn't link against the lib pthread.
>
> I d
>Oh, forgot to add:
> - Get some kind of upstream support for container autostart.
> The actual autostart would still be done by distro's init scripts,
>but the way it's set should be standardized.
Dear Stéphane,
like a corresponding BIOS feature of most real hardware, "autostart" maybe
should
31 matches
Mail list logo
