Re: [lxc-devel] [PATCH] add lua binding for the lxc API

2013-01-22 Thread Stéphane Graber
On 01/22/2013 11:03 AM, Dwight Engen wrote: > The lua binding is based closely on the python binding. Also included are > a test program for excercising the binding, and an lxc-top utility for > showing statistics on running containers. > > Signed-off-by: Dwight Engen I was just about to ask abo

Re: [lxc-devel] [PATCH] use a default per-container logfile

2013-01-22 Thread Stéphane Graber
On 01/16/2013 05:37 PM, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > ... >> We probably should have code to actually create the path if it's >> missing, similar to what's done for /var/lib/lxc and /var/cache/lxc. > > How about the following patch on top of the original? >

Re: [lxc-devel] [PATCH] use a default per-container logfile

2013-01-22 Thread Stéphane Graber
On 01/16/2013 12:02 AM, Serge Hallyn wrote: > [ Thanks to Stéphane and Dwight for the feedback on the previous patch ] > > Until now, if a lxc-* (i.e. lxc-start) command did not specify a logfile > (with -o logfile), the default was effectively 'none'. With this patch, > the default becomes $LOGP

Re: [lxc-devel] [PATCH] lxc-setcap.in: Set path to lxc-init

2013-01-22 Thread Stéphane Graber
On 01/22/2013 03:57 PM, Serge Hallyn wrote: > Quoting Matthias Brugger (matthias@gmail.com): >> In lxc-setcap the path to lxc-init wasn't set right, so that >> a call to the script failed with an error. This patch sets >> the path to the right directory. >> >> Signed-off-by: Matthias Brugger >

Re: [lxc-devel] [PATCH v3] use which instead of type

2013-01-22 Thread Stéphane Graber
On 01/22/2013 04:07 PM, Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): >> This is for consistency with the rest of lxc, and also because type checks >> for >> shell builtins, a behavior that we do not want in these cases. Ensure stderr >> for which is redirected to /dev/null

Re: [lxc-devel] [PATCH v3] use which instead of type

2013-01-22 Thread Dwight Engen
On Tue, 22 Jan 2013 15:06:44 -0600 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > This is for consistency with the rest of lxc, and also because type > > checks for shell builtins, a behavior that we do not want in these > > cases. Ensure stderr for which is redirected

Re: [lxc-devel] [PATCH v3] use which instead of type

2013-01-22 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > This is for consistency with the rest of lxc, and also because type checks for > shell builtins, a behavior that we do not want in these cases. Ensure stderr > for which is redirected to /dev/null also. > > Signed-off-by: Dwight Engen Thanks, Dwi

Re: [lxc-devel] [PATCH v3] use which instead of type

2013-01-22 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > This is for consistency with the rest of lxc, and also because type checks for > shell builtins, a behavior that we do not want in these cases. Ensure stderr > for which is redirected to /dev/null also. > > Signed-off-by: Dwight Engen Sorry, plea

[lxc-devel] [PATCH v3] use which instead of type

2013-01-22 Thread Dwight Engen
This is for consistency with the rest of lxc, and also because type checks for shell builtins, a behavior that we do not want in these cases. Ensure stderr for which is redirected to /dev/null also. Signed-off-by: Dwight Engen --- src/lxc/lxc-clone.in | 2 +- src/lxc/lxc-create.in| 2 +-

Re: [lxc-devel] [PATCH] lxc-setcap.in: Set path to lxc-init

2013-01-22 Thread Serge Hallyn
Quoting Matthias Brugger (matthias@gmail.com): > In lxc-setcap the path to lxc-init wasn't set right, so that > a call to the script failed with an error. This patch sets > the path to the right directory. > > Signed-off-by: Matthias Brugger Acked-by: Serge E. Hallyn > --- > src/lxc/lxc-s

Re: [lxc-devel] [PATCH v2] use which instead of type

2013-01-22 Thread Dwight Engen
On Tue, 22 Jan 2013 13:15:38 -0600 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > ... > > diff --git a/templates/lxc-ubuntu.in b/templates/lxc-ubuntu.in > > index 0ed8808..f443c96 100644 > > --- a/templates/lxc-ubuntu.in > > +++ b/templates/lxc-ubuntu.in > > @@ -609,7 +60

Re: [lxc-devel] [PATCH v2] use which instead of type

2013-01-22 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): ... > diff --git a/templates/lxc-ubuntu.in b/templates/lxc-ubuntu.in > index 0ed8808..f443c96 100644 > --- a/templates/lxc-ubuntu.in > +++ b/templates/lxc-ubuntu.in > @@ -609,7 +609,7 @@ arch=$(arch) > # Code taken from debootstrap > if [ -x /usr/bi

[lxc-devel] [PATCH v2] use which instead of type

2013-01-22 Thread Dwight Engen
This is for consistency with the rest of lxc, and also because type checks for shell builtins, a behavior that we do not want in these cases. Ensure stderr is redirected to /dev/null in all which invocations. Signed-off-by: Dwight Engen --- src/lxc/lxc-clone.in | 2 +- src/lxc/lxc-create.in

[lxc-devel] [PATCH] lxc-setcap.in: Set path to lxc-init

2013-01-22 Thread Matthias Brugger
In lxc-setcap the path to lxc-init wasn't set right, so that a call to the script failed with an error. This patch sets the path to the right directory. Signed-off-by: Matthias Brugger --- src/lxc/lxc-setcap.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc-s

Re: [lxc-devel] [PATCH] use which instead of type in checking for command existence

2013-01-22 Thread Dwight Engen
On Tue, 22 Jan 2013 10:18:44 -0600 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > Use type instead of which for consistency with the rest of lxc, and > > Had me confused for a second due to the backward description :) Yes, sorry about that. > > also because type che

Re: [lxc-devel] [PATCH] use which instead of type in checking for command existence

2013-01-22 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > Use type instead of which for consistency with the rest of lxc, and Had me confused for a second due to the backward description :) > also because type checks for shell builtins, a behavior that we do not > want in these cases. > > Signed-off-by:

[lxc-devel] [PATCH] use which instead of type in checking for command existence

2013-01-22 Thread Dwight Engen
Use type instead of which for consistency with the rest of lxc, and also because type checks for shell builtins, a behavior that we do not want in these cases. Signed-off-by: Dwight Engen --- templates/lxc-busybox.in | 2 +- templates/lxc-ubuntu.in | 4 ++-- 2 files changed, 3 insertions(+), 3

Re: [lxc-devel] [PATCH 1/1] lxc_attach: fix break with user namespaces (v2)

2013-01-22 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi Serge, > > >Would you care to update the patch along these lines? > > Will do, but it will take me a few days time, since I have to set up an > environment where I can test user namespaces first. Awesome, it'll be good to have more people exper

Re: [lxc-devel] [PATCH 1/1] lxc_attach: fix break with user namespaces (v2)

2013-01-22 Thread Christian Seiler
Hi Serge, > Would you care to update the patch along these lines? Will do, but it will take me a few days time, since I have to set up an environment where I can test user namespaces first. Regards, Christian -- Master