Re: [lxc-devel] [PATCH] Remove MAKEDEV call, add autodev hooks, add environment variables for hook scripts.

2013-01-10 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): looks good, one comment (a "you were right" :) ... > + /* Start of environment variable setup for hooks */ > + if (setenv("LXC_NAME", name, 1)) { > + SYSERROR("failed to set environment variable for container > name"); > +

Re: [lxc-devel] [PATCH] utmp.h: Don't fail when utmpx.h isn't present

2013-01-10 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Following a comment on the mailing-list, I made utmp.h return -1 > when it's disabled, the problem with that is that it prevents the > container from starting completely, which isn't quite what I wanted. > > This change makes the function succeed, t

Re: [lxc-devel] [PATCH] utmp.h: Don't fail when utmpx.h isn't present

2013-01-10 Thread Stéphane Graber
On 01/10/2013 05:13 PM, Stéphane Graber wrote: > Following a comment on the mailing-list, I made utmp.h return -1 > when it's disabled, the problem with that is that it prevents the > container from starting completely, which isn't quite what I wanted. > > This change makes the function succeed, t

[lxc-devel] [PATCH] utmp.h: Don't fail when utmpx.h isn't present

2013-01-10 Thread Stéphane Graber
Following a comment on the mailing-list, I made utmp.h return -1 when it's disabled, the problem with that is that it prevents the container from starting completely, which isn't quite what I wanted. This change makes the function succeed, the container will therefore start but without utmp handle

[lxc-devel] [PATCH] use pkg-config to ensure python3-devel is installed

2013-01-10 Thread Dwight Engen
>From c6b906c3cb792c7d83ff7463a02dcd3073d31a55 Mon Sep 17 00:00:00 2001 From: Dwight Engen Date: Thu, 10 Jan 2013 15:45:22 -0500 Subject: [PATCH] use pkg-config to ensure python3-devel is installed The Python.h header varies in location by distribution, so instead use pkg-config to ensure the pyt

Re: [lxc-devel] [PATCH] Define PR_CAPBSET_READ when missing

2013-01-10 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > PR_CAPBSET_READ isn't defined in bionic, so define it if it's not. > > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > src/lxc/caps.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/lxc/caps.c b/src/lxc/caps.c

[lxc-devel] [PATCH] Define PR_CAPBSET_READ when missing

2013-01-10 Thread Stéphane Graber
PR_CAPBSET_READ isn't defined in bionic, so define it if it's not. Signed-off-by: Stéphane Graber --- src/lxc/caps.c | 4 1 file changed, 4 insertions(+) diff --git a/src/lxc/caps.c b/src/lxc/caps.c index 53c552b..7e64a38 100644 --- a/src/lxc/caps.c +++ b/src/lxc/caps.c @@ -37,6 +37,10 @@

[lxc-devel] [LXC] loop module in ubuntu template

2013-01-10 Thread Sujay M
Hi all, I have created a container vm0 using the ubuntu template. I want to use /mnt/sdb1/ as loopback storage. so if i try to mount it i'm getting root@vm0:~# mount /mnt/sdb1/ mount: Could not find any loop device. Maybe this kernel does not know about the loop device? (If so, recompile o