Re: [lxc-devel] [PATCH] Set umask before populating /dev and restore it after.

2013-01-07 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > According to docs, mknod clears each permission bit whose > corresponding bit in the process umask is set, so we should fix it > before creating device nodes. > --- d'oh. Thank you. Acked-by: Serge E. Hallyn > src/lxc/conf

[lxc-devel] [PATCH] Set umask before populating /dev and restore it after.

2013-01-07 Thread Alexander Vladimirov
According to docs, mknod clears each permission bit whose corresponding bit in the process umask is set, so we should fix it before creating device nodes. --- src/lxc/conf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 85d72c9..c0a270f 100644 --- a/s

Re: [lxc-devel] [Lxc-users] lxc-ps lxc-netstat not working

2013-01-07 Thread Natanael Copa
On Mon, 7 Jan 2013 09:33:30 -0600 Serge Hallyn wrote: > Quoting Shibashish (shi...@gmail.com): > > I am on CentOS 6.3 and got lxc working on it. But when I run lxc-ps > > or lxc-netstat, i get the following errors... > > > > lxc-ps: no cgroup mount point found > > lxc-netstat: no cgroup mount po

[lxc-devel] [PATCH] oracle template: use url arg to wget repo file

2013-01-07 Thread Dwight Engen
Signed-off-by: Dwight Engen --- templates/lxc-oracle.in | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/templates/lxc-oracle.in b/templates/lxc-oracle.in index 6a64a33..4ccec9f 100644 --- a/templates/lxc-oracle.in +++ b/templates/lxc-oracle.in @@ -397,7 +397,11 @@ c

[lxc-devel] [PATCH] oracle template: drop additional capabilities

2013-01-07 Thread Dwight Engen
Signed-off-by: Dwight Engen --- templates/lxc-oracle.in | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/templates/lxc-oracle.in b/templates/lxc-oracle.in index 3242dc4..6a64a33 100644 --- a/templates/lxc-oracle.in +++ b/templates/lxc-oracle.in @@ -2

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Dwight Engen
On Mon, 07 Jan 2013 13:26:44 -0500 "Michael H. Warfield" wrote: > On Tue, 2013-01-08 at 01:32 +0800, Alexander Vladimirov wrote: > > 2013/1/8 Serge Hallyn : > > > Quoting Alexander Vladimirov > > > (alexander.idkfa.vladimi...@gmail.com): > > >> Just like on the host: > > >> [idkfa@s10 ~]$ ls -la

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Michael H. Warfield
On Tue, 2013-01-08 at 01:32 +0800, Alexander Vladimirov wrote: > 2013/1/8 Serge Hallyn : > > Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > >> Just like on the host: > >> [idkfa@s10 ~]$ ls -la /dev/{null,tty,urandom,zero,full} > >> crw-rw-rw- 1 root root 1, 7 янв 6 13:30 /d

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > 2013/1/8 Serge Hallyn : > > Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > >> Just like on the host: > >> [idkfa@s10 ~]$ ls -la /dev/{null,tty,urandom,zero,full} > >> crw-rw-rw- 1 root root 1, 7 янв 6 13

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Alexander Vladimirov
2013/1/8 Serge Hallyn : > Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): >> Just like on the host: >> [idkfa@s10 ~]$ ls -la /dev/{null,tty,urandom,zero,full} >> crw-rw-rw- 1 root root 1, 7 янв 6 13:30 /dev/full >> crw-rw-rw- 1 root root 1, 3 янв 6 13:30 /dev/null >> crw-rw-r

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > Just like on the host: > [idkfa@s10 ~]$ ls -la /dev/{null,tty,urandom,zero,full} > crw-rw-rw- 1 root root 1, 7 янв 6 13:30 /dev/full > crw-rw-rw- 1 root root 1, 3 янв 6 13:30 /dev/null > crw-rw-rw- 1 root tty 5, 0 янв 8 00:0

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Alexander Vladimirov
Just like on the host: [idkfa@s10 ~]$ ls -la /dev/{null,tty,urandom,zero,full} crw-rw-rw- 1 root root 1, 7 янв 6 13:30 /dev/full crw-rw-rw- 1 root root 1, 3 янв 6 13:30 /dev/null crw-rw-rw- 1 root tty 5, 0 янв 8 00:03 /dev/tty crw-rw-rw- 1 root root 1, 9 янв 6 13:30 /dev/urandom crw-rw-rw- 1 r

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > I also noticed device nodes having strange permissions when /dev is > being auto-populated > > [idkfa@lxc0 ~]$ ls -la /dev/{null,tty,urandom,zero,full} > crwxr-xr-x 1 root root 1, 7 Jan 6 05:56 /dev/full > crwxr-xr-x 1 root ro

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > On Sun, 2013-01-06 at 06:39 +0800, Alexander Vladimirov wrote: > > It is a separate package in Arch Linux and I dont have it installed on > > the host, as well as in container since everything works well without > > it > > Well, that would explain

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Alexander Vladimirov
Sure, I'll do that 2013/1/7 Serge Hallyn : > Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): >> I can confirm it works for Arch Linux with systemd 196 >> >> However I see exactly one message saying: >> sh: /sbin/MAKEDEV: No such file or directory > > Oh, then we should at le

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > I can confirm it works for Arch Linux with systemd 196 > > However I see exactly one message saying: > sh: /sbin/MAKEDEV: No such file or directory Oh, then we should at least check for its existence before running it. Do y

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > I see a call to "/sbin/MAKEDEV console" in src/lxc/conf.c. Not sure if > it's that call that's generating the problem but there is no MAKEDEV in Right. With lxc.autodev, upstart's "mounted MOUNTPOINT=/dev" gets sent (bc /dev gets mounted) which

Re: [lxc-devel] [Lxc-users] lxc-ps lxc-netstat not working

2013-01-07 Thread Serge Hallyn
Quoting Shibashish (shi...@gmail.com): > I am on CentOS 6.3 and got lxc working on it. But when I run lxc-ps or > lxc-netstat, i get the following errors... > > lxc-ps: no cgroup mount point found > lxc-netstat: no cgroup mount point found > > > Relevant lines in lxc-ps.in... (I tried bot the op

Re: [lxc-devel] [PATCH] Remove /dev/kmsg symlinking.

2013-01-07 Thread Alexander Vladimirov
process_event function in journald (http://cgit.freedesktop.org/systemd/systemd/tree/src/journal/journald-server.c#n987) handles events differently depending on descriptor type. Debugging with gdb showed that /dev/kmsg being a symlink triggers "invalid event" error at line 1032 (http://cgit.freedes

Re: [lxc-devel] [PATCH] Remove /dev/kmsg symlinking.

2013-01-07 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > Symlink cannot resemble /dev/kmsg semantics, so symlinking it is wrong. Hm. It works fine in my containers, and gives me nice startup messages on console. > Guests probably should not use /dev/kmsg at all. > Fixes journald cr

[lxc-devel] lxc-ps lxc-netstat not working

2013-01-07 Thread Shibashish
I am on CentOS 6.3 and got lxc working on it. But when I run lxc-ps or lxc-netstat, i get the following errors... lxc-ps: no cgroup mount point found lxc-netstat: no cgroup mount point found Relevant lines in lxc-ps.in... (I tried bot the options) # Get the filesystem mountpoint