Re: [lxc-devel] [PATCH 4/4] python: Remove hardcoded LXCPATH

2012-12-05 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Switch the python scripts to using @LXCPATH@. > > According to grep, this was the last occurence of a /var/*/lxc > path in the code. > > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn thanks, -serge --

Re: [lxc-devel] [PATCH 3/4] templates: Consistent use of locking

2012-12-05 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Move to per-template lock (except for oracle that's per-container). > Also ensure that the path used for the lock is relative to LOCALSTATEDIR. > > Signed-off-by: Stéphane Graber I believe a few conversions to LOCALSTATEDIR were missed in mkdirs,

Re: [lxc-devel] [PATCH 2/4] lxc-archlinux: Don't hardcode /var/lib/lxc in help

2012-12-05 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber > --- > templates/lxc-archlinux.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/templates/lxc-archlinux.in b/templates/lxc-archlinux.in > index 5db5b85..cf274d4 100644 > --- a/templates/lx

Re: [lxc-devel] [PATCH 1/4] lxc-ubuntu: Don't hardcode path to cache

2012-12-05 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Use LOCALSTATEDIR to generate the path to the cache. > > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > configure.ac| 1 + > templates/lxc-ubuntu| 729 > > te

Re: [lxc-devel] [PATCH 3/4] templates: Make generated config consistent

2012-12-05 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > This updates all the templates and the configuration files to consistently > use "key = value" everywhere. > > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > config/lxc.conf.libvirt | 6 +++--- > config/lxc.conf.ubuntu

Re: [lxc-devel] [PATCH 2/4] Minor documentation updates

2012-12-05 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > - Update COPYING to the current copy of the LPGL-2.1 license from >common-licences (only difference is some indentation). > - Remove mixed tabs/spaces in CONTRIBUTING > - Make INSTALL fit on 79 cols. > > Signed-off-by: Stéphane Graber Acked

Re: [lxc-devel] [PATCH 1/4] Update README

2012-12-05 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > This adds a section about the staging branch to the README and updates > the list of supported architectures. > > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > README | 9 - > 1 file changed, 8 insertions(+), 1 deleti

[lxc-devel] [PATCH 4/4] python: Remove hardcoded LXCPATH

2012-12-05 Thread Stéphane Graber
Switch the python scripts to using @LXCPATH@. According to grep, this was the last occurence of a /var/*/lxc path in the code. Signed-off-by: Stéphane Graber --- configure.ac | 2 + src/python-lxc/examples/api_test.py| 151 --- src/python-lxc/examples/api

[lxc-devel] [PATCH 1/4] lxc-ubuntu: Don't hardcode path to cache

2012-12-05 Thread Stéphane Graber
Use LOCALSTATEDIR to generate the path to the cache. Signed-off-by: Stéphane Graber --- configure.ac| 1 + templates/lxc-ubuntu| 729 templates/lxc-ubuntu.in | 729 3 files changed

[lxc-devel] [PATCH 3/4] templates: Consistent use of locking

2012-12-05 Thread Stéphane Graber
Move to per-template lock (except for oracle that's per-container). Also ensure that the path used for the lock is relative to LOCALSTATEDIR. Signed-off-by: Stéphane Graber --- templates/lxc-altlinux.in | 4 ++-- templates/lxc-debian.in | 4 ++-- templates/lxc-fedora.in | 4 ++--

[lxc-devel] [PATCH 2/4] lxc-archlinux: Don't hardcode /var/lib/lxc in help

2012-12-05 Thread Stéphane Graber
Signed-off-by: Stéphane Graber --- templates/lxc-archlinux.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/lxc-archlinux.in b/templates/lxc-archlinux.in index 5db5b85..cf274d4 100644 --- a/templates/lxc-archlinux.in +++ b/templates/lxc-archlinux.in @@ -375,7 +375,

Re: [lxc-devel] oracle template: fixes when using fedora host

2012-12-05 Thread Stéphane Graber
On 12/05/2012 04:25 PM, Dwight Engen wrote: > Let oracle template work when host is fedora or oracle and the lsb_release > command is not present. Verify the arch given is valid. Don't add lxc.network > section again if already present. > > Signed-off-by: Dwight Engen Acked-by: Stéphane Graber

[lxc-devel] [PATCH 3/4] templates: Make generated config consistent

2012-12-05 Thread Stéphane Graber
This updates all the templates and the configuration files to consistently use "key = value" everywhere. Signed-off-by: Stéphane Graber --- config/lxc.conf.libvirt | 6 +++--- config/lxc.conf.ubuntu| 6 +++--- config/lxc.conf.unknown | 2 +- templates/lxc-altlinux.in |

[lxc-devel] [PATCH 1/4] Update README

2012-12-05 Thread Stéphane Graber
This adds a section about the staging branch to the README and updates the list of supported architectures. Signed-off-by: Stéphane Graber --- README | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/README b/README index b81e7a9..d7dacfd 100644 --- a/README +++ b/READM

[lxc-devel] [PATCH 2/4] Minor documentation updates

2012-12-05 Thread Stéphane Graber
- Update COPYING to the current copy of the LPGL-2.1 license from common-licences (only difference is some indentation). - Remove mixed tabs/spaces in CONTRIBUTING - Make INSTALL fit on 79 cols. Signed-off-by: Stéphane Graber --- CONTRIBUTING | 7 +++ COPYING | 14 ++

[lxc-devel] oracle template: fixes when using fedora host

2012-12-05 Thread Dwight Engen
Let oracle template work when host is fedora or oracle and the lsb_release command is not present. Verify the arch given is valid. Don't add lxc.network section again if already present. Signed-off-by: Dwight Engen --- templates/lxc-oracle.in | 28 +++- 1 files changed,

Re: [lxc-devel] [PATCH] make install should create /var/cache/lxc directory

2012-12-05 Thread Stéphane Graber
On 12/05/2012 03:05 PM, Dwight Engen wrote: > On Thu, 29 Nov 2012 16:37:21 -0500 > Stéphane Graber wrote: > >> On 11/29/2012 04:24 PM, Dwight Engen wrote: >>> The $LXCPATH (default /var/lib/lxc) directory was not being created >>> by make install, so unless it gets created by some other means >>>

[lxc-devel] [PATCH] make install should create /var/cache/lxc directory

2012-12-05 Thread Dwight Engen
On Thu, 29 Nov 2012 16:37:21 -0500 Stéphane Graber wrote: > On 11/29/2012 04:24 PM, Dwight Engen wrote: > > The $LXCPATH (default /var/lib/lxc) directory was not being created > > by make install, so unless it gets created by some other means > > (packaging tools), commands such as lxc-create wil

Re: [lxc-devel] [PATCH v2] Use LXCPATH and LOCALSTATEDIR instead of hardcoded /var

2012-12-05 Thread Stéphane Graber
On 12/05/2012 12:33 PM, Dwight Engen wrote: > Signed-off-by: Dwight Engen Acked-by: Stéphane Graber And applied to staging, thanks! I also noticed that lxc-archlinux.in was missing similar changes so I did the same changes there and pushed that commit directly to staging. I see that lxc-ubunt

[lxc-devel] [PATCH v2] Use LXCPATH and LOCALSTATEDIR instead of hardcoded /var

2012-12-05 Thread Dwight Engen
Signed-off-by: Dwight Engen --- src/lxc/conf.c|4 ++-- src/tests/containertests.c|2 +- src/tests/saveconfig.c|2 +- src/tests/startone.c | 16 templates/lxc-altlinux.in | 10 +- templates/lxc-fedora.in | 12

Re: [lxc-devel] [PATCH] Use LXCPATH and LOCALSTATEDIR instead of hardcoded /var

2012-12-05 Thread Dwight Engen
On Fri, 30 Nov 2012 17:09:28 -0500 Stéphane Graber wrote: > On 11/30/2012 09:50 AM, Dwight Engen wrote: > > Signed-off-by: Dwight Engen > > It looks like you're mixing LOCALSTATEDIR "/lib/lxc" and LXCPATH > quite a bit. Shouldn't we use LXCPATH whenever possible? Sorry, just now noticed your c

[lxc-devel] LXC 0.9.alpha1

2012-12-05 Thread Stéphane Graber
Hello, After discussing this briefly with Daniel, I wanted to make all of you aware that we are currently planning on sending a pull request of the staging branch on the 10th of December (next Monday). This pull request will very likely contain everything that's currently in the staging branch an

Re: [lxc-devel] [PATCH 1/1] lxc-create: refuse to use a custom rootfs (--dir) which already exists.

2012-12-05 Thread Stéphane Graber
On 12/05/2012 11:38 AM, Serge Hallyn wrote: > Signed-off-by: Serge Hallyn Acked-by: Stéphane Graber Pushed to staging. Thanks > --- > src/lxc/lxc-create.in |4 > 1 file changed, 4 insertions(+) > > diff --git a/src/lxc/lxc-create.in b/src/lxc/lxc-create.in > index 650a245..3c66bfa 1

[lxc-devel] [PATCH 1/1] lxc-create: refuse to use a custom rootfs (--dir) which already exists.

2012-12-05 Thread Serge Hallyn
Signed-off-by: Serge Hallyn --- src/lxc/lxc-create.in |4 1 file changed, 4 insertions(+) diff --git a/src/lxc/lxc-create.in b/src/lxc/lxc-create.in index 650a245..3c66bfa 100644 --- a/src/lxc/lxc-create.in +++ b/src/lxc/lxc-create.in @@ -313,6 +313,10 @@ if [ -n "$custom_rootfs" ]; the

Re: [lxc-devel] [PATCH] lxc-ls: Update code to allow non-root listing

2012-12-05 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Re-arrange the code so that we only grab the container object when doing > something more than building a simple list of existing containers. > > This means that now the following calls can run unprivileged: > - lxc-ls > - lxc-ls -1 > > Everythin