Re: [lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Michael H. Warfield
On Mon, 2012-12-03 at 21:25 -0600, Serge Hallyn wrote: > Quoting Michael H. Warfield (m...@wittsend.com): > > On Mon, 2012-12-03 at 20:43 -0600, Serge Hallyn wrote: > > > A-ha, actually busybox cp does not support -T, at least here on ubuntu > > > 12.10. So should we go with rsync -ah after all si

Re: [lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > On Mon, 2012-12-03 at 20:43 -0600, Serge Hallyn wrote: > > A-ha, actually busybox cp does not support -T, at least here on ubuntu > > 12.10. So should we go with rsync -ah after all since it's more likely > > they'll install rsync next to busybox?

Re: [lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Michael H. Warfield
On Mon, 2012-12-03 at 20:43 -0600, Serge Hallyn wrote: > A-ha, actually busybox cp does not support -T, at least here on ubuntu > 12.10. So should we go with rsync -ah after all since it's more likely > they'll install rsync next to busybox? Or is that not actually likely? rsync -aH Capitalizat

Re: [lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Serge Hallyn
A-ha, actually busybox cp does not support -T, at least here on ubuntu 12.10. So should we go with rsync -ah after all since it's more likely they'll install rsync next to busybox? Or is that not actually likely? -serge ---

Re: [lxc-devel] [PATCH] Rewrite lxc-ls in python

2012-12-03 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > This rewrite is mostly compatible with the shell version. > --active and -1 still work and behave as they used to. > > This adds --running, --stopped and --frozen as state filters. > > A new "fancy" view is also implemented (can be used with --fanc

[lxc-devel] [PATCH RFC] lxc_conf logfile and loglevel support

2012-12-03 Thread Serge Hallyn
Add 'lxc.logfile' and 'lxc.loglevel' config items. Values provided on the command line override the config items. Have lxccontainer not set a default loglevel and logfile. Signed-off-by: Serge Hallyn --- src/lxc/conf.c |3 +++ src/lxc/conf.h |3 +++ src/lxc/confile.c

Re: [lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Michael H. Warfield
On Mon, 2012-12-03 at 14:10 -0500, Dwight Engen wrote: > On Mon, 03 Dec 2012 13:55:41 -0500 > "Michael H. Warfield" wrote: > > > On Mon, 2012-12-03 at 12:18 -0600, Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > > On Mon, 3 Dec 2012 10:47:26 -0600 > > > > Serge Hal

Re: [lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Dwight Engen
On Mon, 03 Dec 2012 13:55:41 -0500 "Michael H. Warfield" wrote: > On Mon, 2012-12-03 at 12:18 -0600, Serge Hallyn wrote: > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > On Mon, 3 Dec 2012 10:47:26 -0600 > > > Serge Hallyn wrote: > > > > > > > Quoting Dwight Engen (dwight.en...@oracle.

Re: [lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Michael H. Warfield
On Mon, 2012-12-03 at 12:18 -0600, Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > On Mon, 3 Dec 2012 10:47:26 -0600 > > Serge Hallyn wrote: > > > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > > On Mon, 3 Dec 2012 10:04:13 -0600 > > > > Serge Hallyn wrote: >

Re: [lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Michael H. Warfield
On Mon, 2012-12-03 at 12:40 -0500, Dwight Engen wrote: > On Mon, 3 Dec 2012 10:47:26 -0600 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > On Mon, 3 Dec 2012 10:04:13 -0600 > > > Serge Hallyn wrote: > > > > > > > However one question is: is -H ubiquitous? > >

Re: [lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Mon, 3 Dec 2012 10:47:26 -0600 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > On Mon, 3 Dec 2012 10:04:13 -0600 > > > Serge Hallyn wrote: > > > > > > > However one question is: is -H ubiquitous? > > > > >

Re: [lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Dwight Engen
On Mon, 3 Dec 2012 10:47:26 -0600 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > On Mon, 3 Dec 2012 10:04:13 -0600 > > Serge Hallyn wrote: > > > > > However one question is: is -H ubiquitous? > > > > I'm wondering why we don't just use the cp -a? It seems like cp is

Re: [lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Mon, 3 Dec 2012 10:04:13 -0600 > Serge Hallyn wrote: > > > However one question is: is -H ubiquitous? > > I'm wondering why we don't just use the cp -a? It seems like cp is far > more likely to be installed than rsync? rootfs_path probably do

Re: [lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Dwight Engen
On Mon, 3 Dec 2012 10:04:13 -0600 Serge Hallyn wrote: > However one question is: is -H ubiquitous? I'm wondering why we don't just use the cp -a? It seems like cp is far more likely to be installed than rsync? rootfs_path probably doesn't already exist so it not like rsync is going to be faster

[lxc-devel] [PATCH 2/2] templates: use hardlink detection in rsync

2012-12-03 Thread Serge Hallyn
However one question is: is -H ubiquitous? Signed-off-by: Serge Hallyn --- templates/lxc-altlinux.in |2 +- templates/lxc-debian.in |2 +- templates/lxc-fedora.in |2 +- templates/lxc-opensuse.in |2 +- templates/lxc-ubuntu |2 +- 5 files changed, 5 insertions(+), 5

[lxc-devel] [PATCH 1/2] lxc-clone: use hardlink detection in rsync

2012-12-03 Thread Serge Hallyn
Otherwise busybox clones have been reported to explode from 2M to 440M. Despite man pages claims to the contrary this does not seem to slow down a lxc-clone or increase CPU use. Reported-by: Rene K. Mueller Signed-off-by: Serge Hallyn --- src/lxc/lxc-clone.in |4 ++-- 1 file changed, 2 ins

Re: [lxc-devel] [PATCHv2] lxc-create: Store template information in config

2012-12-03 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Change lxc-create to add the name of the template, checksum and any > parameters > to the container's configuration. > This makes it easier to debug and figure out exactly how a container was > built. > > Signed-off-by: Stéphane Graber Acked-by: S

Re: [lxc-devel] [PATCH] lxc-create: Script cleanup

2012-12-03 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > - Removes the mixed tabs/spaces, replacing by standard 4 spaces indent. > - Fix a bunch of bashisms. > - Use shell syntax for and/or in if statements instead of the "test" > syntax. > - Improve block spacing a bit. > > Signed-off-by: Stéphane Gr

[lxc-devel] [PATCH] lxc-create: Script cleanup

2012-12-03 Thread Stéphane Graber
- Removes the mixed tabs/spaces, replacing by standard 4 spaces indent. - Fix a bunch of bashisms. - Use shell syntax for and/or in if statements instead of the "test" syntax. - Improve block spacing a bit. Signed-off-by: Stéphane Graber --- src/lxc/lxc-create.in | 175 ++