On 11/27/2012 11:07 AM, Dwight Engen wrote:
> This allows containers created with lxc-create to also boot under
> libvirt/Virtual Machine Monitor
>
> Signed-off-by: Dwight Engen
Acked-by: Stéphane Graber
Applied to staging. Thanks!
> ---
> templates/lxc-oracle.in | 21 +
On 11/27/2012 02:23 PM, Serge Hallyn wrote:
> Quoting Dwight Engen (dwight.en...@oracle.com):
>> This makes it easier to write a binding, and presents a cleaner API. Use
>> strdupa in a few places to get mutable strings for tokenizing / parsing.
>> Also change the argv type in lxcapi_start and lxca
Quoting Dwight Engen (dwight.en...@oracle.com):
> This makes it easier to write a binding, and presents a cleaner API. Use
> strdupa in a few places to get mutable strings for tokenizing / parsing.
> Also change the argv type in lxcapi_start and lxcapi_create to match
> that of execv(3).
>
> Signe
This allows containers created with lxc-create to also boot under
libvirt/Virtual Machine Monitor
Signed-off-by: Dwight Engen
---
templates/lxc-oracle.in | 21 +
1 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/templates/lxc-oracle.in b/templates/lxc-oracle.i
On 11/26/2012 04:39 PM, Natanael Copa wrote:
> Avoid getop --longoptions.
>
> Signed-off-by: Natanael Copa
Looks reasonable, though I'm not usually using that script so didn't
actually test the change.
Acked-by: Stéphane Graber
And pushed to staging. Thanks.
> ---
> src/lxc/lxc-setuid.in |
On 11/26/2012 04:37 PM, Natanael Copa wrote:
> Avoid getopt --longoptions
>
> Signed-off-by: Natanael Copa
Looks reasonable, though I'm not usually using that script so didn't
actually test the change.
Acked-by: Stéphane Graber
And pushed to staging. Thanks.
> ---
> src/lxc/lxc-setcap.in |
On 11/26/2012 03:57 PM, Dwight Engen wrote:
> LXCDIR is only used in lxc_container_new, whereas LXCPATH is used throughout
> the rest of lxc, and even in the same file as lxc_container_new (for example
> create_container_dir()).
>
> Signed-off-by: Dwight Engen
Good catch.
Acked-by: Stéphane Gra
On 11/27/2012 02:27 AM, Natanael Copa wrote:
> - replace 'echo -e' with printf
> - replace 'if [[ ... ]]' with 'if [ ... ]'
> - add \ at after && and || when those are at end of line
>
> Signed-off-by: Natanael Copa
Looks good, acked and added to the staging branch. Thanks
> ---
> Changes v1 ->
On 11/27/2012 02:13 AM, Natanael Copa wrote:
> There is no reason to depend on bash for a single echo.
>
> Signed-off-by: Natanael Copa
Applied to staging. Thanks.
As for whether to move that code to lxc-info, I don't think that'd be
the right thing to do as lxc-info is meant to retrieve inform
