[lxc-devel] [PATCH] lxc-create: use posix shell instead of bash

2012-11-16 Thread Natanael Copa
- use '[ -x /path/prog ]' instead of 'type /path/prog' - avoid getopt --longoptions - add \ at after && and || when those are at end of line - make sure condition expands to empty string if variable is empty Signed-off-by: Natanael Copa --- I have tested it with 'lxc-create -t debian ...' with bu

Re: [lxc-devel] using posix shell instead of bash

2012-11-16 Thread Serge Hallyn
Quoting Natanael Copa (nc...@alpinelinux.org): > On Wed, 14 Nov 2012 09:54:58 -0600 > Serge Hallyn wrote: > > > Successful runs of > > https://code.launchpad.net/~serge-hallyn/+junk/lxc-test with your > > patches will also be reassuring. > > This is causing problems for me: > > if dist[0]

Re: [lxc-devel] using posix shell instead of bash

2012-11-16 Thread Natanael Copa
On Wed, 14 Nov 2012 09:54:58 -0600 Serge Hallyn wrote: > Successful runs of > https://code.launchpad.net/~serge-hallyn/+junk/lxc-test with your > patches will also be reassuring. This is causing problems for me: if dist[0] != "Ubuntu": print >>sys.stderr, "This test suite does not