Re: [lxc-devel] [PATCH v2] lxc-start: add option -p, --pidfile=FILE

2012-11-15 Thread Stéphane Graber
On 11/15/2012 10:31 AM, Serge Hallyn wrote: > Quoting Natanael Copa (nc...@alpinelinux.org): >> Add option to create a pidfile for lxc-start. This is helpful for >> init scripts and process monitors when running as daemon. >> >> Signed-off-by: Natanael Copa > > Acked-by: Serge E. Hallyn Acked-b

[lxc-devel] [PATCH] lxc-checkconfig: use posix shell instead of bash

2012-11-15 Thread Natanael Copa
- replace 'echo -e' with printf - replace 'if [[ ... ]]' with 'if [ ... ]' - add \ at after && and || when those are at end of line Signed-off-by: Natanael Copa --- I have tested the patch locally and it appears to work. On busybox 'echo -e' works but I replaced them since checkbashisms mentione

Re: [lxc-devel] [PATCH v2] lxc-start: add option -p, --pidfile=FILE

2012-11-15 Thread Serge Hallyn
Quoting Natanael Copa (nc...@alpinelinux.org): > Add option to create a pidfile for lxc-start. This is helpful for > init scripts and process monitors when running as daemon. > > Signed-off-by: Natanael Copa Acked-by: Serge E. Hallyn Only one comment below > --- > Changes v1 -> v2: > - allow

[lxc-devel] [PATCH v2] lxc-start: add option -p, --pidfile=FILE

2012-11-15 Thread Natanael Copa
Add option to create a pidfile for lxc-start. This is helpful for init scripts and process monitors when running as daemon. Signed-off-by: Natanael Copa --- Changes v1 -> v2: - allow use --pidfile without --daemon - update the doc to reflect the above - reword usage help text slightly doc/l