Re: [lxc-devel] [PATCH] handle clone of btrfs snapshots

2012-09-26 Thread Stéphane Graber
On 12-09-26 02:11 PM, Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): >> >> Fix determination of $oldroot from the config file. The old code had the ' >> in the wrong place and didn't account for whitespace between the = and >> the rootfs. >> >> Set $rootfs based on $oldroot i

Re: [lxc-devel] [PATCH] handle clone of btrfs snapshots

2012-09-26 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > > Fix determination of $oldroot from the config file. The old code had the ' > in the wrong place and didn't account for whitespace between the = and > the rootfs. > > Set $rootfs based on $oldroot instead of forcing it to be in > $lxc_path/$lxc_n

Re: [lxc-devel] [PATCH] handle clone of btrfs snapshots

2012-09-26 Thread Stéphane Graber
On 12-09-26 01:20 PM, Dwight Engen wrote: > > Fix determination of $oldroot from the config file. The old code had the ' > in the wrong place and didn't account for whitespace between the = and > the rootfs. > > Set $rootfs based on $oldroot instead of forcing it to be in > $lxc_path/$lxc_new/roo

Re: [lxc-devel] [PATCH] if the rootfs is a btrfs subvolume, delete it instead of rm -rf

2012-09-26 Thread Stéphane Graber
On 12-09-26 12:59 PM, Dwight Engen wrote: > Check if the rootfs is btrfs subvolume, and if so delete it. Otherwise > fall back to the rm -rf. > > Signed-off-by: Dwight Engen > --- > src/lxc/lxc-destroy.in | 13 + > 1 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/

Re: [lxc-devel] [PATCH] fix minor spelling error

2012-09-26 Thread Stéphane Graber
On 12-09-26 12:59 PM, Dwight Engen wrote: > > Signed-off-by: Dwight Engen > --- > doc/lxc-attach.sgml.in |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/doc/lxc-attach.sgml.in b/doc/lxc-attach.sgml.in > index a9a2902..34e9027 100644 > --- a/doc/lxc-attach.sgml.in

[lxc-devel] [PATCH] handle clone of btrfs snapshots

2012-09-26 Thread Dwight Engen
Fix determination of $oldroot from the config file. The old code had the ' in the wrong place and didn't account for whitespace between the = and the rootfs. Set $rootfs based on $oldroot instead of forcing it to be in $lxc_path/$lxc_new/rootfs. This allows for btrfs snapshot to be made even if $

[lxc-devel] [PATCH] if the rootfs is a btrfs subvolume, delete it instead of rm -rf

2012-09-26 Thread Dwight Engen
Check if the rootfs is btrfs subvolume, and if so delete it. Otherwise fall back to the rm -rf. Signed-off-by: Dwight Engen --- src/lxc/lxc-destroy.in | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/lxc/lxc-destroy.in b/src/lxc/lxc-destroy.in index 5c7656

[lxc-devel] [PATCH] fix minor spelling error

2012-09-26 Thread Dwight Engen
Signed-off-by: Dwight Engen --- doc/lxc-attach.sgml.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/lxc-attach.sgml.in b/doc/lxc-attach.sgml.in index a9a2902..34e9027 100644 --- a/doc/lxc-attach.sgml.in +++ b/doc/lxc-attach.sgml.in @@ -133,7 +133,7 @@ Foundation,