Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-19 Thread Christian Seiler
Hi, >> I think /dev is the safest at the moment. Arguably it's wrong as it's >> not an actual device node, but it's the only directory that lxc already >> requires all distros not to mess with (or we wouldn't have working >> console, tty, ...). > > What are some other alternatives? > > We could

Re: [lxc-devel] [PATCH 2/2] allow short -h and -n options to lxc-ps

2012-09-19 Thread Stéphane Graber
On 12-09-18 03:58 PM, Dwight Engen wrote: > --- > doc/lxc-ps.sgml.in |4 ++-- > src/lxc/lxc-ps.in |4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Looks good. Applied to staging. Thanks > diff --git a/doc/lxc-ps.sgml.in b/doc/lxc-ps.sgml.in > index f3275ae..401a17c 100644 >

Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-19 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On 12-09-19 10:12 AM, Christian Seiler wrote: > > Hi, > > > >>> - is now in /run instead of /dev > >> > >> I don't think that part's going to work... Most distros mount /run as > >> tmpfs at boot time which will hide anything you're putting in the

[lxc-devel] [PATCH v2.1] Add mechanism for container to notify host about end of boot

2012-09-19 Thread Christian Seiler
This patch adds a simple notification system that allows the container to notify the host (in particular, the lxc-start process) that the boot process has been completed successfully. It also adds an additional status BOOTING that lxc-info may return. This allows the administrator and scripts to di

Re: [lxc-devel] [PATCH 1/2] fix trivial off by one error

2012-09-19 Thread Dwight Engen
On Tue, 18 Sep 2012 14:32:02 -0700 (PDT) Christian Seiler wrote: > Hi, > > > Do you think mallocing an fd_set and using FD_SET() and friends > > would be better? The (dispose|finish) loops would visit FD_SETSIZE > > bits with an FD_ISSET() test, which is more work than you have > > currently wit

Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-19 Thread Stéphane Graber
On 12-09-19 10:12 AM, Christian Seiler wrote: > Hi, > >>> - is now in /run instead of /dev >> >> I don't think that part's going to work... Most distros mount /run as >> tmpfs at boot time which will hide anything you're putting in there >> before boot. > > Hmmm, that is indeed a problem... Do

Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-19 Thread Christian Seiler
Hi, >> - is now in /run instead of /dev > > I don't think that part's going to work... Most distros mount /run as > tmpfs at boot time which will hide anything you're putting in there > before boot. Hmmm, that is indeed a problem... Do you have any suggestions? Or should we just keep it in /dev

Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-19 Thread Stéphane Graber
On 12-09-19 07:49 AM, Christian Seiler wrote: > Hi there, > > I've now updated my patch, there are now the following changes, > partially based on feedback from this list, partially from sorting > things in my head a bit. > > - socket instead of a FIFO > - is now in /run instead of /dev I do

[lxc-devel] [PATCH v2] Add mechanism for container to notify host about end of boot

2012-09-19 Thread Christian Seiler
This patch adds a simple notification system that allows the container to notify the host (in particular, the lxc-start process) that the boot process has been completed successfully. It also adds an additional status BOOTING that lxc-info may return. This allows the administrator and scripts to di

Re: [lxc-devel] [PATCH] Add mechanism for container to notify host about end of boot

2012-09-19 Thread Christian Seiler
Hi there, I've now updated my patch, there are now the following changes, partially based on feedback from this list, partially from sorting things in my head a bit. - socket instead of a FIFO - is now in /run instead of /dev - parent directories of socket inside container are automatically