Re: [lxc-devel] [PATCH 0/5] Signal stuff v2 and some documentation

2010-06-10 Thread Ferenc Wagner
Ferenc Wagner writes: > I admittedly didn't test running lxc-start in the background, but it > blocks SIGTTOU, so it should be unaffected... Thinking again, maybe we could turn the table and change the process group ID of lxc-start instead, thereby putting it into the background. No, that sounds

Re: [lxc-devel] [PATCH 0/5] Signal stuff v2 and some documentation

2010-06-10 Thread Ferenc Wagner
Daniel Lezcano writes: > On 06/09/2010 07:56 PM, Ferenc Wagner wrote: > >> here are basically the same patches, with some obvious errors corrected >> and some unrelated documentation added. It actually survived some >> targeted testing in the past days and seems to behave as expected, ie. >> >>

Re: [lxc-devel] [PATCH] Forgotten @LIBEXECDIR@ replacement

2010-06-10 Thread Daniel Lezcano
On 06/10/2010 08:08 PM, Panagiotis H.M. Issaris wrote: > Forgotten part of commit d674be08d4b282bb4717c51440811e39d3c2431e > > Signed-off-by: Panagiotis H.M. Issaris > Right, thanks for the fix. -- ThinkGeek and WIRED

Re: [lxc-devel] [PATCH 5/5] document rootfs options

2010-06-10 Thread Daniel Lezcano
On 06/09/2010 07:56 PM, Ferenc Wagner wrote: > Signed-off-by: Ferenc Wagner > Great, Thanks ! +1 -- ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the luc

Re: [lxc-devel] [PATCH 1/5] start child in its own process group, and put it into the foreground

2010-06-10 Thread Ferenc Wagner
Daniel Lezcano writes: > On 06/09/2010 07:56 PM, Ferenc Wagner wrote: > >> @@ -509,6 +510,22 @@ int lxc_spawn(struct lxc_handler *handler) >> } >> } >> >> +if (setpgid(handler->pid, 0)) { >> +SYSERROR("failed to create new process group"); >> +goto ou

Re: [lxc-devel] [PATCH 3/5] forward signals to the container init

2010-06-10 Thread Daniel Lezcano
On 06/09/2010 07:56 PM, Ferenc Wagner wrote: > Signed-off-by: Ferenc Wagner > +1 -- ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit.

Re: [lxc-devel] [PATCH 2/5] lxc-start isn't in the foreground anymore, so TTY signals don't reach it

2010-06-10 Thread Daniel Lezcano
On 06/09/2010 07:56 PM, Ferenc Wagner wrote: > Signed-off-by: Ferenc Wagner > --- > src/lxc/start.c |9 - > src/lxc/utils.h | 29 ++--- > 2 files changed, 2 insertions(+), 36 deletions(-) > Yeah, cleanup ! +1 > diff --git a/src/lxc/start.c b/src/lxc/s

Re: [lxc-devel] [PATCH 1/5] start child in its own process group, and put it into the foreground

2010-06-10 Thread Daniel Lezcano
On 06/09/2010 07:56 PM, Ferenc Wagner wrote: > Signed-off-by: Ferenc Wagner > --- > src/lxc/start.c | 17 + > 1 files changed, 17 insertions(+), 0 deletions(-) > > diff --git a/src/lxc/start.c b/src/lxc/start.c > index b69ac88..7bbcf5a 100644 > --- a/src/lxc/start.c > +++ b/src

Re: [lxc-devel] [PATCH 4/5] generalize the name of the signal handler

2010-06-10 Thread Daniel Lezcano
On 06/09/2010 07:56 PM, Ferenc Wagner wrote: > Signed-off-by: Ferenc Wagner > +1 -- ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit.

[lxc-devel] [PATCH] Forgotten @LIBEXECDIR@ replacement

2010-06-10 Thread Panagiotis H.M. Issaris
Forgotten part of commit d674be08d4b282bb4717c51440811e39d3c2431e Signed-off-by: Panagiotis H.M. Issaris --- templates/lxc-sshd.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/lxc-sshd.in b/templates/lxc-sshd.in index d474206..6b223ec 100644 --- a/templat

Re: [lxc-devel] [PATCH 0/5] Signal stuff v2 and some documentation

2010-06-10 Thread Daniel Lezcano
On 06/09/2010 07:56 PM, Ferenc Wagner wrote: > Hi, > > here are basically the same patches, with some obvious errors corrected > and some unrelated documentation added. It actually survived some > targeted testing in the past days and seems to behave as expected, ie. > > # lxc-start -n s -- sh -c

[lxc-devel] [PATCH 2/2] fix comment

2010-06-10 Thread Ferenc Wagner
Signed-off-by: Ferenc Wagner --- src/lxc/conf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 5968882..66c60a8 100644 --- a/src/lxc/conf.c +++ b/src/lxc/conf.c @@ -547,7 +547,7 @@ static int setup_rootfs_pivot_root(const char *roo

[lxc-devel] [PATCH 0/2] change pivotdir and its documentation

2010-06-10 Thread Ferenc Wagner
Hi, The documentation part of this depends on my previous rootfs documentation patch. Cheers, Feri. Ferenc Wagner (2): change pivotdir default to mnt fix comment doc/lxc.conf.sgml.in |2 +- src/lxc/conf.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) --

[lxc-devel] [PATCH 1/2] change pivotdir default to mnt

2010-06-10 Thread Ferenc Wagner
The mnt directory has a good chance to already exist in the new root filesystem, so creation and removal can be avoided. This also eases use of read only root filesystems (no configuration necessary). Signed-off-by: Ferenc Wagner --- doc/lxc.conf.sgml.in |2 +- src/lxc/conf.c |2 +