Re: [lxc-devel] [PATCH 2/2] fix typos in error messages

2010-05-12 Thread Daniel Lezcano
Ferenc Wagner wrote: > Signed-off-by: Ferenc Wagner > --- > Applied thanks. -- ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists

Re: [lxc-devel] [PATCH 1/2] remove pivotdir only if it was created by us

2010-05-12 Thread Daniel Lezcano
Ferenc Wagner wrote: > The removal does not account for possible leading path components that > were also created during creation of pivotdir. > > Signed-off-by: Ferenc Wagner > --- > Applied. -- _

[lxc-devel] [GIT] lxc branch, master, updated. 9232212afdad25536afc8d241606e00eac3b0c87

2010-05-12 Thread Daniel Lezcano
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "lxc". The branch, master has been updated via 9232212afdad25536afc8d241606e00eac3b0c87 (commit) via a91d897a7b5ef5ef07ede977

Re: [lxc-devel] [PATCH 1/2] remove pivotdir only if it was created by us

2010-05-12 Thread Daniel Lezcano
Ferenc Wagner wrote: > The removal does not account for possible leading path components that > were also created during creation of pivotdir. > > Signed-off-by: Ferenc Wagner > --- > +1 -- ___

Re: [lxc-devel] lxc-start leaves temporary pivot dir behind

2010-05-12 Thread Daniel Lezcano
Ferenc Wagner wrote: > Daniel Lezcano writes: > > >> Ferenc Wagner wrote: >> >> >>> Daniel Lezcano writes: >>> >>> Ferenc Wagner wrote: > Actually, I'm not sure you can fully solve this. If rootfs is a > separate file system, this is only mu

Re: [lxc-devel] Containerized syslog

2010-05-12 Thread Daniel Lezcano
Jean-Philippe Menil wrote: > Hi, > > I'm playing with containers under debian (squeeze, 2.6.33.3) with the > lxc tools. > I'm really happy about all the features (attach veth on bridge, filter > with iptables inside the containers, etc ...), and i was thinking to > replace some of our vservers (

Re: [lxc-devel] lxc-start leaves temporary pivot dir behind

2010-05-12 Thread Ferenc Wagner
Daniel Lezcano writes: > Ferenc Wagner wrote: > >> Daniel Lezcano writes: >> >>> Ferenc Wagner wrote: >>> Actually, I'm not sure you can fully solve this. If rootfs is a separate file system, this is only much ado about nothing. If rootfs isn't a separate filesystem, you

[lxc-devel] [PATCH 2/2] fix typos in error messages

2010-05-12 Thread Ferenc Wagner
Signed-off-by: Ferenc Wagner --- src/lxc/conf.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 6d9b6b0..4d0223e 100644 --- a/src/lxc/conf.c +++ b/src/lxc/conf.c @@ -468,7 +468,7 @@ static int setup_rootfs_pivot_root(const char *ro

[lxc-devel] [PATCH 1/2] remove pivotdir only if it was created by us

2010-05-12 Thread Ferenc Wagner
The removal does not account for possible leading path components that were also created during creation of pivotdir. Signed-off-by: Ferenc Wagner --- src/lxc/conf.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 2b8ddf4..6d9b6

[lxc-devel] Containerized syslog

2010-05-12 Thread Jean-Philippe Menil
Hi, I'm playing with containers under debian (squeeze, 2.6.33.3) with the lxc tools. I'm really happy about all the features (attach veth on bridge, filter with iptables inside the containers, etc ...), and i was thinking to replace some of our vservers (and maybe some of our kvm) with this so

[lxc-devel] [PATCH 3/5] encapsulate rootfs data in a structure

2010-05-12 Thread Daniel Lezcano
From: Daniel Lezcano We have pivot_dir and rootfs defined in lxc_conf structure. Let's encapsulate them in a rootfs structure. Signed-off-by: Daniel Lezcano --- src/lxc/conf.c| 32 +--- src/lxc/conf.h| 14 -- src/lxc/confile.c |8

[lxc-devel] [PATCH 5/5] use defined rootfs mount point

2010-05-12 Thread Daniel Lezcano
From: Daniel Lezcano As we defined a path where to mount the rootfs, we can use without ambiguity because it is defined by default at compile time or by the configuration. Signed-off-by: Daniel Lezcano --- src/lxc/conf.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) d

[lxc-devel] [PATCH 4/5] add lxc.rootfs.mount config option

2010-05-12 Thread Daniel Lezcano
From: Daniel Lezcano Define lxc.rootfs.mount option in order to override the default mount point for rootfs. Signed-off-by: Daniel Lezcano --- src/lxc/conf.h|1 + src/lxc/confile.c | 18 ++ 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/lxc/conf.h

[lxc-devel] [PATCH 2/5] add a configure option to set a rootfs mount point

2010-05-12 Thread Daniel Lezcano
From: Daniel Lezcano Add a configure option to set a mount point path when using a rootfs, that will replace the actual behavior which creates uneeded /tmp/lxc** directories. Signed-off-by: Daniel Lezcano --- configure.ac |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff

[lxc-devel] [PATCH 1/5] whitespace cleanup in configure.ac

2010-05-12 Thread Daniel Lezcano
From: Daniel Lezcano Mindless changes by removing whitespace. Signed-off-by: Daniel Lezcano --- configure.ac | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 4c8c50f..c6cac11 100644 --- a/configure.ac +++ b/configure.ac @@

[lxc-devel] define a mount point for the rootfs

2010-05-12 Thread Daniel Lezcano
The previous code was creating a temporary directory /tmp/lxc- to mount the rootfs, this is needed to separate the filesystem for the pivot_root, when the rootfs and the host fs are the same. According to the pivot_root man page: "new_root and put_old must not be on the same file system as the