; redefined [-Werror]
#define CONFIG_CMD_DESCR_ROTATE "Archive a tracing session’s current trace
chunk"
conftest.c:154: note: this is the location of the previous definition
#define CONFIG_CMD_DESCR_ROTATE "Archive a tracing session's current trace
chunk"
cc1: all warn
". I'll tackle this
issue separately.
I only built-tested the proposed change, and I don't know anything about
this code, so please check carefully that it is right.
Signed-off-by: Simon Marchi
---
src/common/compat/compat-poll.c | 2 +-
tests/unit/test_utils_compat_poll.c | 1
On 2019-05-27 11:52 a.m., Simon Marchi wrote:
> CMD_DESCR_ROTATE is defined twice by configure. This breaks configuring
> with "-Werror -Wall", as some test programs don't compile due to:
>
> configure:16990: gcc -o conftest -Wall -Werror conftest.c &g
On 2019-05-27 12:28 p.m., Simon Marchi wrote:
> I get this error:
>
> CC compat-poll.lo
> /home/smarchi/src/lttng-tools/src/common/compat/compat-poll.c: In
> function ‘compat_poll_wait’:
> /home/smarchi/src/lttng-tools/src/common/compat/compat-poll.c:353:
This patch changes bitfield.h to be usable in C++11.
It will probably never be compiled as C++ in the context of
lttng-ust, but this is just to keep things sync'ed across projects.
Signed-off-by: Simon Marchi
---
include/lttng/bitfield.h | 6 +-
1 file changed, 5 insertions(+), 1 del
This patch changes bitfield.h to be usable in C++11.
It will probably never be compiled as C++ in the context of
lttng-modules, but this is just to keep things sync'ed across projects.
Signed-off-by: Simon Marchi
---
lib/bitfield.h | 6 +-
1 file changed, 5 insertions(+), 1 del
/examples/hello-static-lib/Makefile is not
directly
influenced by the configure checks. It will not pick up the right tools if you
run "make" directly in doc/examples/hello-static-lib, but only if you run it
from a
directory above.
Simon
From cb819ba1e9dbba612dd22d143c4fb57185b6a
On 2019-11-14 11:24 a.m., Rolf Eike Beer wrote:
> Works for me.
Thanks.
> I have not checked latest git, but maybe you may want to fix this warning,
> too?
>
> With 2.11.0 release tarball:
>
> -./configure: line 24663: test: -eq: unary operator expected
>
> Greetings,
>
> Eike
Hmm I don't r
On 2019-11-15 3:18 a.m., Rolf Eike Beer wrote:
> Simon Marchi wrote:
>> On 2019-11-14 11:24 a.m., Rolf Eike Beer wrote:
>
>>> I have not checked latest git, but maybe you may want to fix this warning,
>>> too?
>>>
>>> With 2.11.0 release tarball:
&g
doesn't hurt to have it there.
[1] https://lists.lttng.org/pipermail/lttng-dev/2019-November/029388.html
Reported-by: Rolf Eike Beer
Signed-off-by: Simon Marchi
---
configure.ac | 1 +
doc/examples/Makefile.am | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --
t a new subshell, so it's unnecessary to do "cd .."
before the subshell exits.
I'm not too sure what's the best way to indent it, feel free to modify
it before changing the patch.
Signed-off-by: Simon Marchi
---
doc/examples/Makefile.am | 56 ++
On 2019-11-18 12:15 p.m., Mathieu Desnoyers wrote:
> Both patches merged into lttng-ust master branch (only).
>
> If you need those backported, please submit separate patches for stable
> branches, as those do not apply cleanly because the following commit is
> in master but not in stable branches
local' failed
make: *** [all-local] Error 1
I inadvertently inserted a character that looks like a space, but that
is not a space. make tries to interpret it as a target name, which
obviously fails.
Replace it with a proper space.
Signed-off-by: Simon Marchi
---
doc/examples/Makefile.am
On 2019-08-19 9:47 p.m., Simon Marchi wrote:
> On 2019-05-27 11:52 a.m., Simon Marchi wrote:
>> CMD_DESCR_ROTATE is defined twice by configure. This breaks configuring
>> with "-Werror -Wall", as some test programs don't compile due to:
>>
>> conf
On 2020-01-13 5:47 p.m., bhanu kiran chaluvadi wrote:
> Hi,
>
> I am trying to cross compile lttng-tools to host: i686-pc-linux-gnu(dedian 8
> - jessie ) from build: x86_64-pc-linux-gnu (ubuntu - 18.04).
>
>
> export PATH=/opt/x-tools/bin:$PATH
> export SYSROOT=/opt/x-tools/i686-pc-linux-gnu/s
Hi Maxime,
Tip for next time: this mailing is used for many projects, so it helps
to include the project name in the patch prefix. You can do so by using
--subject-prefix="PATCH lttng-ust"
on you git-send-email command line.
On 2020-01-31 4:55 p.m., Maxime Roussin-Belanger wrote:
> vtracef a
On 2020-01-31 6:17 p.m., Maxime Roussin-Bélanger wrote:
>> On 2020-01-31 4:55 p.m., Maxime Roussin-Belanger wrote:
>> > vtracef accepts a va_list argument to simplify tracing
>> > functions which use a va_list
>> >
>> > Here's an example from wpa_supplicant that I wanted to
>> > trace:
>> >
>> > vo
On 2020-02-05 6:36 p.m., Maxime Roussin-Belanger wrote:
> vtracef accepts a va_list argument to simplify tracing
> functions which use a va_list
>
> Here's an example from wpa_supplicant that I wanted to
> trace:
>
> void wpa_debug(int level, const char* fmt, ...) {
>
> va_list ap;
> va_
On 2020-02-05 8:17 p.m., Simon Marchi wrote:
> On 2020-02-05 6:36 p.m., Maxime Roussin-Belanger wrote:
>> vtracef accepts a va_list argument to simplify tracing
>> functions which use a va_list
>>
>> Here's an example from wpa_supplicant that I wanted to
>>
1] https://lists.lttng.org/pipermail/lttng-dev/2020-February/029524.html
Signed-off-by: Simon Marchi
Signed-off-by: Philippe Proulx
---
doc/man/Makefile.am | 6 --
doc/man/asciidoc.conf | 20
2 files changed, 4 insertions(+), 22 deletions(-)
diff --git a/doc/man/Makef
On 2020-02-05 9:55 p.m., Simon Marchi wrote:
> Ok, so I poked Phil the doc guy about this, and he spotted that the problem
> is actually in the
> asciidoc -> docbook conversion. He provided the patch provided below. I'll
> try to clean up
> that patch and send it formal
On 2020-03-11 9:39 a.m., mingli...@windriver.com wrote:
> From: Mingli Yu
>
> Initialize the pointer other_entry to fix the below error:
> | ../../../../../git/src/plugins/ctf/fs-src/fs.c: In function
> 'ds_index_insert_ds_index_entry_sorted':
> | ../../../../../git/src/plugins/ctf/fs-src/fs.c:7
Add a '--list-options' option to each command. This is intended to be used for
programmable Bash completion.
I sent a similar patch at the end of last summer, but it seems that it has
never been merged.
Signed-off-by: Simon Marchi
---
src/bin/lttng/commands/add_context.c
Hi,
This is my first or so version of the programmable bash completion
(tab completion) for the LTTng 2.0 command line tool:
http://git.dorsal.polymtl.ca/~smarchi?p=lttng-bash-completion.git;a=blob;f=lttng;hb=HEAD
Currently, it is able to complete general options (before the
command), the comman
This is intended to be used for programmable Bash completion.
Modified from previous version:
- Changed '\0' to 0 to match current coding style.
Signed-off-by: Simon Marchi
---
src/bin/lttng/commands/add_context.c |6 ++
src/bin/lttng/commands/calibrate.c|6 +
nice but for the second level, not working :(.
>>
>> Is it possible to add the automatic print of all available options?
>>
>> Thanks
>> David
>>
>> On 12-01-23 11:17 PM, Simon Marchi wrote:
>>> Hi,
>>
>>> This is my first or so ver
Another victim of copy paste.
Signed-off-by: Simon Marchi
---
src/bin/lttng/commands/create.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/bin/lttng/commands/create.c b/src/bin/lttng/commands/create.c
index a791fbd..0765c82 100644
--- a/src/bin/lttng/commands
Hi,
For those who don't know, we recently started working on the
integration of the state history system designed by Alexandre
Montplaisir in LTTv. This will include a C++ rewrite and a bit of
design work to keep the code as modular as possible. For example, we
want to make sure it is possible to
Hello,
I just tried the 2.0-pre12 bundle, and I got "Undefined command" when
trying the enable-event command.
http://pastebin.com/raw.php?i=KjN3FLdi
Help ?
Simon
___
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mail
From: Simon Marchi
The --simple option makes "list" print one item per line, a nice format to be
parsed by scripts. For example, the bash completion script could benefit from
this feature. For now, only session listing is affected, but it would be
useful to have other kind of listing
Protection against poorly written drivers who give a null name to their
irq handlers.
Signed-off-by: Simon Marchi
---
.../events/lttng-module/lttng-statedump.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/instrumentation/events/lttng-module/lttng
This patch adds src/common/defaults.c file. It contains functions to
retrieve defaults subbuf sizes based on the architecture page size.
Signed-off-by: Simon Marchi
---
src/common/Makefile.am |2 +-
src/common/defaults.c | 86
src/common
Use the functions added by the previous commit. All the occurences of
the previous defines were replaced.
Signed-off-by: Simon Marchi
---
src/bin/lttng-sessiond/channel.c |4 ++--
src/bin/lttng-sessiond/trace-kernel.c|2 +-
src/bin/lttng-sessiond/trace-ust.c |2
This commit removes defines that are now unused.
Signed-off-by: Simon Marchi
---
src/common/defaults.h |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/src/common/defaults.h b/src/common/defaults.h
index efff43e..7319b35 100644
--- a/src/common/defaults.h
+++ b/src
Signed-off-by: Simon Marchi
---
configure.ac |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac
index 1d04062..a4ef8c9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -77,6 +77,7 @@ AS_CASE([$host_cpu],
[ia64], [ARCHTYPE=&quo
Signed-off-by: Simon Marchi
---
configure.ac |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac
index 7f12f23..97a9f65 100644
--- a/configure.ac
+++ b/configure.ac
@@ -213,6 +213,7 @@ changequote([,])dnl
armv5) LIBFORMAT="elf32-litt
Use the functions added by the previous commit. All the occurences of
the previous defines were replaced.
Signed-off-by: Simon Marchi
---
src/bin/lttng-sessiond/channel.c |4 ++--
src/bin/lttng-sessiond/trace-kernel.c|2 +-
src/bin/lttng-sessiond/trace-ust.c |2
This patch adds src/common/defaults.c file. It contains functions to
retrieve defaults subbuf sizes. It uses the DEFAULT_*_SUBBUF_SIZE
defines from defaults.h but also make sure that the values are at least
as big as the page size.
Signed-off-by: Simon Marchi
---
src/common/Makefile.am |2
in slow paths.
Simon
> Hi Simon,
>
> Can you please rename the get_default_* function family to default_get_*
> in order to respect the name spacing of files.
>
> Comment below:
>
> Simon Marchi:
>> This patch adds src/common/defaults.c file. It contains functions to
>
Forgot to remove the dot at the end of the title...
On Sun, Nov 11, 2012 at 8:28 PM, Simon Marchi wrote:
> Use the functions added by the previous commit. All the occurences of
> the previous defines were replaced.
>
> Signed-off-by: Simon Marchi
> ---
> src/bin/lttng-
This patch adds functions to retrieve defaults subbuf sizes. It uses the
DEFAULT_*_SUBBUF_SIZE defines from defaults.h but also make sure that the
values are at least as big as the page size.
The functions are defined as static inline in defaults.h.
Signed-off-by: Simon Marchi
---
src/common
Use the functions added by the previous commit. All the occurences of
the previous defines were replaced.
Signed-off-by: Simon Marchi
---
src/bin/lttng-sessiond/channel.c |4 ++--
src/bin/lttng-sessiond/trace-kernel.c|2 +-
src/bin/lttng-sessiond/trace-ust.c |2
Signed-off-by: Simon Marchi
---
src/common/macros.h |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/src/common/macros.h b/src/common/macros.h
index 8185c85..81f901c 100644
--- a/src/common/macros.h
+++ b/src/common/macros.h
@@ -52,4 +52,12 @@
#define ARRAY_SIZE
This patch adds functions to retrieve defaults subbuf sizes. It uses the
DEFAULT_*_SUBBUF_SIZE defines from defaults.h but also make sure that the
values are at least as big as the page size.
The functions are defined as static inline in defaults.h.
Signed-off-by: Simon Marchi
---
src/common
Use the functions added by the previous commit. All the occurences of
the previous defines were replaced.
Signed-off-by: Simon Marchi
---
src/bin/lttng-sessiond/channel.c |4 ++--
src/bin/lttng-sessiond/trace-kernel.c|2 +-
src/bin/lttng-sessiond/trace-ust.c |2
Signed-off-by: Simon Marchi
---
src/common/macros.h |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/src/common/macros.h b/src/common/macros.h
index 8185c85..81f901c 100644
--- a/src/common/macros.h
+++ b/src/common/macros.h
@@ -52,4 +52,12 @@
#define ARRAY_SIZE
This patch adds functions to retrieve defaults subbuf sizes. It uses the
DEFAULT_*_SUBBUF_SIZE defines from defaults.h but also make sure that the
values are at least as big as the page size.
The functions are defined as static inline in defaults.h.
Signed-off-by: Simon Marchi
---
src/common
Use the functions added by the previous commit. All the occurences of
the previous defines were replaced.
Signed-off-by: Simon Marchi
---
src/bin/lttng-sessiond/channel.c |5 +++--
src/bin/lttng-sessiond/trace-kernel.c|2 +-
src/bin/lttng-sessiond/trace-ust.c |2
Otherwise, if /usr/bin/time does not exist, the tests won't run at all.
Signed-off-by: Simon Marchi
---
tests/runtests-batch.sh |8 +++-
tests/runtests.sh |8 +++-
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/tests/runtests-batch.sh b/tests/run
common
location. If it is not there, the tests are ran without timing info.
Signed-off-by: Simon Marchi
---
tests/common.sh | 13 +
tests/runtests-batch.sh | 15 +--
tests/runtests.sh | 15 +--
3 files changed, 39 insertions(+), 4 deletions
On Thu, Nov 15, 2012 at 12:00 AM, Mathieu Desnoyers
wrote:
> * Simon Marchi (simon.mar...@polymtl.ca) wrote:
>> I work on a platform that does not come with a time program. This patch
>> makes it possible to specify the path of the time binary or not use it
>> if none is av
common
location. If it is not there, the tests are ran without timing info.
Signed-off-by: Simon Marchi
---
New in v2: removed #!/bin/sh at top of common.sh.
tests/common.sh | 12
tests/runtests-batch.sh | 15 +--
tests/runtests.sh | 15
It contains a macro to help checking for kernel version ranges.
Signed-off-by: Simon Marchi
---
lttng-kernel-version.h | 36
1 files changed, 36 insertions(+), 0 deletions(-)
create mode 100644 lttng-kernel-version.h
diff --git a/lttng-kernel-version.h b
Since some distro released the 3.0 kernel as 2.6.40, it might be useful
to adjust some checks to treat 2.6.40 kernels as 3.0.
Signed-off-by: Simon Marchi
---
instrumentation/events/lttng-module/net.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/instrumentation
Since some distro released the 3.0 kernel as 2.6.40, it might be useful
to adjust some checks to treat 2.6.40 kernels as 3.0.
Signed-off-by: Simon Marchi
---
instrumentation/events/lttng-module/net.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/instrumentation
The isolate_mode_t type that appeared in 3.2 was backported to 3.0.39 so
the version check must be fixed. It was not backported to the 3.1 branch
though, so it must be excluded.
Signed-off-by: Simon Marchi
---
probes/lttng-probe-vmscan.c |5 -
1 files changed, 4 insertions(+), 1
Please ignore, I sent only this one patch instead of the two I intended.
On Fri, Nov 23, 2012 at 5:54 PM, Simon Marchi wrote:
> Since some distro released the 3.0 kernel as 2.6.40, it might be useful
> to adjust some checks to treat 2.6.40 kernels as 3.0.
>
> Signed-off-by:
This led to user confusion.
Signed-off-by: Simon Marchi
---
lib/context.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/context.c b/lib/context.c
index 9c11598..5516e49 100644
--- a/lib/context.c
+++ b/lib/context.c
@@ -90,16 +90,16 @@ int
Signed-off-by: Simon Marchi
---
configure.ac |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index c4377a5..a67e8f9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -309,7 +309,6 @@ AS_ECHO("$version_description")
# Report on the con
See f95480cf62e9acb42b74fce162544694b76c9704.
The new btrfs and ext4 tracepoints used 3.0.0 in the compilation logic.
Signed-off-by: Simon Marchi
---
instrumentation/events/lttng-module/btrfs.h |4 ++--
instrumentation/events/lttng-module/ext4.h | 14 +++---
2 files changed, 9
It is required by the syscall tracepoint mechanism.
Signed-off-by: Simon Marchi
---
arch/tile/include/uapi/asm/unistd.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/tile/include/uapi/asm/unistd.h
b/arch/tile/include/uapi/asm/unistd.h
index cd7b6dd..c763c86
When activating syscall tracing, kernel/trace/trace_syscalls.c doesn't
find sys_call_table because it includes , not
. Also, looking at the other architectures, that is
probably where it should be.
Signed-off-by: Simon Marchi
---
arch/tile/include/asm/syscall.h |6 ++
arch/tile/in
This patch adds support for the TIF_SYSCALL_TRACEPOINT on the tile
architecture. Basically, it calls the appropriate tracepoints on syscall
entry and exit.
Signed-off-by: Simon Marchi
---
arch/tile/include/asm/thread_info.h |8
arch/tile/kernel/intvec_64.S| 14
Signed-off-by: Simon Marchi
---
arch/tile/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/tile/Kconfig b/arch/tile/Kconfig
index 8cab409..1adb853 100644
--- a/arch/tile/Kconfig
+++ b/arch/tile/Kconfig
@@ -22,6 +22,7 @@ config TILE
select
This patch adds compilation support for the TileGx architecture. Since
the tests were not ran on other architectures of the Tile family
(Tile64, TIlepro), errors are triggered during compilation if the
architecture is another Tile arch.
Signed-off-by: Simon Marchi
---
configure.ac|1
Also add missing space on the mips line for OCD purposes.
Signed-off-by: Simon Marchi
---
configure.ac |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index c4377a5..919b742 100644
--- a/configure.ac
+++ b/configure.ac
@@ -189,7 +189,8
__copy_from_user_inatomic returns the number of bytes that could not be
copied, not an error code. This fixes the test accordingly.
Signed-off-by: Simon Marchi
---
probes/lttng-probe-user.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/probes/lttng-probe-user.c b
previous partial install or something.
The check is now done earlier, during the configure step and should not
cause any trouble.
Signed-off-by: Simon Marchi
---
configure.ac| 17 -
urcu/arch/tile.h| 30 --
urcu/uatomic/tile.h | 28
Now that the support for the TileGx architecture is integrated in the
various tools of the LTTng chain, I thought I could reduce the bus
factor and post the installation steps to get LTTng up and running on
this platform. The steps assume that the TILERA_ROOT variable is set
correctly. The version
Hello LTTng cyborgs,
As some of you might know, I am trying to port and adapt LTTng to the
Tilera TILEncore-Gx card (and later the Intel Xeon Phi). The main
constraint with these platforms is the non existent disk space, which
means the trace will have to be streamed. I am thinking of using the
PC
wrote:
> * Simon Marchi (simon.mar...@polymtl.ca) wrote:
>> Hello LTTng cyborgs,
>>
>> As some of you might know, I am trying to port and adapt LTTng to the
>> Tilera TILEncore-Gx card (and later the Intel Xeon Phi). The main
>> constraint with these platforms is the n
This is a reminder of what we discussed on IRC a few days ago. It
would be interesting to have a stable 1.0 branch of babeltrace so we
can setup automatic builds of bt stable on launchpad.
Thanks !
Simon
___
lttng-dev mailing list
lttng-dev@lists.lttng
I also cleaned up the little check_sessiond function. The check using
access(2) was only done for the command line option, but I think it is a
good idea to do it wherever the path comes from.
closes #441
Signed-off-by: Simon Marchi
---
configure.ac | 17 +
src/bin
Signed-off-by: Simon Marchi
---
src/common/consumer.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/common/consumer.c b/src/common/consumer.c
index 300fd2a..8730e39 100644
--- a/src/common/consumer.c
+++ b/src/common/consumer.c
@@ -820,7 +820,7 @@ error:
*
* On
Bump.
On 28 February 2013 18:42, Simon Marchi wrote:
> I also cleaned up the little check_sessiond function. The check using
> access(2) was only done for the command line option, but I think it is a
> good idea to do it wherever the path comes from.
>
> closes #441
>
>
I think the point is that having patches in emails is not very
convenient. Given the quality of web based tools available today, I
think it would be relevant that the LTTng project adopt one of them.
With the current system:
- it is hard to see what the resulting code is. You juste have a blob
of
often ? Is this really important ?
On 28 March 2013 12:06, Yannick Brosseau wrote:
> On 2013-03-28 12:03, Simon Marchi wrote:
>> I think the point is that having patches in emails is not very
>> convenient. Given the quality of web based tools available today, I
>> think it w
Hi Yin,
I get the same error. Try putting -lrt after the other arguments of
the LDADD. Since libconsumer.la uses timer_settime from librt, -lrt
has to be after it on the command line.
Simon
On 31 March 2013 13:14, yin sun wrote:
> I am trying the latest git 2.2.0-rc1. seems the the librt is not
It has to be after libconsumer.la.
Signed-off-by: Simon Marchi
---
src/bin/lttng-consumerd/Makefile.am |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/bin/lttng-consumerd/Makefile.am
b/src/bin/lttng-consumerd/Makefile.am
index a418eb4..d340c68 100644
--- a/src
to add some unit tests for parse_human_size, but the current
test system does not make it easy. They will come later.
Signed-off-by: Simon Marchi
---
src/bin/lttng/commands/enable_channels.c | 18 +-
src/bin/lttng/utils.c| 96 +-
src/bin/l
On 2 April 2013 22:39, Christian Babeux wrote:
> Hi Simon,
>
>> I wanted to add some unit tests for parse_human_size, but the current
>> test system does not make it easy. They will come later.
>
> Could you describe the issues you had on a separate thread so we can
> further discuss it?
Will do.
On 2 April 2013 22:52, Raphaël Beamonte wrote:
> On 2013-04-02 16:45, Simon Marchi wrote:
>> --subbuf-size accepts sizes such as:
>>
>> - 123 -> 123
>> - 123k or 123K -> 123 * 1024
>> - 123m or 123M -> 123 * 1024 * 1024
>> - 123g or 123G -> 123
Hello LTTng protagonists,
Here is a more detailled description of the problem I have with the
lttng-tools test suite.
Suppose I want to write a unit test for the list_cmd_options function
that is found in src/bin/lttng/utils.c. Based on existing tests, I
would create the file tests/unit/test_list
On 3 April 2013 12:49, Christian Babeux wrote:
> I would advocate for this option. Could you describe the issues you
> encountered using subdirs-objects?
Let's try to add
AUTOMAKE_OPTIONS = subdir-objects
at the top of tests/unit/Makefile.am. ./bootstrap and ./configure go
fine. When "making",
On 3 April 2013 14:28, Simon Marchi wrote:
> Finally, an idea just like that: instead of specifying the source
> file, would it be possible to specify directly the object file (e.g.
> $(top_srcdir)/src/bin/lttng/utils.o or ../../src/bin/lttng/utils.o) in
> LDADD ? So the unit test Ma
>Normally I'd be the first to advocate k, M, G as powers of 10 and Ki, Mi,
> Gi as powers of two (ISO/IEC 8-13:2008) but the kernel parameters use
> exclusively K, M, and G in the powers of two sense, and I believe just about
> every other part of Linux does also. We should thus, somewh
it tests for parse_human_size, but the current
test system does not make it easy. They will come later.
Signed-off-by: Simon Marchi
---
src/bin/lttng/commands/enable_channels.c | 21 -
src/bin/lttng/utils.c| 129 +-
src/bin/lttng/utils.h
3 April 2013 21:30, Simon Marchi wrote:
> --subbuf-size accepts sizes such as:
>
> - 123 -> 123
> - 123k -> 123 * 1024
> - 123M -> 123 * 1024 * 1024
> - 123G -> 123 * 1024 * 1024 * 1024
>
> It uses the new parse_human_size function, which could probably be used
>> #define _GNU_SOURCE
>> -#include
>> +#include
>> #include
>> #include
>> +#include
>> +#include
>
> any reason why stdlib is moved here ?
I put them in alphabetical order instead of random order.
Thanks for the comments, I will make the changes.
__
Only the tests themselves are built in the unit test folder. They reuse
the object files that are already built during the main compilation
pass. This would fix the conflicts between object names.
Signed-off-by: Simon Marchi
---
tests/unit/Makefile.am | 55
e_size_suffix_SOURCES = test_parse_size_suffix.c
+test_parse_size_suffix_LDADD = $(LIBTAP)
+test_parse_size_suffix_LDADD += $(PARSE_SIZE_SUFFIX)
diff --git a/tests/unit/test_parse_size_suffix.c
b/tests/unit/test_parse_size_suffix.c
new file mode 100644
index 000..70ccb76
--- /dev/null
+++ b/test
/lttng-dev/2013-March/019929.html
[2] https://wiki.ubuntu.com/NattyNarwhal/ToolchainTransition
[3] http://pastebin.com/G2pSkseF
On 10 April 2013 10:22, Mathieu Desnoyers
wrote:
> * Simon Marchi (simon.mar...@polymtl.ca) wrote:
>> It has to be after libconsumer.la.
>>
>
&
On 9 April 2013 12:56, David Goulet wrote:
>> @@ -77,3 +79,122 @@ void list_cmd_options(FILE *ofp, struct poptOption
>> *options)
>> }
>> }
>> }
>> +
>> +/**
>> + * Prints the error message corresponding to a regex error code.
>> + *
>> + * @param errcodeThe error code.
>
+# parse_size_suffix unit test
+PARSE_SIZE_SUFFIX=$(top_srcdir)/src/common/utils.o \
+ $(top_srcdir)/src/common/runas.o
+
+test_parse_size_suffix_SOURCES = test_parse_size_suffix.c
+test_parse_size_suffix_LDADD = $(LIBTAP) $(LIBHASHTABLE) $(LIBCOMMON)
+test_parse_size_suffix_LDADD += $(PARSE_SIZE_SU
--subbuf-size accepts sizes such as:
- 123 -> 123
- 123k -> 123 * 1024
- 123M -> 123 * 1024^2
- 123G -> 123 * 1024^3
It uses the new parse_size_suffix function, which could probably be used
at other places, such as tracefile size.
Unit tests are included.
Signed-off-by: Simon Mar
Hi Hari,
libuuid is indeed required in order to build LTTng-UST for every
platform. The usual way to install it is through a package manager
(package uuid-dev on debian/ubuntu, for example). If this is not an
option, you will have to build it from source. It is part of the
util-linux package [1][2
Hello !
I am trying to add two tracepoints to a simple test application. If I
put both tracepoints in different compilation units (two .c files),
UST crashes when the application starts with the following message:
test: /usr/local/include/lttng/ust-tracepoint-event.h:685:
__lttng_events_init__my_
Just to add a precision, it happens only when both tracepoints use the
same provider.
On 29 April 2013 09:58, Simon Marchi wrote:
> Hello !
>
> I am trying to add two tracepoints to a simple test application. If I
> put both tracepoints in different compilation units (two .c f
ertion is there to check just that.
>
> * Simon Marchi (simon.mar...@polymtl.ca) wrote:
>> Hello !
>>
>> I am trying to add two tracepoints to a simple test application. If I
>> put both tracepoints in different compilation units (two .c files),
>> UST crashes when
On 14 May 2013 08:37, Mathieu Desnoyers wrote:
>
> * Mathieu Desnoyers (mathieu.desnoy...@efficios.com) wrote:
> > * Alexandre Montplaisir (alexmon...@voxpopuli.im) wrote:
> > > On 13-05-11 10:59 PM, Mathieu Desnoyers wrote:
> > > > * Francis Giraldeau (francis.girald...@gmail.com) wrote:
> > > >>
1 - 100 of 230 matches
Mail list logo
