[lttng-dev] [PATCH lttng-tools] Fix: cleanup stream on snapshot failure

2022-05-30 Thread Marcel Hamer via lttng-dev
When a channel snapshot creation fails the stream should be cleaned up properly. If the stream is not closed and cleaned properly on a failure, the next time a snapshot is created an assert is triggered for: assert(!stream->trace_chunk); inside the snapshot_channel function. Since the str

Re: [lttng-dev] [PATCH lttng-tools] Fix: cleanup stream on snapshot failure

2022-05-31 Thread Marcel Hamer via lttng-dev
have a clear command sequence to achieve the same error. The proposed patch prevents lttng_consumerd from crashing in step 5. Kind regards, Marcel > > Cheers > > - Original Message - > > From: "Marcel Hamer via lttng-dev" > > To: "lttng-dev"

[lttng-dev] [lttng-tools] Removal of root_regression tests

2022-06-13 Thread Marcel Hamer via lttng-dev
Hello, Since version v2.12.9 of lttng-tools the root_regression file has been emptied to make the tests part of the 'make check' sequence instead. We were always actively using that test file as part of our regression testing. In our case we are working in a cross-compilation environment, where

Re: [lttng-dev] [lttng-tools] Removal of root_regression tests

2022-06-14 Thread Marcel Hamer via lttng-dev
Hello Jonathan, On Mon, Jun 13, 2022 at 11:21:49AM -0400, Jonathan Rajotte-Julien wrote: > [Please note: This e-mail is from an EXTERNAL e-mail address] > > Hi Marcel, > > - Original Message ----- > > From: "Marcel Hamer via lttng-dev" > > To: "l