Re: [lttng-dev] [PATCH lttng-tools v4 2/8] Add Unit test to poll compatibility layer

2019-04-24 Thread Jérémie Galarneau
On Mon, Apr 01, 2019 at 01:59:19PM -0400, Yannick Lamarre wrote: > Signed-off-by: Yannick Lamarre > --- > .gitignore | 1 + > tests/unit/Makefile.am | 9 +- > tests/unit/test_utils_compat_poll.c | 236 > > 3 files cha

Re: [lttng-dev] [PATCH lttng-tools v4 4/8] Adapt poll layer behaviour to match the epoll layer

2019-04-24 Thread Jérémie Galarneau
On Mon, Apr 01, 2019 at 01:59:21PM -0400, Yannick Lamarre wrote: > Signed-off-by: Yannick Lamarre > --- > src/common/compat/compat-poll.c | 30 -- > 1 file changed, 20 insertions(+), 10 deletions(-) > > diff --git a/src/common/compat/compat-poll.c b/src/common/compat/

Re: [lttng-dev] [PATCH lttng-tools v4 6/8] Change lttng_poll_wait behaviour of compat-poll to match compat-epoll

2019-04-24 Thread Jérémie Galarneau
On Mon, Apr 01, 2019 at 01:59:23PM -0400, Yannick Lamarre wrote: > This removes the need to verify for idle file descriptors and mitigates > risks of bug due to behaviour mismatch. > > Signed-off-by: Yannick Lamarre > --- > > The assert in the for loop is removed. > > src/common/compat/compat-