[lttng-dev] [PATCH urcu] Cleanup: missing sign compare fixes

2018-12-19 Thread Michael Jeanson
Signed-off-by: Michael Jeanson --- tests/benchmark/test_perthreadlock.c | 2 +- tests/benchmark/test_urcu_gc.c | 4 ++-- tests/benchmark/test_urcu_qsbr_gc.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/benchmark/test_perthreadlock.c b/tests/benchmark/test

Re: [lttng-dev] [PATCH urcu] Cleanup: missing sign compare fixes

2018-12-19 Thread Mathieu Desnoyers
Merged with modifications. test_perthreadlock compares the iterator against 0 with a decrementing iterator, so we need to work on long. Thanks, Mathieu - On Dec 19, 2018, at 11:44 AM, Michael Jeanson mjean...@efficios.com wrote: > Signed-off-by: Michael Jeanson > --- > tests/benchmark/test

[lttng-dev] [PATCH lttng-tools] Fix: don't start tracing twice for UST applications

2018-12-19 Thread Mathieu Desnoyers
The change introduced by commit 0498a00cbc "Fix: sessiond: don't allocate buffers and files for inactive sessions" adds a ust_app_global_update() for each application without removing the pre-existing ust_app_start_trace(), which effectively attempts to start tracing twice for each application alre

[lttng-dev] tracing multithread user program and API support for enabling/disabling events and for adding/removing context fields

2018-12-19 Thread Yonghong Yan
We are experimenting LTTng for tracing multi-threaded program, it works very well for us. Thank you for having this great tool. But we have some concerns about the overhead and scalability of the tracing. Could you share some insight of the following questions? 1. The session domain communicates wi

[lttng-dev] [PATCH lttng-tools] Fix: session list lock must be held on session put operation

2018-12-19 Thread Jonathan Rajotte
Signed-off-by: Jonathan Rajotte --- src/bin/lttng-sessiond/rotation-thread.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/lttng-sessiond/rotation-thread.c b/src/bin/lttng-sessiond/rotation-thread.c index 8e63e160f..6669372dd 100644 --- a/src/bin/lttng-sessiond/

Re: [lttng-dev] tracing multithread user program and API support for enabling/disabling events and for adding/removing context fields

2018-12-19 Thread Mathieu Desnoyers
Hi Yonghong, - On Dec 19, 2018, at 1:19 PM, Yonghong Yan wrote: > We are experimenting LTTng for tracing multi-threaded program, it works very > well for us. Thank you for having this great tool. But we have some concerns > about the overhead and scalability of the tracing. Could you share

Re: [lttng-dev] tracing multithread user program and API support for enabling/disabling events and for adding/removing context fields

2018-12-19 Thread Yonghong Yan
Mathieu, Thank you for your response. see inline ... On Wed, Dec 19, 2018 at 4:20 PM Mathieu Desnoyers < mathieu.desnoy...@efficios.com> wrote: > Hi Yonghong, > > - On Dec 19, 2018, at 1:19 PM, Yonghong Yan wrote: > > We are experimenting LTTng for tracing multi-threaded program, it works >

Re: [lttng-dev] tracing multithread user program and API support for enabling/disabling events and for adding/removing context fields

2018-12-19 Thread Yonghong Yan
Got another question about lttng_enable_event(): Using this API will impact per-user-thread tracepoint or the whole-user-process? I am thinking of the whole process, but want to confirm. Yonghong On Wed, Dec 19, 2018 at 4:20 PM Mathieu Desnoyers < mathieu.desnoy...@efficios.com> wrote: > Hi Yon