[lttng-dev] [PATCH lttng-tools] Fix: notification thread: RCU-safe reclaim of hash table nodes

Nodes that are put in a rculfhash hash table created with the "auto resize" flag need to beware that a worker thread can access the hash table nodes as a RCU reader concurrently, and that this worker thread can modify the hash table content, effectively adding and removing "bucket" nodes, and chang

[lttng-dev] [PATCH urcu 2/3] Fix: symbol aliases with TLS compat

Signed-off-by: Michael Jeanson --- src/urcu-bp.c| 3 +-- src/urcu-qsbr.c | 3 +-- src/urcu-utils.h | 14 ++ src/urcu.c | 3 +-- 4 files changed, 17 insertions(+), 6 deletions(-) diff --git a/src/urcu-bp.c b/src/urcu-bp.c index 0653f9d..54fda16 100644 --- a/src/urcu-bp.c

[lttng-dev] [PATCH urcu 1/3] Port: no symbols aliases on MacOS

There is no equivalent to symbols aliases on MacOS, this will unfortunatly break the ABI for SONAME(6) and will require a rebuild of client applications. Signed-off-by: Michael Jeanson --- include/urcu/flavor.h| 4 src/urcu-bp.c| 29 +++-- src/urcu-c

[lttng-dev] [PATCH urcu 3/3] Add missing fall through annotations

Signed-off-by: Michael Jeanson --- tests/benchmark/test_urcu_hash.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/benchmark/test_urcu_hash.h b/tests/benchmark/test_urcu_hash.h index 023ae1c..5e84aef 100644 --- a/tests/benchmark/test_urcu_hash.h +++ b/tests/benchma

[lttng-dev] [PATCH lttng-tools 1/2] Fix: notification thread: free session trigger list on error

Signed-off-by: Mathieu Desnoyers --- src/bin/lttng-sessiond/notification-thread-events.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/bin/lttng-sessiond/notification-thread-events.c b/src/bin/lttng-sessiond/notification-thread-events.c index ba4e5a05..3482a7e8 100644 --- a/src/bin/ltt

[lttng-dev] [PATCH lttng-tools 2/2] Fix: handle_notification_thread_command: handle partial read

Use lttng_read() to handle partial reads (returning less than the requested amount of bytes) as well as ret = -1, errno == EINTR. Signed-off-by: Mathieu Desnoyers --- src/bin/lttng-sessiond/notification-thread-events.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/b

[lttng-dev] [PATCH urcu] Fix: examples silent rules on Solaris

Signed-off-by: Michael Jeanson --- doc/examples/Makefile.examples.template | 6 -- doc/examples/dist-files/Makefile| 2 +- doc/examples/hlist/Makefile | 2 +- doc/examples/wfcqueue/Makefile | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/doc

[lttng-dev] [PATCH lttng-ust] Add hello-many to gitignore

Signed-off-by: Michael Jeanson --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 11cf3343..482c6520 100644 --- a/.gitignore +++ b/.gitignore @@ -66,6 +66,7 @@ doc/man/tracef.3 doc/man/tracelog.3 tests/hello/hello +tests/hello-many/hello-many tes

[lttng-dev] [PATCH lttng-tools] Fix: do not repurpose iterator while it is being used

The hash table iteration uses an iterator that needs to stay valid for the next loop. Using that same iterator variable in a nested lookup in a different hash table leads to segmentation fault. Signed-off-by: Mathieu Desnoyers --- src/bin/lttng-sessiond/notification-thread-events.c | 5 +++-- 1

[lttng-dev] [PATCH lttng-tools 2.10] Fix: do not repurpose iterator while it is being used (register trigger, 2.10)

The hash table iteration uses an iterator that needs to stay valid for the next loop. Using that same iterator variable in a nested lookup in a different hash table leads to segmentation fault. This is a 2.10-specific instance of the issue affecting bind_trigger_to_matching_channels() which was fo

Re: [lttng-dev] [PATCH urcu 1/3] Port: no symbols aliases on MacOS

All 3 patches merged, thanks! Mathieu - On Dec 12, 2018, at 3:01 PM, Michael Jeanson mjean...@efficios.com wrote: > There is no equivalent to symbols aliases on MacOS, this will > unfortunatly break the ABI for SONAME(6) and will require a rebuild of > client applications. > > Signed-off-by

Re: [lttng-dev] [PATCH urcu] Fix: examples silent rules on Solaris

Merged, thanks! Mathieu - On Dec 12, 2018, at 3:30 PM, Michael Jeanson mjean...@efficios.com wrote: > Signed-off-by: Michael Jeanson > --- > doc/examples/Makefile.examples.template | 6 -- > doc/examples/dist-files/Makefile| 2 +- > doc/examples/hlist/Makefile | 2 +- >

Re: [lttng-dev] [PATCH lttng-ust] Add hello-many to gitignore

Merged, thanks! Mathieu - On Dec 12, 2018, at 4:41 PM, Michael Jeanson mjean...@efficios.com wrote: > Signed-off-by: Michael Jeanson > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 11cf3343..482c6520 100644 > --- a/.gitignore > +++