Re: [lttng-dev] lost trace events

> A custom trace event class emits "begin" and "end" events in its > constructor and destructor respectively. So I do not think this is due to > conditional path. If you can guarantee that the destructor is called, seems good to me. Do you see scenario where the "begin" event is missing ? > > S

Re: [lttng-dev] lost trace events

Hi Alok, With a snapshot trace, you can end up with some per-cpu buffers that contain information going further back in time compared to other per-cpu buffers. This depends on the level of system activity and tracing throughput for each CPU. The situation you experience can very well be tri

[lttng-dev] [PATCH lttng-modules] RFC: Drop support for kernels < 3.0

Signed-off-by: Michael Jeanson --- README.md | 2 +- instrumentation/events/lttng-module/block.h | 89 +-- instrumentation/events/lttng-module/ext4.h| 179 +- instrumentation/events/lttng-module/irq.h | 64 -- instrumentation/events/lttng-modu

Re: [lttng-dev] [PATCH lttng-modules] RFC: Drop support for kernels < 3.0

- On Nov 8, 2018, at 3:03 PM, Michael Jeanson mjean...@efficios.com wrote: Hi Michael, Can you split this patch as follows ? - One patch updating README.md. - Individual patches removing older kernel ifdefs for instrumentation, per subsystem. - Individual patches removing each old wrapper

Re: [lttng-dev] [PATCH lttng-modules] RFC: Drop support for kernels < 3.0

On 2018-11-08 3:15 p.m., Mathieu Desnoyers wrote: > - On Nov 8, 2018, at 3:03 PM, Michael Jeanson mjean...@efficios.com wrote: > > Hi Michael, > > Can you split this patch as follows ? > > - One patch updating README.md. > > - Individual patches removing older kernel ifdefs for instrumentat

[lttng-dev] [RFC PATCH lttng-modules v2 02/30] Drop compat patches for kernels < 2.6.36

Signed-off-by: Michael Jeanson --- .../backport-kallsym-sym-2.6.32.patch | 37 -- .../backport-splice-sym-2.6.32-34.patch | 71 --- .../backport-tp-2.6.34-tracepoint-data.patch | 559 -- .../backport-tracepoint-data-2.6.32-33.patch | 555 - 4 file

[lttng-dev] [RFC PATCH lttng-modules v2 01/30] Bump minimum kernel version to 3.0

Upstream Linux 3.0 was released 7 years ago, the oldest longterm release still supported is 3.16. On the distro kernels side, we still cover : RHEL / CentOS 7 and up SLES11 SP2 and up SLES12 and up Ubuntu 12.04 (Precise) and up Debian 7 (Wheezy) and up Fedora 16 and up Signed-off-by: Michae

[lttng-dev] [RFC PATCH lttng-modules v2 04/30] Drop support for kernels < 3.0 from perf.h wrapper

Signed-off-by: Michael Jeanson --- wrapper/perf.h | 25 - 1 file changed, 25 deletions(-) diff --git a/wrapper/perf.h b/wrapper/perf.h index 48e256c..4a7f6d8 100644 --- a/wrapper/perf.h +++ b/wrapper/perf.h @@ -22,8 +22,6 @@ wrapper_perf_event_create_kernel_counter(struct

[lttng-dev] [RFC PATCH lttng-modules v2 03/30] Drop support for kernels < 3.0 from atomic.h wrapper

Signed-off-by: Michael Jeanson --- wrapper/atomic.h | 4 1 file changed, 4 deletions(-) diff --git a/wrapper/atomic.h b/wrapper/atomic.h index 51920c4..5ead899 100644 --- a/wrapper/atomic.h +++ b/wrapper/atomic.h @@ -11,11 +11,7 @@ #define _LTTNG_WRAPPER_ATOMIC_H #include -#if (LINUX_V

[lttng-dev] [RFC PATCH lttng-modules v2 06/30] Drop vzalloc.h wrapper

Signed-off-by: Michael Jeanson --- lttng-events.c| 5 ++--- wrapper/vzalloc.h | 34 -- 2 files changed, 2 insertions(+), 37 deletions(-) delete mode 100644 wrapper/vzalloc.h diff --git a/lttng-events.c b/lttng-events.c index f1be602..e3a8425 100644 --- a/ltt

[lttng-dev] [RFC PATCH lttng-modules v2 08/30] Drop kstrtox.h wrapper

Signed-off-by: Michael Jeanson --- tests/probes/lttng-test.c | 3 +-- wrapper/kstrtox.h | 47 --- 2 files changed, 1 insertion(+), 49 deletions(-) delete mode 100644 wrapper/kstrtox.h diff --git a/tests/probes/lttng-test.c b/tests/probes/lttng-test.c

[lttng-dev] [RFC PATCH lttng-modules v2 07/30] Drop uuid.h wrapper

Signed-off-by: Michael Jeanson --- lttng-events.c | 2 +- lttng-events.h | 2 +- wrapper/uuid.h | 30 -- 3 files changed, 2 insertions(+), 32 deletions(-) delete mode 100644 wrapper/uuid.h diff --git a/lttng-events.c b/lttng-events.c index e3a8425..566080a 100644 -

[lttng-dev] [RFC PATCH lttng-modules v2 05/30] Drop support for kernels < 3.0 from tracepoint.h wrapper

Signed-off-by: Michael Jeanson --- wrapper/tracepoint.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/wrapper/tracepoint.h b/wrapper/tracepoint.h index 0c5a296..6ee4217 100644 --- a/wrapper/tracepoint.h +++ b/wrapper/tracepoint.h @@ -14,12 +14,6 @@ #include #include -#if (LINUX_V

[lttng-dev] [RFC PATCH lttng-modules v2 10/30] Drop support for kernels < 3.0 from lib

Signed-off-by: Michael Jeanson --- lib/bug.h | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lib/bug.h b/lib/bug.h index 8ddf2b0..0f3b30b 100644 --- a/lib/bug.h +++ b/lib/bug.h @@ -8,14 +8,6 @@ #ifndef _LTTNG_BUG_H #define _LTTNG_BUG_H -#include - -#if (LINUX_VE

[lttng-dev] [RFC PATCH lttng-modules v2 09/30] Drop spinlock.h wrapper

Signed-off-by: Michael Jeanson --- lib/ringbuffer/frontend_types.h | 1 - lttng-statedump-impl.c | 5 ++--- wrapper/spinlock.h | 34 - 3 files changed, 2 insertions(+), 38 deletions(-) delete mode 100644 wrapper/spinlock.h diff --git a/lib

[lttng-dev] [RFC PATCH lttng-modules v2 11/30] Drop support for kernels < 3.0 from lttng-events.h

Signed-off-by: Michael Jeanson --- lttng-events.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lttng-events.h b/lttng-events.h index f62e0cb..1903706 100644 --- a/lttng-events.h +++ b/lttng-events.h @@ -716,7 +716,7 @@ int lttng_add_migratable_to_ctx(struct lttng_ctx **c

[lttng-dev] [RFC PATCH lttng-modules v2 13/30] Drop support for kernels < 3.0 from lttng-statedump-impl.c

Signed-off-by: Michael Jeanson --- lttng-statedump-impl.c | 4 1 file changed, 4 deletions(-) diff --git a/lttng-statedump-impl.c b/lttng-statedump-impl.c index 8ce50c0..dc03750 100644 --- a/lttng-statedump-impl.c +++ b/lttng-statedump-impl.c @@ -353,10 +353,6 @@ int lttng_enumerate_vm_maps

[lttng-dev] [RFC PATCH lttng-modules v2 12/30] Drop support for kernels < 3.0 from lttng-kernel-version.h

Signed-off-by: Michael Jeanson --- lttng-kernel-version.h | 5 - 1 file changed, 5 deletions(-) diff --git a/lttng-kernel-version.h b/lttng-kernel-version.h index 6b545db..26f816c 100644 --- a/lttng-kernel-version.h +++ b/lttng-kernel-version.h @@ -11,12 +11,7 @@ #define _LTTNG_KERNEL_VERSI

[lttng-dev] [RFC PATCH lttng-modules v2 14/30] Drop support for kernels < 3.0 from block instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/block.h | 89 + 1 file changed, 1 insertion(+), 88 deletions(-) diff --git a/instrumentation/events/lttng-module/block.h b/instrumentation/events/lttng-module/block.h index e7e9449..9f77526 100644 --- a/i

[lttng-dev] [RFC PATCH lttng-modules v2 16/30] Drop support for kernels < 3.0 from irq instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/irq.h | 64 --- 1 file changed, 64 deletions(-) diff --git a/instrumentation/events/lttng-module/irq.h b/instrumentation/events/lttng-module/irq.h index 6f66a5e..71553e6 100644 --- a/instrumentation/event

[lttng-dev] [RFC PATCH lttng-modules v2 17/30] Drop support for kernels < 3.0 from jbd2 instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/jbd2.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/instrumentation/events/lttng-module/jbd2.h b/instrumentation/events/lttng-module/jbd2.h index 10e3073..a760da2 100644 --- a/instrumentation/events/lttng-module/j

[lttng-dev] [RFC PATCH lttng-modules v2 15/30] Drop support for kernels < 3.0 from ext4 instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/ext4.h | 179 ++--- 1 file changed, 15 insertions(+), 164 deletions(-) diff --git a/instrumentation/events/lttng-module/ext4.h b/instrumentation/events/lttng-module/ext4.h index 307021a..b2ca8a7 100644 --- a/

[lttng-dev] [RFC PATCH lttng-modules v2 19/30] Drop support for kernels < 3.0 from kvm instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/kvm.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/instrumentation/events/lttng-module/kvm.h b/instrumentation/events/lttng-module/kvm.h index 62030fc..4868d89 100644 --- a/instrumentation/events/lttng-modul

[lttng-dev] [RFC PATCH lttng-modules v2 20/30] Drop support for kernels < 3.0 from lock instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/lock.h | 71 +- probes/lttng-probe-lock.c | 5 -- 2 files changed, 2 insertions(+), 74 deletions(-) diff --git a/instrumentation/events/lttng-module/lock.h b/instrumentation/events/lttng

[lttng-dev] [RFC PATCH lttng-modules v2 21/30] Drop support for kernels < 3.0 from mm_vmscan instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/mm_vmscan.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/instrumentation/events/lttng-module/mm_vmscan.h b/instrumentation/events/lttng-module/mm_vmscan.h index b9cd8b0..cc7a275 100644 --- a/instrumenta

[lttng-dev] [RFC PATCH lttng-modules v2 18/30] Drop support for kernels < 3.0 from kmem instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/kmem.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/instrumentation/events/lttng-module/kmem.h b/instrumentation/events/lttng-module/kmem.h index 8270fce..2313ae8 100644 --- a/instrumentation/events/lttng-module/

[lttng-dev] [RFC PATCH lttng-modules v2 22/30] Drop support for kernels < 3.0 from module instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/module.h | 22 +--- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/instrumentation/events/lttng-module/module.h b/instrumentation/events/lttng-module/module.h index febe8d2..89b1e79 100644 --- a

[lttng-dev] [RFC PATCH lttng-modules v2 24/30] Drop support for kernels < 3.0 from power instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/power.h | 40 - 1 file changed, 40 deletions(-) diff --git a/instrumentation/events/lttng-module/power.h b/instrumentation/events/lttng-module/power.h index 2146a37..fee6f5f 100644 --- a/instrumentation/e

[lttng-dev] [RFC PATCH lttng-modules v2 23/30] Drop support for kernels < 3.0 from net instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/net.h | 12 1 file changed, 12 deletions(-) diff --git a/instrumentation/events/lttng-module/net.h b/instrumentation/events/lttng-module/net.h index 8789263..bfa14fc 100644 --- a/instrumentation/events/lttng-mod

[lttng-dev] [RFC PATCH lttng-modules v2 25/30] Drop support for kernels < 3.0 from sched instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/sched.h | 68 +++-- 1 file changed, 7 insertions(+), 61 deletions(-) diff --git a/instrumentation/events/lttng-module/sched.h b/instrumentation/events/lttng-module/sched.h index 550ce2f..77d77b2 100644 --- a/

[lttng-dev] [RFC PATCH lttng-modules v2 26/30] Drop support for kernels < 3.0 from scsi instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/scsi.h | 8 1 file changed, 8 deletions(-) diff --git a/instrumentation/events/lttng-module/scsi.h b/instrumentation/events/lttng-module/scsi.h index 97ee050..7882def 100644 --- a/instrumentation/events/lttng-module

[lttng-dev] [RFC PATCH lttng-modules v2 29/30] Drop support for kernels < 3.0 from writeback instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/writeback.h | 4 1 file changed, 4 deletions(-) diff --git a/instrumentation/events/lttng-module/writeback.h b/instrumentation/events/lttng-module/writeback.h index 3327a0f..feef945 100644 --- a/instrumentation/events/l

[lttng-dev] [RFC PATCH lttng-modules v2 28/30] Drop support for kernels < 3.0 from workqueue instrumentation

Signed-off-by: Michael Jeanson --- .../events/lttng-module/workqueue.h | 61 --- 1 file changed, 61 deletions(-) diff --git a/instrumentation/events/lttng-module/workqueue.h b/instrumentation/events/lttng-module/workqueue.h index 07d6a53..e0ef917 100644 --- a/instrumen

[lttng-dev] [RFC PATCH lttng-modules v2 27/30] Drop support for kernels < 3.0 from skb instrumentation

Signed-off-by: Michael Jeanson --- instrumentation/events/lttng-module/skb.h | 4 1 file changed, 4 deletions(-) diff --git a/instrumentation/events/lttng-module/skb.h b/instrumentation/events/lttng-module/skb.h index 6d3fd45..1726b44 100644 --- a/instrumentation/events/lttng-module/skb.h

[lttng-dev] [RFC PATCH lttng-modules v2 30/30] Drop support for kernels < 3.0 from Makefiles

Signed-off-by: Michael Jeanson --- Makefile | 5 +--- probes/Kbuild | 73 +-- 2 files changed, 19 insertions(+), 59 deletions(-) diff --git a/Makefile b/Makefile index ae2b195..c7b8a41 100644 --- a/Makefile +++ b/Makefile @@ -66,10 +66,7 @@ i

Re: [lttng-dev] [RFC PATCH lttng-modules v2 01/30] Bump minimum kernel version to 3.0

On 2018-11-08 4:45 p.m., Michael Jeanson wrote: > Upstream Linux 3.0 was released 7 years ago, the oldest longterm release > still supported is 3.16. On the distro kernels side, we still cover : > > RHEL / CentOS 7 and up > SLES11 SP2 and up > SLES12 and up > Ubuntu 12.04 (Precise) and up > D

Re: [lttng-dev] [RFC PATCH lttng-modules v2 01/30] Bump minimum kernel version to 3.0

- On Nov 8, 2018, at 4:59 PM, Michael Jeanson mjean...@efficios.com wrote: > On 2018-11-08 4:45 p.m., Michael Jeanson wrote: >> Upstream Linux 3.0 was released 7 years ago, the oldest longterm release >> still supported is 3.16. On the distro kernels side, we still cover : >> >> RHEL / Cen

[lttng-dev] [PATCH lttng-tools] Fix: nsec diff can be negative leading to expeditive connection timeout

The nanoseconds part of the timespec struct time_a is not always bigger than time_b since it wrap around each seconds. Use the absolute value of the nanosecond difference to perform unsigned long operation. Signed-off-by: Jonathan Rajotte --- src/common/sessiond-comm/inet.c | 2 +- src/common/

Re: [lttng-dev] [RFC PATCH lttng-modules v2 01/30] Bump minimum kernel version to 3.0

On 2018-11-08 5:05 p.m., Mathieu Desnoyers wrote: > > - On Nov 8, 2018, at 4:59 PM, Michael Jeanson mjean...@efficios.com wrote: > >> On 2018-11-08 4:45 p.m., Michael Jeanson wrote: >>> Upstream Linux 3.0 was released 7 years ago, the oldest longterm release >>> still supported is 3.16. On th

[lttng-dev] [PATCH lttng-modules] Add missing SPDX license identifiers to uprobes

Signed-off-by: Michael Jeanson --- probes/lttng-uprobes.c | 3 ++- wrapper/uprobes.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/probes/lttng-uprobes.c b/probes/lttng-uprobes.c index bcdbbd8..76023fb 100644 --- a/probes/lttng-uprobes.c +++ b/probes/lttng-uprobes.c @@

Re: [lttng-dev] [PATCH lttng-tools] Fix: nsec diff can be negative leading to expeditive connection timeout

On 2018-11-08 17:08, Jonathan Rajotte wrote: The nanoseconds part of the timespec struct time_a is not always bigger than time_b since it wrap around each seconds. Use the absolute value of the nanosecond difference to perform unsigned long operation. Signed-off-by: Jonathan Rajotte --- src/c

Re: [lttng-dev] [PATCH lttng-tools] Fix: nsec diff can be negative leading to expeditive connection timeout

On 2018-11-08 17:17, Simon Marchi wrote: On 2018-11-08 17:08, Jonathan Rajotte wrote: The nanoseconds part of the timespec struct time_a is not always bigger than time_b since it wrap around each seconds. Use the absolute value of the nanosecond difference to perform unsigned long operation. S

Re: [lttng-dev] [PATCH lttng-tools] Fix: nsec diff can be negative leading to expeditive connection timeout

You are right...Might have been looking to long at logs all day. Thanks for pointing it out. Will send v2 shortly. On Thu, Nov 08, 2018 at 05:26:39PM -0500, Simon Marchi wrote: > On 2018-11-08 17:17, Simon Marchi wrote: > > On 2018-11-08 17:08, Jonathan Rajotte wrote: > > > The nanoseconds part

Re: [lttng-dev] lost trace events

Jonathan: The system is x86_64, 16 cores, no cpu affinity set. Not too sure about load yet. Mathieu: The explanation makes sense. Running babeltrace with --stream-intersection flag did filter out a lot of events. However it is hard to verify the filtered result because we do not yet know how to re

[lttng-dev] [PATCH lttng-modules v2] Add missing SPDX license identifiers to uprobes

Signed-off-by: Michael Jeanson --- probes/lttng-uprobes.c | 16 ++-- wrapper/uprobes.h | 22 +- 2 files changed, 7 insertions(+), 31 deletions(-) diff --git a/probes/lttng-uprobes.c b/probes/lttng-uprobes.c index bcdbbd8..64d8237 100644 --- a/probes/lttng-upr

Re: [lttng-dev] lost trace events

On Thu, 8 Nov 2018 at 18:31, Alok Priyadarshi wrote: > > Jonathan: The system is x86_64, 16 cores, no cpu affinity set. Not too sure > about load yet. > > Mathieu: The explanation makes sense. Running babeltrace with > --stream-intersection flag did filter out a lot of events. However it is hard

Re: [lttng-dev] [PATCH lttng-modules v2] Add missing SPDX license identifiers to uprobes

Merged, thanks! Mathieu - On Nov 8, 2018, at 6:37 PM, Michael Jeanson mjean...@efficios.com wrote: > Signed-off-by: Michael Jeanson > --- > probes/lttng-uprobes.c | 16 ++-- > wrapper/uprobes.h | 22 +- > 2 files changed, 7 insertions(+), 31 deletions(-) >

Re: [lttng-dev] [RFC PATCH lttng-modules v2 01/30] Bump minimum kernel version to 3.0

Merged, thanks! Mathieu - On Nov 8, 2018, at 5:09 PM, Michael Jeanson mjean...@efficios.com wrote: > On 2018-11-08 5:05 p.m., Mathieu Desnoyers wrote: >> >> - On Nov 8, 2018, at 4:59 PM, Michael Jeanson mjean...@efficios.com >> wrote: >> >>> On 2018-11-08 4:45 p.m., Michael Jeanson wr

Re: [lttng-dev] lost trace events

Awesome, I tried the intersect_mode parameter and it worked. No more lost events. Thanks for your support. On Thu, Nov 8, 2018 at 3:44 PM Jérémie Galarneau < jeremie.galarn...@efficios.com> wrote: > On Thu, 8 Nov 2018 at 18:31, Alok Priyadarshi wrote: > > > > Jonathan: The system is x86_64, 16 c