Re: [lttng-dev] [PATCH lttng-tools] Fix: double put on error path

Merged in master, stable-2.11, stable-2.10, and stable-2.9. Thanks! Jérémie On Mon, Sep 10, 2018 at 08:09:11PM -0400, Jonathan Rajotte wrote: > Let relay_index_try_flush be responsible for the self-reference put on > error path. > > Code flow of relay_index_try_flush is a bit tricky but the onl

Re: [lttng-dev] [PATCH lttng-tools] Perform local data pending before checking data pending with relayd

Merged in master, stable-2.11, stable-2.10, and stable-2.9. Thanks, Jérémie On Mon, Sep 10, 2018 at 08:09:15PM -0400, Jonathan Rajotte wrote: > Performing the data pending check in two phases, local and network, > reduce the total number network operation needed. > > Doing the local check first

Re: [lttng-dev] [PATCH lttng-tools] Fix: Holding the stream lock does not equate to having data pending

Merged in master, stable-2.11, stable-2.10, and stable-2.9. Thanks, Jérémie On Mon, Sep 10, 2018 at 08:09:14PM -0400, Jonathan Rajotte wrote: > The live timer can hold the stream lock while sending empty beacon. An empty > beacon > does not mean that data is still pending for the stream. > > Si

Re: [lttng-dev] [PATCH lttng-tools] Fix: Skip uid registry when metadata key is 0

Merged in master, stable-2.11, stable-2.10, and stable-2.9. Thanks, Jérémie On Mon, Sep 10, 2018 at 08:09:13PM -0400, Jonathan Rajotte wrote: > A value of zero for the metadata key indicate that metadata was never > created/pushed to the consumer. > > This can occur in scenario were a tracker is

Re: [lttng-dev] [PATCH lttng-tools 1/2] Fix: use LTTNG_VIEWER_ATTACH_UNK to report a closed session

Merged in master, stable-2.11, stable-2.10, and stable-2.9. Thanks, Jérémie On Fri, Sep 07, 2018 at 03:18:37PM -0400, Jonathan Rajotte wrote: > LTTNG_VIEWER_NEW_STREAMS_HUP is not a valid error number for the > LTTNG_VIEWER_ATTACH_SESSION command. This result in erroneous error > reporting on the

Re: [lttng-dev] [PATCH lttng-tools] Fix: acquire stream lock during kernel metadata snapshot

Merged in master, stable-2.11, stable-2.10, and stable-2.9. Thanks, Jérémie On Mon, Sep 10, 2018 at 08:09:12PM -0400, Jonathan Rajotte wrote: > From: Jérémie Galarneau > > The stream lock is not taken when interacting with the kernel > metadata stream that is created at the time a snapshot is t

Re: [lttng-dev] [PATCH lttng-tools 2/2] Skip closed session on viewer listing

Merged in master, stable-2.11, stable-2.10, and stable-2.9. Thanks, Jérémie On Fri, Sep 07, 2018 at 03:18:38PM -0400, Jonathan Rajotte wrote: > There is no value in listing a closed session. A viewer cannot hook itself > to a closed session in live mode and the session is about to be removed from

[lttng-dev] [PATCH lttng-modules] Fix: access migrate_disable field directly

For stable real time kernel > 4.9, the __migrate_disabled utility symbol is not always exported. This can result in linking problem at build time and runtime, preventing the loading of the tracer. The problem was reported to the RT community. [1] [2] A solution is to access the field directly ins

Re: [lttng-dev] Lttng-modules-2.10.x builds with warning of undefined "__migrate_disabled" with RT Kernels >= 4.14

Hi Srikanth, We were able to reproduce the problem. We are still not sure why our CI did not catch this. We will investigate and fix it. In the mean time, please try this patch [1]. Also for more details regarding our current analysis of what happened please read this thread from the RT mailing