Re: [lttng-dev] [PATCH lttng-tools 1/3] Fix: relayd: make viewer streams consider metadata sent

2015-09-05 Thread Jérémie Galarneau
Merged, thanks! Jérémie On Thu, Sep 3, 2015 at 5:17 PM, Mathieu Desnoyers wrote: > The metadata stream does not use prev seq, and is therefore not sent to > viewers if we depend on prev seq. Use the metadata_received field > instead to achieve the same purpose: if a viewer try to attach to a > s

Re: [lttng-dev] [PATCH lttng-tools 2/3] Fix: relay: viewer_get_next_index handle null vstream

2015-09-05 Thread Jérémie Galarneau
Merged, thanks! Jérémie On Thu, Sep 3, 2015 at 5:17 PM, Mathieu Desnoyers wrote: > Signed-off-by: Mathieu Desnoyers > --- > src/bin/lttng-relayd/live.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/bin/lttng-relayd/live.c b/src/bin/lttng-relayd/live.c > i

Re: [lttng-dev] [PATCH lttng-tools 3/3] Fix: relayd: file rotation and live read

2015-09-05 Thread Jérémie Galarneau
Merged, thanks! Jérémie On Thu, Sep 3, 2015 at 5:17 PM, Mathieu Desnoyers wrote: > Signed-off-by: Mathieu Desnoyers > --- > src/bin/lttng-relayd/Makefile.am | 3 +- > src/bin/lttng-relayd/live.c| 89 +++--- > src/bin/lttng-relayd/main.c| 39 ---

Re: [lttng-dev] [PATCH lttng-tools v2] Fix: Python agent tests were always skipped

2015-09-05 Thread Jérémie Galarneau
Merged with some minor modifications, see below. Thanks! Jérémie On Mon, Aug 24, 2015 at 11:08 AM, Jonathan Rajotte wrote: > v2: Change the configure report section to emulate the java ust agent test > reporting. > > Introduce --enable-test-python{2,3}-agent and --enable-test-python-agent-all >

Re: [lttng-dev] [PATCH lttng-tools] Fix: kernel track/untrack error handling

2015-09-05 Thread Jérémie Galarneau
Merged, thanks! While testing/reviewing this fix, I noticed that untracking a user space PID before enabling one (leaving the ust session pid_tracker uninitialized) would result in an "Invalid parameter" error being returned to the client (see bug #931). The following commit addresses the problem

Re: [lttng-dev] [PATCH lttng-tools] Fix: put viewer stream on send error

2015-09-05 Thread Jérémie Galarneau
Squashed into "Fix: Relay daemon ownership and reference counting". Thanks! Jérémie On Fri, Sep 4, 2015 at 12:03 PM, Mathieu Desnoyers wrote: > Signed-off-by: Mathieu Desnoyers > --- > src/bin/lttng-relayd/live.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/bin/

Re: [lttng-dev] [PATCH lttng-tools] Fix: unpublish stream on close

2015-09-05 Thread Jérémie Galarneau
Squashed into "Fix: Relay daemon ownership and reference counting" with some comment changes. Read on. Thanks! Jérémie On Fri, Sep 4, 2015 at 3:44 PM, Mathieu Desnoyers wrote: > Fixes race where data connection can still add indexes after close, > preventing graceful teardown of the stream. > >

Re: [lttng-dev] [PATCH lttng-tools 1/2] Fix: lttng-crash: fd leak

2015-09-05 Thread Jérémie Galarneau
Merged with modifications. While this does correct the leak in the common case, it will also leak when the "error" label is jumped to or close an uninitialized file descriptor. The edited version I have merged takes care of both issues. Thanks! Jérémie On Thu, Sep 3, 2015 at 5:52 PM, Jonathan Ra

Re: [lttng-dev] [PATCH lttng-tools 2/2] Fix: lttng-crash: remove tmp working directory

2015-09-05 Thread Jérémie Galarneau
Merged with modifications, see below. Thanks! Jérémie On Thu, Sep 3, 2015 at 5:52 PM, Jonathan Rajotte wrote: > Signed-off-by: Jonathan Rajotte > --- > src/bin/lttng-crash/lttng-crash.c | 65 > +-- > 1 file changed, 48 insertions(+), 17 deletions(-) > > dif

Re: [lttng-dev] [PATCH lttng-tools v2] Fix: race between kconsumerd and sessiond on tear down

2015-09-05 Thread Jérémie Galarneau
Merged, thanks! Jérémie On Thu, Sep 3, 2015 at 5:48 PM, Jonathan Rajotte wrote: > v2: minimize indentation by using return on condition. > > Kconsumerd and sessiond both have reference on lttng-module. This can lead to > a race > on modprobe_remove_lttng_all which might fail to unload modules d

Re: [lttng-dev] [PATCH lttng-tools v2] Fix: use pid element instead of process element

2015-09-05 Thread Jérémie Galarneau
On Fri, Sep 4, 2015 at 6:02 PM, Jonathan Rajotte wrote: > v2: Include change to xsd. Looks like I forgot to squash it. I'll have to make > an offering to the git reflog god on this one. Haha, I'm probably due for one too ;-) Merged, although I have removed the now-unused types process_type and p

Re: [lttng-dev] [PATCH lttng-tools 2/2] Test kernel wildcards

2015-09-05 Thread Jérémie Galarneau
This test hangs here on the latest lttng-modules (89406ecda) and Linux 4.1.6. $ sudo ./tests/regression/tools/wildcard/test_event_wildcard 1..76 # LTTng - Event wildcard test ok 1 - Start session daemon # Test UST wildcard ok 2 - Create session wildcard in /tmp/tmp.bMYvA8LmhA ok 3 - Enable event t

Re: [lttng-dev] [PATCH lttng-tools v2] Fix: use pid element instead of process element

2015-09-05 Thread Jonathan Rajotte
Looks good thanks On Sat, Sep 5, 2015 at 4:26 PM, Jérémie Galarneau < jeremie.galarn...@efficios.com> wrote: > On Fri, Sep 4, 2015 at 6:02 PM, Jonathan Rajotte > wrote: > > v2: Include change to xsd. Looks like I forgot to squash it. I'll have > to make > > an offering to the git reflog god on t

[lttng-dev] [PATCH lttng-tools] Fix: consumer signal handling race

2015-09-05 Thread Mathieu Desnoyers
If a signal comes in after ctx has been destroyed, it will try to use a closed file descriptor. Signed-off-by: Mathieu Desnoyers --- src/bin/lttng-consumerd/lttng-consumerd.c | 10 -- src/bin/lttng-sessiond/main.c | 1 - 2 files changed, 8 insertions(+), 3 deletions(-) diff