Re: [lttng-dev] Unexport of kvm_x86_ops vs tracer modules

2022-04-25 Thread Paolo Bonzini via lttng-dev
On 4/25/22 18:02, Mathieu Desnoyers wrote: Now another solution is to make the fast assigns available to anyone, and to allow you to simply pass in a pointer and size to have the data written into it. That is, you get the results of the TRACE_EVENT and not have to depend on internal data from the

Re: [lttng-dev] Unexport of kvm_x86_ops vs tracer modules

2022-04-25 Thread Steven Rostedt via lttng-dev
On Mon, 25 Apr 2022 12:02:52 -0400 (EDT) Mathieu Desnoyers wrote: > If the fast assign can then be used on a field-per-field basis, maybe this > could work, but AFAIK the fast-assign macro is open-coded C, which makes this > not straightforward. Yeah, that's not going to be feasible, without cha

Re: [lttng-dev] Unexport of kvm_x86_ops vs tracer modules

2022-04-25 Thread Mathieu Desnoyers via lttng-dev
- On Apr 25, 2022, at 10:04 AM, Steven Rostedt rost...@goodmis.org wrote: > On Fri, 8 Apr 2022 14:06:53 -0400 (EDT) > Mathieu Desnoyers wrote: >> >> Indeed, the fact that the TP_fast_assign snippets are embedded in the >> trace_event_raw_event_* symbols is an issue for LTTng. This ties those

Re: [lttng-dev] Unexport of kvm_x86_ops vs tracer modules

2022-04-25 Thread Steven Rostedt via lttng-dev
On Fri, 8 Apr 2022 14:06:53 -0400 (EDT) Mathieu Desnoyers wrote: > > Indeed, the fact that the TP_fast_assign snippets are embedded in the > trace_event_raw_event_* symbols is an issue for LTTng. This ties those > to ftrace. Not just ftrace, perf does it too. Now another solution is to make the

Re: [lttng-dev] Unexport of kvm_x86_ops vs tracer modules

2022-04-25 Thread Paolo Bonzini via lttng-dev
On 4/25/22 15:00, Mathieu Desnoyers wrote: We are at 5.18-rc4 now. Should I expect this unexport to stay in place for 5.18 final and go ahead with using kallsyms to find this symbol from lttng-modules instead ? Yes, I don't think honestly that there's any reason to have the symbols in place fo

Re: [lttng-dev] Unexport of kvm_x86_ops vs tracer modules

2022-04-25 Thread Mathieu Desnoyers via lttng-dev
- On Apr 8, 2022, at 2:06 PM, Mathieu Desnoyers via lttng-dev lttng-dev@lists.lttng.org wrote: > - On Apr 8, 2022, at 12:24 PM, Paolo Bonzini pbonz...@redhat.com wrote: > >> On 4/8/22 17:36, Mathieu Desnoyers wrote: >>> LTTng is an out of tree kernel module, which currently relies on the

Re: [lttng-dev] Unexport of kvm_x86_ops vs tracer modules

2022-04-08 Thread Mathieu Desnoyers via lttng-dev
- On Apr 8, 2022, at 12:24 PM, Paolo Bonzini pbonz...@redhat.com wrote: > On 4/8/22 17:36, Mathieu Desnoyers wrote: >> LTTng is an out of tree kernel module, which currently relies on the export. >> Indeed, arch/x86/kvm/x86.c exports a set of tracepoints to kernel modules, >> e.g.: >> >> EXP

Re: [lttng-dev] Unexport of kvm_x86_ops vs tracer modules

2022-04-08 Thread Paolo Bonzini via lttng-dev
On 4/8/22 17:36, Mathieu Desnoyers wrote: LTTng is an out of tree kernel module, which currently relies on the export. Indeed, arch/x86/kvm/x86.c exports a set of tracepoints to kernel modules, e.g.: EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_entry) But any probe implementation hooking on that tracepoint