Re: [lttng-dev] [PATCH lttng-tools] Fix: cleanup stream on snapshot failure

2022-05-31 Thread Jonathan Rajotte-Julien via lttng-dev
"lttng-dev" > Sent: Tuesday, May 31, 2022 7:28:55 AM > Subject: Re: [lttng-dev] [PATCH lttng-tools] Fix: cleanup stream on snapshot > failure > Hello Jonathan, > > On Mon, May 30, 2022 at 11:27:55AM -0400, Jonathan Rajotte-Julien wrote: >> [Please no

Re: [lttng-dev] [PATCH lttng-tools] Fix: cleanup stream on snapshot failure

2022-05-31 Thread Marcel Hamer via lttng-dev
; > > Sent: Monday, 30 May, 2022 10:10:21 > > Subject: [lttng-dev] [PATCH lttng-tools] Fix: cleanup stream on snapshot > > failure > > > When a channel snapshot creation fails the stream should be cleaned up > > properly. If the stream is not c

Re: [lttng-dev] [PATCH lttng-tools] Fix: cleanup stream on snapshot failure

2022-05-30 Thread Jonathan Rajotte-Julien via lttng-dev
ttng-dev" > To: "lttng-dev" > Sent: Monday, 30 May, 2022 10:10:21 > Subject: [lttng-dev] [PATCH lttng-tools] Fix: cleanup stream on snapshot > failure > When a channel snapshot creation fails the stream should be cleaned up > properly. If the stream is not closed

[lttng-dev] [PATCH lttng-tools] Fix: cleanup stream on snapshot failure

2022-05-30 Thread Marcel Hamer via lttng-dev
When a channel snapshot creation fails the stream should be cleaned up properly. If the stream is not closed and cleaned properly on a failure, the next time a snapshot is created an assert is triggered for: assert(!stream->trace_chunk); inside the snapshot_channel function. Since the str