Re: [lttng-dev] Change to CPU number detection breaks QNX compilation

2022-08-15 Thread Elad Lahav via lttng-dev
/bin/sh on QNX is (by default) ksh, not bash, so perhaps that's the issue. Shouldn't block you from submitting that change. +1 from me, if that matters ;-) --Elad On Mon, 15 Aug 2022 at 13:39, Michael Jeanson wrote: > > On 2022-08-15 12 h 56, Elad Lahav wrote: > > That fixes the build, thanks.

Re: [lttng-dev] Change to CPU number detection breaks QNX compilation

2022-08-15 Thread Elad Lahav via lttng-dev
That fixes the build, thanks. I see some errors coming out of "make check", though: ERROR: test_get_cpu_mask_from_sysfs - missing test plan ERROR: test_get_cpu_mask_from_sysfs - exited with status 1 --Elad On Mon, 15 Aug 2022 at 11:55, Michael Jeanson wrote: > > On 2022-08-15 10 h 04, Elad Lah

[lttng-dev] Change to CPU number detection breaks QNX compilation

2022-08-13 Thread Elad Lahav via lttng-dev
Hello, I have just downloaded and built the library for QNX/aarch64 and noticed that the code in compat-smp.h breaks the build. This file appears to be a (very) recent addition, from this commit: --- commit 5cfe81b7ddff9543d451746de9965cac58c67182 Author: Michael Jeanson Date: Wed Jul 27 10:44