Re: [llvm-commits] SETCC Patches: #3

2006-12-14 Thread Chris Lattner
On Dec 14, 2006, at 7:48 PM, Reid Spencer wrote: >> >> The interpreter is broken: all unsigned comparisons with signed >> operands will hit the unhandled type case. > > Yup. Fixed the macro to take two arguments. The first is to match the > type of the operand. > The second is the type to use to pu

Re: [llvm-commits] SETCC Patches: #3

2006-12-14 Thread Reid Spencer
Hi Chris, Some feedback on your review .. On Mon, 2006-12-11 at 22:51 -0800, Chris Lattner wrote: > > On Dec 10, 2006, at 3:43 PM, Reid Spencer wrote: > > > All, > > > > > > Here's the SETCC patch to convert SetCondInst (SetCC) instructions > > into > > ICmpInst. Here's somethings you shoul