Re: [llvm-commits] Div->[USF]Div Patch, Attempt #2

2006-10-26 Thread Chris Lattner
On Oct 25, 2006, at 9:57 PM, Reid Spencer wrote: >> This code is a bit simpler as: >> >> >> // (X / C1) / C2 -> X / (C1*C2) >> if (BinaryOperator *LHS = dyn_cast(Op0)) >> if (LHS->getOpcode() == I.getOpcode()) >> > > Didn't apply this because it causes a compiler warning about > sign

Re: [llvm-commits] Div->[USF]Div Patch, Attempt #2

2006-10-25 Thread Reid Spencer
Chris, A couple side notes on this one ... On Wed, 2006-10-25 at 21:19 -0700, Chris Lattner wrote: > > Overall, this patch looks very nice. Please fix the one bug below > (adding the regtest) and you are approved to check the whole mess in. Thank you. > // (X / C1) / C2 -> X / (C1*C2)

Re: [llvm-commits] Div->[USF]Div Patch, Attempt #2

2006-10-25 Thread Reid Spencer
All Done. On Wed, 2006-10-25 at 21:03 -0700, Chris Lattner wrote: > > On Oct 25, 2006, at 12:15 PM, Reid Spencer wrote: > > > Attached are two patch files to replace the DIV instruction with 3 > > instructions: SDiv, UDiv, FDiv. The first file patches llvm. The > > second > > file patches llvm-g

Re: [llvm-commits] Div->[USF]Div Patch, Attempt #2

2006-10-25 Thread Reid Spencer
Done. On Wed, 2006-10-25 at 20:37 -0700, Chris Lattner wrote: > > On Oct 25, 2006, at 12:15 PM, Reid Spencer wrote: > > > Attached are two patch files to replace the DIV instruction with 3 > > instructions: SDiv, UDiv, FDiv. The first file patches llvm. The > > second > > file patches llvm-gcc4.

Re: [llvm-commits] Div->[USF]Div Patch, Attempt #2

2006-10-25 Thread Chris Lattner
On Oct 25, 2006, at 12:15 PM, Reid Spencer wrote:Attached are two patch files to replace the DIV instruction with 3instructions: SDiv, UDiv, FDiv. The first file patches llvm. The secondfile patches llvm-gcc4. This is the 2nd attempt to provide the patch.  All comments are welcome.Reid.

Re: [llvm-commits] Div->[USF]Div Patch, Attempt #2

2006-10-25 Thread Chris Lattner
On Oct 25, 2006, at 12:15 PM, Reid Spencer wrote:Attached are two patch files to replace the DIV instruction with 3instructions: SDiv, UDiv, FDiv. The first file patches llvm. The secondfile patches llvm-gcc4. This is the 2nd attempt to provide the patch.  All comments are welcome.This patch is *fa

Re: [llvm-commits] Div->[USF]Div Patch, Attempt #2

2006-10-25 Thread Chris Lattner
On Oct 25, 2006, at 12:15 PM, Reid Spencer wrote:Attached are two patch files to replace the DIV instruction with 3instructions: SDiv, UDiv, FDiv. The first file patches llvm. The secondfile patches llvm-gcc4. This is the 2nd attempt to provide the patch.  All comments are welcome.llvm-gcc part fir