Re: [llvm-commits] CVS: llvm/utils/TableGen/DAGISelEmitter.cpp

2007-05-15 Thread Chris Lattner
>> If the bug was with ISD::Constant's, >> this is a serious bug and this is not the right fix. > > Huh? It has nothing to do with ISD::Constants. Remember > PredicateOperand with ExecuteAlways value is not part of the target > independent DAG. So something like this: > > def BL : I<(ops i32imm:

Re: [llvm-commits] CVS: llvm/utils/TableGen/DAGISelEmitter.cpp

2007-05-15 Thread Evan Cheng
On May 14, 2007, at 10:57 PM, Chris Lattner wrote: >> PredicateOperand related bug fix. >> @@ -2899,7 +2901,7 @@ >>else if (NodeHasOptInFlag) >> EndAdjust = "-(HasInFlag?1:0)"; // May have a flag. >> >> - emitCode("for (unsigned i = " + utostr(NumInputs) + >> +

Re: [llvm-commits] CVS: llvm/utils/TableGen/DAGISelEmitter.cpp

2007-05-14 Thread Chris Lattner
> PredicateOperand related bug fix. > @@ -2899,7 +2901,7 @@ >else if (NodeHasOptInFlag) > EndAdjust = "-(HasInFlag?1:0)"; // May have a flag. > > - emitCode("for (unsigned i = " + utostr(NumInputs) + > + emitCode("for (unsigned i = " + utostr(NumInputs -

Re: [llvm-commits] CVS: llvm/utils/TableGen/DAGISelEmitter.cpp

2006-08-25 Thread Reid Spencer
Evan, Something in this patch or the subsequent ones has broken all builds. Can you fix before the nightly testers all die? Reid. On Sat, 2006-08-26 at 00:30 -0500, Evan Cheng wrote: > > Changes in directory llvm/utils/TableGen: > > DAGISelEmitter.cpp updated: 1.248 -> 1.249 > --- > Log messag

Re: [llvm-commits] CVS: llvm/utils/TableGen/DAGISelEmitter.cpp

2006-01-03 Thread Chris Lattner
Duh, thanks Jeffc! -Chris On Tue, 3 Jan 2006, Jeff Cohen wrote: Changes in directory llvm/utils/TableGen: DAGISelEmitter.cpp updated: 1.122 -> 1.123 --- Log message: Tblgen was generating syntactically illegal C++ code like: SDOperand Tmp0,Tmp1,Tmp2,Tmp3,; GCC has a bug (24907) in whi