On Tue, 2007-02-27 at 14:20 -0800, Chris Lattner wrote:
> On Feb 27, 2007, at 12:51 PM, Reid Spencer wrote:
> > Can't we just change this part of ConstantInt:
.. snip ..
> >
> > into:
.. snip ..
> Yes we could. I would like to do that, but we should do (compile
> time) timings to see if it i
On Feb 27, 2007, at 12:51 PM, Reid Spencer wrote:
> Can't we just change this part of ConstantInt:
>
> /// getTrue/getFalse - Return the singleton true/false values.
> static inline ConstantInt *getTrue() {
> if (TheTrueVal) return TheTrueVal;
> return CreateTrueFalseVals(true);
> }
>
On Feb 27, 2007, at 11:34 AM, Reid Spencer wrote:
> On Tue, 2007-02-27 at 09:10 -0800, Chris Lattner wrote:
>>> Index: llvm/lib/VMCore/Constants.cpp
>>> diff -u llvm/lib/VMCore/Constants.cpp:1.222 llvm/lib/VMCore/
>>> Constants.cpp:1.223
>>> --- llvm/lib/VMCore/Constants.cpp:1.222 Mon Feb 26
Chris,
Can't we just change this part of ConstantInt:
/// getTrue/getFalse - Return the singleton true/false values.
static inline ConstantInt *getTrue() {
if (TheTrueVal) return TheTrueVal;
return CreateTrueFalseVals(true);
}
static inline ConstantInt *getFalse() {
if (TheFals
On Tue, 2007-02-27 at 09:10 -0800, Chris Lattner wrote:
> > Index: llvm/lib/VMCore/Constants.cpp
> > diff -u llvm/lib/VMCore/Constants.cpp:1.222 llvm/lib/VMCore/
> > Constants.cpp:1.223
> > --- llvm/lib/VMCore/Constants.cpp:1.222 Mon Feb 26 21:05:06 2007
> > +++ llvm/lib/VMCore/Constants.cpp
> Index: llvm/lib/VMCore/Constants.cpp
> diff -u llvm/lib/VMCore/Constants.cpp:1.222 llvm/lib/VMCore/
> Constants.cpp:1.223
> --- llvm/lib/VMCore/Constants.cpp:1.222 Mon Feb 26 21:05:06 2007
> +++ llvm/lib/VMCore/Constants.cpp Tue Feb 27 01:57:53 2007
> @@ -118,7 +118,7 @@
> if (ITy
On Mon, 15 Jan 2007, Reid Spencer wrote:
>> Constant *ConstantExpr::getTrunc(Constant *C, const Type *Ty) {
>> - assert(C->getType()->isInteger() && "Trunc operand must be integer");
>> + assert(C->getType()->isIntegral() && "Trunc operand must be integer");
>
> This makes no sense. How can you
On Sun, 2007-01-14 at 18:46 -0600, Chris Lattner wrote:
>
> Changes in directory llvm/lib/VMCore:
>
> Constants.cpp updated: 1.199 -> 1.200
> ---
> Log message:
>
> don't discriminate against i1
Not quite right, see below.
>
>
> ---
> Diffs of the changes: (+9 -9)
>
> Constants.cpp | 18
