Re: [llvm-commits] CVS: llvm/lib/Transforms/Utils/LoopSimplify.cpp

2007-04-09 Thread Chris Lattner
> /// FindPHIToPartitionLoops - The first part of loop-nestification > is to find a > /// PHI node that tells us how to partition the loops. > static PHINode *FindPHIToPartitionLoops(Loop *L, ETForest *EF, > - AliasAnalysis *AA) { > + AliasAnalysis

Re: [llvm-commits] CVS: llvm/lib/Transforms/Utils/LoopSimplify.cpp

2007-04-08 Thread Chris Lattner
>// Can we eliminate this phi node now? >if (Value *V = PN->hasConstantValue(true)) { > -if (!isa(V) || > -getAnalysis().dominates(cast > (V), PN)) { > +Instruction *I = dyn_cast(V); > +if (!I || (I->getParent() != NewBB && > +

Re: [llvm-commits] CVS: llvm/lib/Transforms/Utils/LoopSimplify.cpp

2007-04-08 Thread Chris Lattner
> @@ -727,13 +700,14 @@ >{ > BasicBlock *OnePred = PredBlocks[0]; > unsigned i, e = PredBlocks.size(); > -for (i = 1; !DS.isReachable(OnePred); ++i) { > +for (i = 1; !ETF.dominates(&OnePred->getParent()->getEntryBlock > (), OnePred); ++i) { This line looks long. Can you jus

Re: [llvm-commits] CVS: llvm/lib/Transforms/Utils/LoopSimplify.cpp

2007-04-07 Thread Jeff Cohen
Still have two regressions: Running /usr/home/jeffc/llvm/test/Other/dg.exp ... FAIL: /usr/home/jeffc/llvm/test/Other/2002-01-31-PostDomSet-2.ll: child process exited abnormally opt: Unknown command line argument '-postdomset'. Try: 'opt --help' FAIL: /usr/home/jeffc/llvm/test/Other/2002-01-31-Po