Re: [llvm-commits] CVS: llvm/lib/Bytecode/Writer/Writer.cpp

2007-04-21 Thread Jeff Cohen
Jeff Cohen wrote: > Reid Spencer wrote: > >> Christopher, >> >> I'll answer my own question .. You're compressing the alignment to a >> smaller value by extracting its log. I didn't get that until I read the >> Reader.cpp code :) >> >> Reid. >> > > It's still very expensive. There are alte

Re: [llvm-commits] CVS: llvm/lib/Bytecode/Writer/Writer.cpp

2007-04-21 Thread Jeff Cohen
Reid Spencer wrote: > Christopher, > > I'll answer my own question .. You're compressing the alignment to a > smaller value by extracting its log. I didn't get that until I read the > Reader.cpp code :) > > Reid. It's still very expensive. There are alternative approaches that are much faster an

Re: [llvm-commits] CVS: llvm/lib/Bytecode/Writer/Writer.cpp

2007-04-21 Thread Reid Spencer
Christopher, I'll answer my own question .. You're compressing the alignment to a smaller value by extracting its log. I didn't get that until I read the Reader.cpp code :) Reid. On Sat, 2007-04-21 at 09:46 -0700, Reid Spencer wrote: > Christopher, > > On Sat, 2007-04-21 at 03:17 -0500, Christo

Re: [llvm-commits] CVS: llvm/lib/Bytecode/Writer/Writer.cpp

2007-04-21 Thread Reid Spencer
Christopher, On Sat, 2007-04-21 at 03:17 -0500, Christopher Lamb wrote: > > Changes in directory llvm/lib/Bytecode/Writer: > > Writer.cpp updated: 1.173 -> 1.174 > --- > Log message: > > > add support for alignment attributes on load/store instructions > > > --- > Diffs of the changes: (+27

Re: [llvm-commits] CVS: llvm/lib/Bytecode/Writer/Writer.cpp

2006-12-17 Thread Jeff Cohen
VC++ is happy again. Thanks. Bill Wendling wrote: > Again, I'm really sorry that this cruft got in there...The patch I did > was rather big and a few things escaped my attention. > > -bw > ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://

Re: [llvm-commits] CVS: llvm/lib/Bytecode/Writer/Writer.cpp

2006-12-17 Thread Bill Wendling
Again, I'm really sorry that this cruft got in there...The patch I did was rather big and a few things escaped my attention. -bw On Dec 16, 2006, at 9:55 PM, Jeff Cohen wrote: > This breaks the VC++ build with a "binary '<<' : no operator found > which takes a left-hand operand of type 'llvm

Re: [llvm-commits] CVS: llvm/lib/Bytecode/Writer/Writer.cpp

2006-12-16 Thread Jeff Cohen
This breaks the VC++ build with a "binary '<<' : no operator found which takes a left-hand operand of type 'llvm::OStream' (or there is no acceptable conversion)" error. I would try to fix it, but what is the purpose of this code other than to print some random hex digits? Bill Wendling wrote: