>> Add a default parameter to a SmallVector constructor to allow it to
>> be called with just an initial length value, just like in std::vector.
>
> Ok.
>
> Should this be marked 'explicit'?
Yep. Good catch.
Dan
--
Dan Gohman, Cray Inc.
___
llvm-com
> Add a default parameter to a SmallVector constructor to allow it to
> be called with just an initial length value, just like in std::vector.
Ok.
Should this be marked 'explicit'?
-Chris
>
> ---
> Diffs of the changes: (+1 -1)
>
> SmallVector.h |2 +-
> 1 files changed, 1 insertion(+), 1
On Oct 9, 2006, at 12:56 PM, Andrew Lenharth wrote:
>>
>> Is this what we want here?
>
> I believe so.
I agree, Andrew's patch looks great to me.
-Chris
___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/l
> This compiled on my 3.4.6 compiler on Linux just fine before the patch.
> What was the error you were trying to fix?
"Allignment Value not constant" was the error. This was gcc 3.4.4
> Are you sure this is right? In section 5.31 of the GCC Manual it
> indicates that if an alignment size is not
Andrew,
...
On Mon, 2006-10-09 at 14:05 -0500, Andrew Lenharth wrote:
>
> Changes in directory llvm/include/llvm/ADT:
>
> SmallVector.h updated: 1.19 -> 1.20
> ---
> Log message:
>
> Fix build error in gcc 3.4 and make more this general
This compiled on my 3.4.6 compiler on Linux just fine bef
