Re: [llvm-commits] [llvm] r44874 - /llvm/trunk/lib/CodeGen/MachineLICM.cpp

2007-12-12 Thread Evan Cheng
On Dec 12, 2007, at 2:02 PM, Bill Wendling wrote: > On Dec 12, 2007 11:32 AM, Evan Cheng <[EMAIL PROTECTED]> wrote: >> On Dec 12, 2007, at 11:12 AM, Bill Wendling wrote: >>> I'm sure I could move it, but as Chris asked, isn't it trivial to >>> get >>> this information anyway? Also, I'm kind of

Re: [llvm-commits] [llvm] r44874 - /llvm/trunk/lib/CodeGen/MachineLICM.cpp

2007-12-12 Thread Bill Wendling
On Dec 12, 2007 11:32 AM, Evan Cheng <[EMAIL PROTECTED]> wrote: > On Dec 12, 2007, at 11:12 AM, Bill Wendling wrote: > > I'm sure I could move it, but as Chris asked, isn't it trivial to get > > this information anyway? Also, I'm kind of hesitant to put so much > > effort into compile-time performa

Re: [llvm-commits] [llvm] r44874 - /llvm/trunk/lib/CodeGen/MachineLICM.cpp

2007-12-12 Thread Evan Cheng
vreg definition info is trivial but there is no reverse link from vreg to defining MachineInstruction. That's what MachineLICM::MapVirtualRegisterDefs() is constructing. Evan On Dec 12, 2007, at 11:59 AM, Evan Cheng wrote: > > On Dec 12, 2007, at 9:59 AM, Chris Lattner wrote: > >> >> On Dec

Re: [llvm-commits] [llvm] r44874 - /llvm/trunk/lib/CodeGen/MachineLICM.cpp

2007-12-12 Thread Evan Cheng
On Dec 12, 2007, at 9:59 AM, Chris Lattner wrote: > > On Dec 12, 2007, at 1:38 AM, Evan Cheng wrote: > >> >> >> On Dec 11, 2007, at 11:40 AM, Bill Wendling <[EMAIL PROTECTED]> >> wrote: >> >>> Author: void >>> Date: Tue Dec 11 13:40:06 2007 >>> New Revision: 44874 >>> >>> URL: http://llvm.org/vie

Re: [llvm-commits] [llvm] r44874 - /llvm/trunk/lib/CodeGen/MachineLICM.cpp

2007-12-12 Thread Evan Cheng
On Dec 12, 2007, at 11:12 AM, Bill Wendling wrote: > >> One thing that is some what annoying to me is if LICM is after live >> variables then it won't need to compute vreg def info or liveness >> info. I wonder if it is possible to move the pass after live >> variables? >> > I'm sure I could mov

Re: [llvm-commits] [llvm] r44874 - /llvm/trunk/lib/CodeGen/MachineLICM.cpp

2007-12-12 Thread Bill Wendling
On Dec 12, 2007 1:38 AM, Evan Cheng <[EMAIL PROTECTED]> wrote: > > > On Dec 11, 2007, at 11:40 AM, Bill Wendling <[EMAIL PROTECTED]> wrote: > > > Author: void > > Date: Tue Dec 11 13:40:06 2007 > > New Revision: 44874 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=44874&view=rev > > Log: > >

Re: [llvm-commits] [llvm] r44874 - /llvm/trunk/lib/CodeGen/MachineLICM.cpp

2007-12-12 Thread Chris Lattner
On Dec 12, 2007, at 1:38 AM, Evan Cheng wrote: > > > On Dec 11, 2007, at 11:40 AM, Bill Wendling <[EMAIL PROTECTED]> > wrote: > >> Author: void >> Date: Tue Dec 11 13:40:06 2007 >> New Revision: 44874 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=44874&view=rev >> Log: >> Blark! How in the

Re: [llvm-commits] [llvm] r44874 - /llvm/trunk/lib/CodeGen/MachineLICM.cpp

2007-12-12 Thread Evan Cheng
On Dec 11, 2007, at 11:40 AM, Bill Wendling <[EMAIL PROTECTED]> wrote: > Author: void > Date: Tue Dec 11 13:40:06 2007 > New Revision: 44874 > > URL: http://llvm.org/viewvc/llvm-project?rev=44874&view=rev > Log: > Blark! How in the world did this work without this?! Is this just cosmetic change