Re: [llvm-commits] [126543] Clean up this macro to only eval each argument once.

2007-04-25 Thread Bill
On 4/25/07, Chris Lattner <[EMAIL PROTECTED]> wrote: > > On Apr 25, 2007, at 9:56 AM, Bill wrote: > > > On 4/25/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > >> #undef MOVE_BY_PIECES_P > >> -#define MOVE_BY_PIECES_P(SIZE, ALIGN) ((SIZE-SIZE)+(ALIGN-ALIGN)) > >> +#define MOVE_BY_PIECES_P(SIZE,

Re: [llvm-commits] [126543] Clean up this macro to only eval each argument once.

2007-04-25 Thread Chris Lattner
On Apr 25, 2007, at 9:56 AM, Bill wrote: > On 4/25/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >> #undef MOVE_BY_PIECES_P >> -#define MOVE_BY_PIECES_P(SIZE, ALIGN) ((SIZE-SIZE)+(ALIGN-ALIGN)) >> +#define MOVE_BY_PIECES_P(SIZE, ALIGN) (0*(SIZE)*(ALIGN)) >> > Why not just make it: > > #define

Re: [llvm-commits] [126543] Clean up this macro to only eval each argument once.

2007-04-25 Thread Bill
On 4/25/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > #undef MOVE_BY_PIECES_P > -#define MOVE_BY_PIECES_P(SIZE, ALIGN) ((SIZE-SIZE)+(ALIGN-ALIGN)) > +#define MOVE_BY_PIECES_P(SIZE, ALIGN) (0*(SIZE)*(ALIGN)) > Why not just make it: #define MOVE_BY_PIECES_P(SIZE, ALIGN) 0 ? -bw